Skip to contentSkip to conversation

Enable vlc to run as root

PATCH Superseded jpinto 2 participants 5 messages Sep 16, 2015 – Sep 17, 2015

lore
Share & tools
lore

jpinto

author
#0 lore raw

PATCH v2 1/1 Enable vlc to run as root

From: Joao Pinto <[email protected]>

A great number of embedded systems only include the root user. This patch has the goal of enabling vlc to be ran as root.

---
 package/vlc/vlc.mk | 1 +
 1 file changed, 1 insertion(+)
package/vlc/vlc.mk +1 -0
index 6f7fd58..4e84b12 100644
@@ -54,6 +54,7 @@ VLC_CONF_OPTS += \
 	--disable-mfx \
 	--disable-vdpau \
 	--disable-addonmanagermodules \
+	--enable-run-as-root \
 
 # Building static and shared doesn't work, so force static off.
 ifeq ($(BR2_STATIC_LIBS),)
Signature · 1 line
1.8.1.5
#1 lore raw

PATCH v2 1/1 Enable vlc to run as root

Hello Joao,

Thanks for this new iteration. It looks good, except for one minor nit that isn't very important, but worth mentioning.

Quoted 7 lines · jpinto

From: Joao Pinto <[email protected]>

A great number of embedded systems only include the root user. This patch has the goal of enabling vlc to be ran as root.

It doesn't make sense to include a Tested-by from you on your patch. We obviously expect that you have tested your own patch. Tested-by tags (as well as Acked-by or Reviewed-by tags) are meant to be given by *other* developers, after testing and/or reviewing your patch.

The other minor nit is that the title of the commit still doesn't match the Buildroot best practice, which consists in using titles having the following format:

<package>: <description>

So in your case, it should be:

vlc: enable to run as root

Both issues can be fixed by the Buildroot maintainer when he applies the patch, but I wanted to let you know so you can make things better for your next contribution!

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#2 lore raw

PATCH v2 1/1 Enable vlc to run as root

Hello Thomas,

Quoted 23 lines · Thomas Petazzoni

Hello Joao,

Thanks for this new iteration. It looks good, except for one minor nit that isn't very important, but worth mentioning.

Quoted 7 lines · jpinto

From: Joao Pinto <[email protected]>

A great number of embedded systems only include the root user. This patch has the goal of enabling vlc to be ran as root.

It doesn't make sense to include a Tested-by from you on your patch. We obviously expect that you have tested your own patch. Tested-by tags (as well as Acked-by or Reviewed-by tags) are meant to be given by *other* developers, after testing and/or reviewing your patch.

The other minor nit is that the title of the commit still doesn't match the Buildroot best practice, which consists in using titles having the following format:

Quoted 6 lines

<package>: <description>

So in your case, it should be:

vlc: enable to run as root

Understood, I will have it in mind in future contributions.

Quoted 8 lines

Both issues can be fixed by the Buildroot maintainer when he applies the patch, but I wanted to let you know so you can make things better for your next contribution!

Thanks!

Thomas

Thanks,
Joao

#3 lore raw

PATCH v2 1/1 Enable vlc to run as root

In reply to jpinto

Hello,

Quoted 10 lines · jpinto

From: Joao Pinto <[email protected]>

A great number of embedded systems only include the root user. This patch has the goal of enabling vlc to be ran as root.

---
 package/vlc/vlc.mk | 1 +
 1 file changed, 1 insertion(+)

Thanks, I've applied after tweaking the commit.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#4 lore raw

PATCH v2 1/1 Enable vlc to run as root

Hi Thomas,

Something strange indeed. I will send you a new one in a sec.

Thanks,
Joao

-----Original Message-----
From: Thomas Petazzoni [mailto:thomas.petazzoni at free-electrons.com]
Sent: Wednesday, September 16, 2015 9:35 PM
To: jpinto
Cc: buildroot at buildroot.org
Subject: Re: [Buildroot] [PATCH v2] Enable vlc to run as root

Hello,

Quoted 10 lines · jpinto

From: Joao Pinto <[email protected]>

A great number of embedded systems only include the root user. This patch has the goal of enabling vlc to be ran as root.

---
 package/vlc/vlc.mk | 1 +
 1 file changed, 1 insertion(+)

Thanks, I've applied after tweaking the commit.

Best regards,

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering http://free-electrons.com