Skip to contentSkip to conversation

Enable mplayer to be built in arm64 architectures

PATCH New jpinto 2 participants 2 messages Sep 16, 2015

lore
Share & tools
lore

jpinto

author
#0 lore raw

PATCH v3 1/1 Enable mplayer to be built in arm64 architectures

configure: Added support for aarch64
Config.in: Added support for aarch64

This patch adds support for ARM64 systems to Mplayer 1.1.1 available at buildroot.

---

package/mplayer/0007-mplayer-enable-aarch64.patch new file +13 -0
new file mode 100644
index 0000000..7f75756
@@ -0,0 +1,13 @@
+--- b/configure	2015-09-15 17:30:46.187307557 +0100
++++ a/configure	2015-09-15 17:31:11.729307537 +0100
+@@ -2496,6 +2496,10 @@
+     arch='arc'
+     iproc='arc'
+     ;;
++  aarch64)
++    arch='arm64'
++    iproc='arm64'
++    ;;
+ 
+   *)
+     echo "The architecture of your CPU ($host_arch) is not supported by this configure script"
package/mplayer/Config.in +1 -1
index 79ff3b1..7a8b03f 100644
@@ -3,7 +3,7 @@ config BR2_PACKAGE_MPLAYER_ARCH_SUPPORTS
 	default y
 	# Those architectures are not supported by MPlayer
 	depends on !(BR2_bfin || BR2_sh2a || BR2_sh4a || BR2_sh4aeb \
-		|| BR2_microblaze || BR2_aarch64 || BR2_nios2)
+		|| BR2_microblaze || BR2_nios2)
 	# Broken support for <ARMv5
 	depends on !BR2_ARM_CPU_ARMV4
  
Signature · 1 line
1.8.1.5
#1 lore raw

PATCH v3 1/1 Enable mplayer to be built in arm64 architectures

Hello Joao,

Thanks for your new iteration! However there are still a few issues. I hope you don't mind the number of iterations: we really appreciate your contributions (it's good to have better support for ARM64!) but we also believe it's good to explain what are the best practices to contribute to Buildroot. See below for my comments.

Quoted 2 lines · jpinto

configure: Added support for aarch64
Config.in: Added support for aarch64

This is not really useful. We sometimes do a per-file description when the commit is complicated, but here it doesn't really make sense, especially when the description for each file is the same. Maybe you added this because I asked you to add a "description of the patch", but I think you might have misunderstood my comment (or I explained myself improperly). Read on below for more details on this.

Quoted 6 lines

This patch adds support for ARM64 systems to Mplayer 1.1.1 available at buildroot.

As I explained in my review of your VLC patch, having a Tested-by tag from you does not make much sense: such tags are meant to be given by other developers.

package/mplayer/0007-mplayer-enable-aarch64.patch

Quoted 5 lines
package/mplayer/0007-mplayer-enable-aarch64.patch new file +0 -0
new file mode 100644
index 0000000..7f75756

This is *HERE* where we need a description of the patch. Take as an example
http://git.buildroot.net/buildroot/tree/package/mplayer/0001-disable-install-strip.patch.
See how this file has three things:

1 A description
2 A Signed-off-by line
3 The contents of the patch itself

Your 0007-mplayer-enable-aarch64.patch currently has (3), but is lacking (1) and (2). So basically, just edit this file, add (1) and (2), and that's it!

Quoted 4 lines
package/mplayer/0007-mplayer-enable-aarch64.patch new file +3 -0
@@ -0,0 +1,13 @@
+--- b/configure	2015-09-15 17:30:46.187307557 +0100
++++ a/configure	2015-09-15 17:31:11.729307537 +0100
+@@ -2496,6 +2496,10 @@

package/mplayer/0007-mplayer-enable-aarch64.patch line 13

Quoted 10 lines
package/mplayer/0007-mplayer-enable-aarch64.patch new file +10 -0
+     arch='arc'
+     iproc='arc'
+     ;;
++  aarch64)
++    arch='arm64'
++    iproc='arm64'
++    ;;
+ 
+   *)
+     echo "The architecture of your CPU ($host_arch) is not supported by this configure script"

Finally, the title of the commit is still not completely good. As I explained in my review of your vlc patch, the format of the commit title should always be:

<package>: <description>

So in the case of this patch, something along the lines of:

mplayer: enable building on ARM64

Again, sorry about all the nitpicking!

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com