Skip to contentSkip to conversation

mmc: sdhci-of-at91: remove a line of dead code

PATCH Applied Dan Carpenter 3 participants 3 messages Sep 16, 2015 – Sep 17, 2015

Subsystems (5)
Kernel janitors MMC, SD and SDIO Arm/Microchip (AT91) SoC support Secure digital host controller interface (SDHCI) driver +1 more subsystems
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 mmc: sdhci-of-at91: remove a line of dead code

The goto is correct and the unreachable "return -EINVAL" should be removed.

Signed-off-by Dan Carpenter <[email protected]>
drivers/mmc/host/sdhci-of-at91.c +0 -1
index d155664..d3df786 100644
@@ -110,7 +110,6 @@ static int sdhci_at91_probe(struct platform_device *pdev)
 	if (ret < 0) {
 		dev_err(&pdev->dev, "failed to set gck");
 		goto hclock_disable_unprepare;
-		return -EINVAL;
 	}
 	/*
 	 * We need to check if we have the requested rate for gck because in
Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Dan Carpenter

The goto is correct and the unreachable "return -EINVAL" should be removed.

Signed-off-by Dan Carpenter <[email protected]>

Of course

Acked-by Ludovic Desroches <[email protected]>

Thanks

Quoted 13 lines
drivers/mmc/host/sdhci-of-at91.c +0 -1
index d155664..d3df786 100644
@@ -110,7 +110,6 @@ static int sdhci_at91_probe(struct platform_device *pdev)
 	if (ret < 0) {
 		dev_err(&pdev->dev, "failed to set gck");
 		goto hclock_disable_unprepare;
-		return -EINVAL;
 	}
 	/*
 	 * We need to check if we have the requested rate for gck because in
Applied
#2 lore raw
In reply to Dan Carpenter
Quoted 4 lines · Dan Carpenter

The goto is correct and the unreachable "return -EINVAL" should be removed.

Signed-off-by Dan Carpenter <[email protected]>

Thanks, applied for next!

Kind regards
Uffe

Quoted 13 lines
drivers/mmc/host/sdhci-of-at91.c +0 -1
index d155664..d3df786 100644
@@ -110,7 +110,6 @@ static int sdhci_at91_probe(struct platform_device *pdev)
        if (ret < 0) {
                dev_err(&pdev->dev, "failed to set gck");
                goto hclock_disable_unprepare;
-               return -EINVAL;
        }
        /*
         * We need to check if we have the requested rate for gck because in