Skip to contentSkip to conversation

Include config.mk and features.mk in env_pre.mk for all targets

PATCH New Yuriy Kolerov 2 participants 2 messages Sep 16, 2015 – Sep 17, 2015

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 Include config.mk and features.mk in env_pre.mk for all targets

If config.mk or features.mk doesn't exist it's not an error for some targets which are filtered below (e.g. clean). However these config files may be needed for those targets thus it would be wise to do silent inclusion.

In particular open_posix_testsuite is not cleaned without including these .mk files.

---
 include/mk/env_pre.mk | 7 +++++++
 1 file changed, 7 insertions(+)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Include-config.mk-and-features.mk-in-env_pre.mk-for-.patch
Type: text/x-patch
Size: 704 bytes
Desc: not available
URL: <http://lists.linux.it/pipermail/ltp/attachments/20150916/16d6ee80/attachment.bin>

#1 lore raw

PATCH v2 1/1 Include config.mk and features.mk in env_pre.mk for all targets

Hi!

Review

Quoted 4 lines
(quoted diff) +4 -0
+# If config.mk or features.mk doesn't exist it's not an error for
+# some targets which are filtered below (e.g. clean). However these
+# config files may be needed for those targets thus it would be wise
+# to do silent inclusion.

I've added one more sentence here, to make it clear that open posix testsuite is not cleaned up if we do not include these config files and pushed, thanks.

Signature · 2 lines
Cyril Hrubis
[email protected]