Skip to contentSkip to conversation

usb: host: ehci-spear: Fix module autoload for OF platform driver

PATCH In review Luis de Bethencourt 3 participants 3 messages Sep 18, 2015 – Sep 19, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/4 usb: host: ehci-spear: Fix module autoload for OF platform driver

This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work.

---
 drivers/usb/host/ehci-spear.c | 1 +
 1 file changed, 1 insertion(+)
drivers/usb/host/ehci-spear.c +1 -0
index 34e1474..3c4e525 100644
@@ -149,6 +149,7 @@ static const struct of_device_id spear_ehci_id_table[] = {
 	{ .compatible = "st,spear600-ehci", },
 	{ },
 };
+MODULE_DEVICE_TABLE(of, spear_ehci_id_table);
 
 static struct platform_driver spear_ehci_hcd_driver = {
 	.probe		= spear_ehci_hcd_drv_probe,
Signature · 1 line
2.4.6
maintainer Acked-by on v2 1/4
#1 lore raw
Quoted 14 lines · Luis de Bethencourt

This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work.

---
 drivers/usb/host/ehci-spear.c | 1 +
 1 file changed, 1 insertion(+)
drivers/usb/host/ehci-spear.c +0 -0
index 34e1474..3c4e525 100644

drivers/usb/host/ehci-spear.c static const struct of_device_id spear_ehci_id_table[] = { · line 155

Quoted 7 lines
drivers/usb/host/ehci-spear.c +1 -0
@@ -149,6 +149,7 @@ static const struct of_device_id spear_ehci_id_table[] = {
 	{ .compatible = "st,spear600-ehci", },
 	{ },
 };
+MODULE_DEVICE_TABLE(of, spear_ehci_id_table);
 
 static struct platform_driver spear_ehci_hcd_driver = {
 	.probe		= spear_ehci_hcd_drv_probe,

Also for V2 of patches 3/4 and 4/4.

Alan Stern

#2 lore raw
In reply to Luis de Bethencourt
Quoted 7 lines · Luis de Bethencourt

This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work.

---
 drivers/usb/host/ehci-spear.c | 1 +
 1 file changed, 1 insertion(+)

Ugh, what a mess, please resend the whole series when you fix up a patch in it as this is hard to figure out what to do.

And can you "thread" the patch series properly? That makes it much easier for me to apply them as I can group them correctly.

thanks,

greg k-h