Skip to contentSkip to conversation

Staging: android: Fix 80 character length

PATCH In review Punit Vara 2 participants 2 messages Sep 18, 2015 – Sep 19, 2015 Staging

lore
Share & tools
lore

Punit Vara

author
#0 lore raw

PATCH 1/1 Staging: android: Fix 80 character length

This patch is to the Kconfig file which fixes up lines which exceeded the standard 80 character limitation. This file also fixes up 3 warnings regarding paragraph.

---
 drivers/staging/android/Kconfig | 28 ++++++++++++++++------------
 1 file changed, 16 insertions(+), 12 deletions(-)
drivers/staging/android/Kconfig +16 -12
index 42b1512..f4a2371 100644
@@ -12,7 +12,8 @@ config ASHMEM
 	  file-based API.
 
 	  It is, in theory, a good memory allocator for low-memory devices,
-	  because it can discard shared memory units when under memory pressure.
+	  because it can discard shared memory units when under memory
+	  pressure.
 
 config ANDROID_TIMED_OUTPUT
 	bool "Timed output class driver"
@@ -24,19 +25,20 @@ config ANDROID_TIMED_GPIO
 	depends on ANDROID_TIMED_OUTPUT
 	default n
         ---help---
-	  Unlike generic gpio is to allow programs to access and manipulate gpio
-	  registers from user space, timed output/gpio is a system to allow changing
-	  a gpio pin and restore it automatically after a specified timeout.
+	  Unlike generic gpio is to allow programs to access and manipulate
+	  gpio registers from user space, timed output/gpio is a system to
+	  allow changing a gpio pin and restore it automatically after a
+	  specified timeout.
 
 config ANDROID_LOW_MEMORY_KILLER
 	bool "Android Low Memory Killer"
 	---help---
-	  Registers processes to be killed when low memory conditions, this is useful
-	  as there is no particular swap space on android.
+	  Registers processes to be killed when low memory conditions, this
+	  is useful as there is no particular swap space on android.
 
-	  The registered process will kills according to the priorities in android init
-	  scripts (/init.rc), and it defines priority values with minimum free memory size
-	  for each priority.
+	  The registered process will kills according to the priorities in
+	  android init scripts (/init.rc), and it defines priority values with
+	  minimum free memory size for each priority.
 
 config SYNC
 	bool "Synchronization framework"
@@ -44,8 +46,9 @@ config SYNC
 	select ANON_INODES
 	select DMA_SHARED_BUFFER
 	---help---
-	  This option enables the framework for synchronization between multiple
-	  drivers.  Sync implementations can take advantage of hardware
+	  This option enables the framework for synchronization between
+	  multiple drivers.
+	  Sync implementations can take advantage of hardware
 	  synchronization built into devices like GPUs.
 
 config SW_SYNC
@@ -54,7 +57,8 @@ config SW_SYNC
 	depends on SYNC
 	---help---
 	  A sync object driver that uses a 32bit counter to coordinate
-	  synchronization.  Useful when there is no hardware primitive backing
+	  synchronization.
+	  Useful when there is no hardware primitive backing
 	  the synchronization.
 
 config SW_SYNC_USER
Signature · 1 line
2.5.2
maintainer
#1 lore raw
Quoted 3 lines · Punit Vara

This patch is to the Kconfig file which fixes up lines which exceeded the standard 80 character limitation. This file also fixes up 3 warnings regarding paragraph.

Why is this indented?

Quoted 11 lines
---
 drivers/staging/android/Kconfig | 28 ++++++++++++++++------------
 1 file changed, 16 insertions(+), 12 deletions(-)
drivers/staging/android/Kconfig +0 -0
index 42b1512..f4a2371 100644

drivers/staging/android/Kconfig config ASHMEM · line 15

Quoted 4 lines
drivers/staging/android/Kconfig +0 -1
@@ -12,7 +12,8 @@ config ASHMEM
 	  file-based API.
 
 	  It is, in theory, a good memory allocator for low-memory devices,
-	  because it can discard shared memory units when under memory pressure.

This is 80 characters wide, no need to change it.

Quoted 35 lines
drivers/staging/android/Kconfig +11 -8
+	  because it can discard shared memory units when under memory
+	  pressure.
 
 config ANDROID_TIMED_OUTPUT
 	bool "Timed output class driver"
@@ -24,19 +25,20 @@ config ANDROID_TIMED_GPIO
 	depends on ANDROID_TIMED_OUTPUT
 	default n
         ---help---
-	  Unlike generic gpio is to allow programs to access and manipulate gpio
-	  registers from user space, timed output/gpio is a system to allow changing
-	  a gpio pin and restore it automatically after a specified timeout.
+	  Unlike generic gpio is to allow programs to access and manipulate
+	  gpio registers from user space, timed output/gpio is a system to
+	  allow changing a gpio pin and restore it automatically after a
+	  specified timeout.
 
 config ANDROID_LOW_MEMORY_KILLER
 	bool "Android Low Memory Killer"
 	---help---
-	  Registers processes to be killed when low memory conditions, this is useful
-	  as there is no particular swap space on android.
+	  Registers processes to be killed when low memory conditions, this
+	  is useful as there is no particular swap space on android.
 
-	  The registered process will kills according to the priorities in android init
-	  scripts (/init.rc), and it defines priority values with minimum free memory size
-	  for each priority.
+	  The registered process will kills according to the priorities in
+	  android init scripts (/init.rc), and it defines priority values with
+	  minimum free memory size for each priority.
 
 config SYNC
 	bool "Synchronization framework"

drivers/staging/android/Kconfig config SYNC · line 47

Quoted 4 lines
drivers/staging/android/Kconfig +0 -1
@@ -44,8 +46,9 @@ config SYNC
 	select ANON_INODES
 	select DMA_SHARED_BUFFER
 	---help---
-	  This option enables the framework for synchronization between multiple

This is also ok.

drivers/staging/android/Kconfig config SW_SYNC · line 57

Quoted 12 lines
drivers/staging/android/Kconfig +3 -2
-	  drivers.  Sync implementations can take advantage of hardware
+	  This option enables the framework for synchronization between
+	  multiple drivers.
+	  Sync implementations can take advantage of hardware
 	  synchronization built into devices like GPUs.
 
 config SW_SYNC
@@ -54,7 +57,8 @@ config SW_SYNC
 	depends on SYNC
 	---help---
 	  A sync object driver that uses a 32bit counter to coordinate
-	  synchronization.  Useful when there is no hardware primitive backing

And this is just fine, why change it?

thanks,

greg k-h