Skip to contentSkip to conversation

micropython: Add upstream patch to fix 64-bit builds

PATCH New Chris Packham 3 participants 3 messages Sep 20, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 micropython: Add upstream patch to fix 64-bit builds

Fixes the following error when building for a 64-bit target

../py/objint_mpz.c:54:5: error: right shift count >= width of type [-Werror]

       (MP_SSIZE_MAX >> MPZ_DIG_SIZE * 4) & DIG_MASK,
       ^

../py/objint_mpz.c:54:5: error: initializer element is not constant ../py/objint_mpz.c:54:5: error: (near initialization for 'maxsize_dig[4]')

---
So this is the upstream patch that fixes the build problem and replaces
http://lists.busybox.net/pipermail/buildroot/2015-September/139826.html

 package/micropython/micropython.mk | 1 +
 1 file changed, 1 insertion(+)
package/micropython/micropython.mk +1 -0
index 6266882..f2ad5bf 100644
@@ -9,6 +9,7 @@ MICROPYTHON_SITE = $(call github,micropython,micropython,$(MICROPYTHON_VERSION))
 MICROPYTHON_LICENSE = MIT
 MICROPYTHON_LICENSE_FILES = LICENSE
 MICROPYTHON_DEPENDENCIES = host-pkgconf libffi
+MICROPYTHON_PATCH = https://github.com/micropython/micropython/commit/8b4fb4fe140e9cf57fcfa258d0d2d6fe19090fc5.patch
 
 # Use fallback implementation for exception handling on architectures that don't
 # have explicit support.
Signature · 1 line
2.5.0
#1 lore raw

PATCH 1/1 micropython: Add upstream patch to fix 64-bit builds

Dear Chris Packham,

Quoted 9 lines · Chris Packham

Fixes the following error when building for a 64-bit target

   ../py/objint_mpz.c:54:5: error: right shift count >= width of type [-Werror]
        (MP_SSIZE_MAX >> MPZ_DIG_SIZE * 4) & DIG_MASK,
        ^
   ../py/objint_mpz.c:54:5: error: initializer element is not constant
   ../py/objint_mpz.c:54:5: error: (near initialization for 'maxsize_dig[4]')

I have built micropython for MIPS32, MIPS64 n32* and MIPS64 n64. All fine.

*: after applying this patch:

https://github.com/micropython/micropython/pull/1471

Regards,

Vincent.

Quoted 20 lines

---
So this is the upstream patch that fixes the build problem and replaces
http://lists.busybox.net/pipermail/buildroot/2015-September/139826.html

  package/micropython/micropython.mk | 1 +
  1 file changed, 1 insertion(+)
package/micropython/micropython.mk +1 -0
index 6266882..f2ad5bf 100644
@@ -9,6 +9,7 @@ MICROPYTHON_SITE = $(call github,micropython,micropython,$(MICROPYTHON_VERSION))
  MICROPYTHON_LICENSE = MIT
  MICROPYTHON_LICENSE_FILES = LICENSE
  MICROPYTHON_DEPENDENCIES = host-pkgconf libffi
+MICROPYTHON_PATCH = https://github.com/micropython/micropython/commit/8b4fb4fe140e9cf57fcfa258d0d2d6fe19090fc5.patch
 
  # Use fallback implementation for exception handling on architectures that don't
  # have explicit support.
#2 lore raw

PATCH 1/1 micropython: Add upstream patch to fix 64-bit builds

In reply to Chris Packham

Dear Chris Packham,

Quoted 5 lines · Chris Packham

Fixes the following error when building for a 64-bit target

../py/objint_mpz.c:54:5: error: right shift count >= width of type [-Werror]

       (MP_SSIZE_MAX >> MPZ_DIG_SIZE * 4) & DIG_MASK,
       ^
Quoted 7 lines

../py/objint_mpz.c:54:5: error: initializer element is not constant ../py/objint_mpz.c:54:5: error: (near initialization for 'maxsize_dig[4]')

---
So this is the upstream patch that fixes the build problem and replaces
http://lists.busybox.net/pipermail/buildroot/2015-September/139826.html

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com