Skip to contentSkip to conversation

make: disable guile support when static linking enabled

PATCH New Ryan Barnett 3 participants 5 messages Sep 20, 2015 – Oct 12, 2015

lore
Share & tools
lore

Ryan Barnett

author
#0 lore raw

PATCH v2 1/1 make: disable guile support when static linking enabled

When building in a static only configuration with guile package enabled, the following error happens:

gc_pthread_redirects.h:37:22: fatal error: dlfcn.h: No such file or directory
# include <dlfcn.h>

The file gc_pthread_redirects.h comes from bdwgc, which gets built before make in the autobuild test case you're pointing to. This header file is known to incorrectly include <dlfcn.h>, unless GC_NO_DLOPEN is specified.

IF GC_NO_DLOPEN is defined, another issue arises due to libguile and libintl both defining locale_charset.

Thus disable guile support for make.

Fixes:
http://autobuild.buildroot.net/results/814/8143ae0afac139845e5016058d85c800dc8527ad

Signed-off-by Ryan Barnett <[email protected]>
---
 package/make/make.mk | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)
package/make/make.mk +2 -7
index ebfa2f0..20702dc 100644
@@ -11,16 +11,11 @@ MAKE_DEPENDENCIES = $(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),gettext)
 MAKE_LICENSE = GPLv3+
 MAKE_LICENSE_FILES = COPYING
 
+MAKE_CONF_OPTS = --without-guile
+
 # Disable the 'load' operation for static builds since it needs dlopen
 ifeq ($(BR2_STATIC_LIBS),y)
 MAKE_CONF_OPTS += --disable-load
 endif
 
-ifeq ($(BR2_PACKAGE_GUILE),y)
-MAKE_DEPENDENCIES += guile
-MAKE_CONF_OPTS += --with-guile
-else
-MAKE_CONF_OPTS += --without-guile
-endif
-
 $(eval $(autotools-package))
Signature · 1 line
1.9.1
#1 lore raw

PATCH v2 1/1 make: disable guile support when static linking enabled

Ryan, All,

On 2015-09-20 16:10 -0500, Ryan Barnett spake thusly:

Quoted 9 lines

When building in a static only configuration with guile package enabled, the following error happens:

gc_pthread_redirects.h:37:22: fatal error: dlfcn.h: No such file or directory
# include <dlfcn.h>

The file gc_pthread_redirects.h comes from bdwgc, which gets built before make in the autobuild test case you're pointing to. This header

Maby replace "the autobuild test case you're pointing to" with "the autobuild test case referenced below".

Quoted 27 lines

file is known to incorrectly include <dlfcn.h>, unless GC_NO_DLOPEN is specified.

IF GC_NO_DLOPEN is defined, another issue arises due to libguile and libintl both defining locale_charset.

Thus disable guile support for make.

Fixes:
http://autobuild.buildroot.net/results/814/8143ae0afac139845e5016058d85c800dc8527ad

Signed-off-by Ryan Barnett <[email protected]>
---
 package/make/make.mk | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)
package/make/make.mk +2 -0
index ebfa2f0..20702dc 100644
@@ -11,16 +11,11 @@ MAKE_DEPENDENCIES = $(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),gettext)
 MAKE_LICENSE = GPLv3+
 MAKE_LICENSE_FILES = COPYING
 
+MAKE_CONF_OPTS = --without-guile
+
 # Disable the 'load' operation for static builds since it needs dlopen

package/make/make.mk MAKE_DEPENDENCIES = $(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),gettext) · line 24

Quoted 10 lines
package/make/make.mk +0 -6
 ifeq ($(BR2_STATIC_LIBS),y)
 MAKE_CONF_OPTS += --disable-load
 endif
 
-ifeq ($(BR2_PACKAGE_GUILE),y)
-MAKE_DEPENDENCIES += guile
-MAKE_CONF_OPTS += --with-guile
-else
-MAKE_CONF_OPTS += --without-guile
-endif

Hm.. not sure we want to unconditionally disable guile support in make.

What about:

    ifeq ($(BR2_STATIC_LIBS):$(BR2_PACKAGE_GUILE),:y)
    MAKE_DEPENDENCIES += guile
    MAKE_CONF_OPTS += --with-guile
    else
    MAKE_CONF_OPTS += --without-guile
    endif

Regards,
Yann E. MORIN.

Quoted 8 lines
package/make/make.mk +0 -0
 $(eval $(autotools-package))
Signature · 6 lines
1.9.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
author
#2 lore raw

PATCH v2 1/1 make: disable guile support when static linking enabled

Yann,

Quoted 56 lines · Yann E. MORIN

Ryan, All,

On 2015-09-20 16:10 -0500, Ryan Barnett spake thusly:

Quoted 9 lines

When building in a static only configuration with guile package enabled, the following error happens:

gc_pthread_redirects.h:37:22: fatal error: dlfcn.h: No such file or directory
# include <dlfcn.h>

The file gc_pthread_redirects.h comes from bdwgc, which gets built before make in the autobuild test case you're pointing to. This header

Maby replace "the autobuild test case you're pointing to" with "the autobuild test case referenced below".

Quoted 27 lines

file is known to incorrectly include <dlfcn.h>, unless GC_NO_DLOPEN is specified.

IF GC_NO_DLOPEN is defined, another issue arises due to libguile and libintl both defining locale_charset.

Thus disable guile support for make.

Fixes:
http://autobuild.buildroot.net/results/814/8143ae0afac139845e5016058d85c800dc8527ad

Signed-off-by Ryan Barnett <[email protected]>
---
 package/make/make.mk | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)
package/make/make.mk +2 -0
index ebfa2f0..20702dc 100644
@@ -11,16 +11,11 @@ MAKE_DEPENDENCIES = $(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),gettext)
 MAKE_LICENSE = GPLv3+
 MAKE_LICENSE_FILES = COPYING
 
+MAKE_CONF_OPTS = --without-guile
+
 # Disable the 'load' operation for static builds since it needs dlopen

package/make/make.mk MAKE_DEPENDENCIES = $(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),gettext) · line 24

Quoted 10 lines
package/make/make.mk +0 -6
 ifeq ($(BR2_STATIC_LIBS),y)
 MAKE_CONF_OPTS += --disable-load
 endif
 
-ifeq ($(BR2_PACKAGE_GUILE),y)
-MAKE_DEPENDENCIES += guile
-MAKE_CONF_OPTS += --with-guile
-else
-MAKE_CONF_OPTS += --without-guile
-endif

Hm.. not sure we want to unconditionally disable guile support in make.

Quoted 8 lines

What about:

    ifeq ($(BR2_STATIC_LIBS):$(BR2_PACKAGE_GUILE),:y)
    MAKE_DEPENDENCIES += guile
    MAKE_CONF_OPTS += --with-guile
    else
    MAKE_CONF_OPTS += --without-guile
    endif

I had proposed that but Thomas had said just to disable it all
together and Baruch - who originally submitted the package said that
he agreed. See http://lists.busybox.net/pipermail/buildroot/2015-September/139980.html

I am going to keep with disabling it unconditionally.

Thanks,
-Ryan

#3 lore raw

PATCH v2 1/1 make: disable guile support when static linking enabled

Ryan, All,

On 2015-09-20 17:00 -0500, Ryan Barnett spake thusly:

Quoted 66 lines · Yann E. MORIN
Quoted 56 lines

Ryan, All,

On 2015-09-20 16:10 -0500, Ryan Barnett spake thusly:

Quoted 9 lines

When building in a static only configuration with guile package enabled, the following error happens:

gc_pthread_redirects.h:37:22: fatal error: dlfcn.h: No such file or directory
# include <dlfcn.h>

The file gc_pthread_redirects.h comes from bdwgc, which gets built before make in the autobuild test case you're pointing to. This header

Maby replace "the autobuild test case you're pointing to" with "the autobuild test case referenced below".

Quoted 27 lines

file is known to incorrectly include <dlfcn.h>, unless GC_NO_DLOPEN is specified.

IF GC_NO_DLOPEN is defined, another issue arises due to libguile and libintl both defining locale_charset.

Thus disable guile support for make.

Fixes:
http://autobuild.buildroot.net/results/814/8143ae0afac139845e5016058d85c800dc8527ad

Signed-off-by Ryan Barnett <[email protected]>
---
 package/make/make.mk | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)
package/make/make.mk +2 -0
index ebfa2f0..20702dc 100644
@@ -11,16 +11,11 @@ MAKE_DEPENDENCIES = $(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),gettext)
 MAKE_LICENSE = GPLv3+
 MAKE_LICENSE_FILES = COPYING
 
+MAKE_CONF_OPTS = --without-guile
+
 # Disable the 'load' operation for static builds since it needs dlopen

package/make/make.mk MAKE_DEPENDENCIES = $(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),gettext) · line 24

Quoted 10 lines
package/make/make.mk +0 -6
 ifeq ($(BR2_STATIC_LIBS),y)
 MAKE_CONF_OPTS += --disable-load
 endif
 
-ifeq ($(BR2_PACKAGE_GUILE),y)
-MAKE_DEPENDENCIES += guile
-MAKE_CONF_OPTS += --with-guile
-else
-MAKE_CONF_OPTS += --without-guile
-endif

Hm.. not sure we want to unconditionally disable guile support in make.

Quoted 8 lines

What about:

    ifeq ($(BR2_STATIC_LIBS):$(BR2_PACKAGE_GUILE),:y)
    MAKE_DEPENDENCIES += guile
    MAKE_CONF_OPTS += --with-guile
    else
    MAKE_CONF_OPTS += --without-guile
    endif
Quoted 3 lines

I had proposed that but Thomas had said just to disable it all
together and Baruch - who originally submitted the package said that
he agreed. See http://lists.busybox.net/pipermail/buildroot/2015-September/139980.html

OK, if Thomas said so! ;-)

Quoted 1 line

I am going to keep with disabling it unconditionally.

OK.

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#4 lore raw

PATCH v2 1/1 make: disable guile support when static linking enabled

In reply to Ryan Barnett

Dear Ryan Barnett,

Quoted 17 lines · Ryan Barnett

When building in a static only configuration with guile package enabled, the following error happens:

gc_pthread_redirects.h:37:22: fatal error: dlfcn.h: No such file or directory
# include <dlfcn.h>

The file gc_pthread_redirects.h comes from bdwgc, which gets built before make in the autobuild test case you're pointing to. This header file is known to incorrectly include <dlfcn.h>, unless GC_NO_DLOPEN is specified.

IF GC_NO_DLOPEN is defined, another issue arises due to libguile and libintl both defining locale_charset.

Thus disable guile support for make.

Quoted 7 lines

Fixes:
http://autobuild.buildroot.net/results/814/8143ae0afac139845e5016058d85c800dc8527ad

Signed-off-by Ryan Barnett <[email protected]>
---
 package/make/make.mk | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

Applied after tweaking the commit log, thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com