Skip to contentSkip to conversation

fstests: Add test of rename

PATCH In review Jan Kara 2 participants 2 messages Aug 25, 2015 – Sep 21, 2015

lore
Share & tools
lore

Jan Kara

author
#0 lore raw

PATCH 1/1 fstests: Add test of rename

Test renaming of various entry types in directories of various sizes. Check that filesystem didn't get corrupted.

---
 tests/generic/326   | 93 +++++++++++++++++++++++++++++++++++++++++++++++++++++
 tests/generic/group |  1 +
 2 files changed, 94 insertions(+)
 create mode 100755 tests/generic/326

This is a regression test for ftype handling bug I've fixed last week in XFS. I've made the test to iterate relatively densely over a wide range of directory sizes so that it can be used to test handling of different directory formats also for other filesystems (e.g. ext4 has inline & normal directories, UDF as well). I have verified that for XFS we test directory operations for all directory types.

tests/generic/326 new file +93 -0
new file mode 100755
index 000000000000..a8d9e9b5a34f
@@ -0,0 +1,93 @@
+#! /bin/bash
+# FS QA Test No. 326
+#
+# Test rename for various sizes of directories. This is motivated by a bug
+# in XFS where directory entry file type was not updated properly on rename.
+#
+#-----------------------------------------------------------------------
+# Copyright (C) 2015 SUSE Linux Products GmbH. All Rights Reserved.
+# Author: Jan Kara <[email protected]>
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it would be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write the Free Software Foundation,
+# Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+#-----------------------------------------------------------------------
+#
+
+seq=`basename $0`
+seqres=$RESULT_DIR/$seq
+echo "QA output created by $seq"
+
+here=`pwd`
+status=1	# failure is the default!
+
+filldir()
+{
+	for (( i = 0; i < $1; i++ )); do
+		touch "fname$i"
+	done
+}
+
+# Test renaming of file, symlink over file, symlink, non-existent
+# name
+renamedir()
+{
+	touch fs1
+	touch fs2
+	touch fs3
+	touch fd1
+	touch fd2
+	ln -s foo ss1
+	ln -s foo ss2
+	ln -s foo ss3
+	ln -s foo sd1
+	ln -s foo sd2
+
+	mv -T fs1 fd1
+	mv -T fs2 sd1
+	mv -T fs3 ed1
+
+	mv -T ss1 fd2
+	mv -T ss2 sd2
+	mv -T ss3 ed2
+}
+
+# get standard environment, filters and checks
+. ./common/rc
+. ./common/filter
+. ./common/log
+
+# real QA test starts here
+_supported_fs generic
+_supported_os Linux
+_require_scratch
+
+rm -f $seqres.full
+
+_scratch_mkfs >> $seqres.full 2>&1
+_scratch_mount >> $seqres.full 2>&1
+
+# Test different directory sizes to test various directory formats
+for f in 1 2 3 4 5 8 12 18 27 40 60 90 135 202 303 454 681 1020 1530 2295; do
+	mkdir $SCRATCH_MNT/dir$f
+	pushd $SCRATCH_MNT/dir$f >/dev/null
+	filldir $f
+	renamedir
+	popd >/dev/null
+done
+
+if _check_scratch_fs; then
+	_echofull "Scratch fs is fine after renames"
+	status=0
+fi
+
+exit
tests/generic/group +1 -0
index a33536ec2a0a..612cb8efe879 100644
@@ -204,3 +204,4 @@
 323 auto aio stress
 324 auto fsr quick
 325 auto quick data log
+326 auto metadata dir
Signature · 1 line
2.1.4
#1 lore raw
Quoted 9 lines · Jan Kara

Test renaming of various entry types in directories of various sizes. Check that filesystem didn't get corrupted.

---
 tests/generic/326   | 93 +++++++++++++++++++++++++++++++++++++++++++++++++++++
 tests/generic/group |  1 +
 2 files changed, 94 insertions(+)
 create mode 100755 tests/generic/326

Missing an output file. I'll fix it on commit.

tests/generic/326 line 91

Quoted 4 lines
tests/generic/326 new file +4 -0
+if _check_scratch_fs; then
+	_echofull "Scratch fs is fine after renames"
+	status=0
+fi

This happens automatically now as a result of _require_scratch being called, so I'll remove it.

Cheers,

Dave.

Signature · 2 lines
Dave Chinner
[email protected]