mei: hbm: fix error in state check logic
Subsystems (2)
From: Alexander Usyskin <[email protected]>
Use || instead && in state check.
Latter is bogus and leads to following warning:
drivers/misc/mei/hbm.c:1212:46: warning: logical ‘and’ of mutually exclusive tests is always false [-Wlogical-op]
Fixes 073e6274 ("mei: support for dynamic clients")
Reported-by David Binderman <[email protected]>
Signed-off-by Alexander Usyskin <[email protected]>
Signed-off-by Tomas Winkler <[email protected]>
--- drivers/misc/mei/hbm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/misc/mei/hbm.c +1 -1
@@ -1209,7 +1209,7 @@ int mei_hbm_dispatch(struct mei_device *dev, struct mei_msg_hdr *hdr)* after the host receives the enum_resp * message clients may be added or removed */ -if (dev->hbm_state <=MEI_HBM_ENUM_CLIENTS && +if (dev->hbm_state <=MEI_HBM_ENUM_CLIENTS || dev->hbm_state >=MEI_HBM_STOPPED ) {dev_err (dev->dev,"hbm: add client: state mismatch, [%d, %d]\n" , dev->dev_state, dev->hbm_state);
Signature · 1 line
2.4.3
Greg Kroah-Hartman
maintainerQuoted 8 lines · Tomas Winkler
From: Alexander Usyskin <[email protected]>
Use || instead && in state check.
Latter is bogus and leads to following warning:
drivers/misc/mei/hbm.c:1212:46: warning: logical ‘and’ of mutually exclusive tests is always false [-Wlogical-op]Fixes 073e6274 ("mei: support for dynamic clients")
This isn't a commit id in Linus's tree anywhere, where did you get that number from? Please fix it and use a valid one.
thanks,
greg k-h