gpio: omap: switch to use platform_get_irq

DISCUSSION Dan Carpenter 1 participant 1 message Sep 21, 2015 GPIO

Share & tools

Dan Carpenter

author

2015-09-21 16:26 UTC #0 lore raw

Hello Grygorii Strashko,

The patch 89d18e3af8b9: "gpio: omap: switch to use platform_get_irq" from Aug 18, 2015, leads to the following static checker warning:

	drivers/gpio/gpio-omap.c:1191 omap_gpio_probe()
	warn: assigning (-6) to unsigned variable 'bank->irq'

drivers/gpio/gpio-omap.c
1188 bank->irq = platform_get_irq(pdev, 0);
1189 if (bank->irq <= 0) {

bank->irq is u16.

  1190                  if (!bank->irq)
  1191                          bank->irq = -ENXIO;

Does not work.

1192 if (bank->irq != -EPROBE_DEFER)

Does not work.

  1193                          dev_err(dev,
  1194                                  "can't get irq resource ret=%d\n", bank->irq);
  1195                  return bank->irq;
  1196          }

regards,
dan carpenter