ssb: unexport ssb_bus_pcibus_register
PATCH 1/3 ssb: unexport ssb_bus_pcibus_register
It isn't used anywhere out of ssb code and we don't (plan to) build pcihost_wrapper.c as a separated module.
--- drivers/ssb/main.c | 1 - 1 file changed, 1 deletion(-)
drivers/ssb/main.c +0 -1
@@ -876,7 +876,6 @@ int ssb_bus_pcibus_register(struct ssb_bus *bus, struct pci_dev *host_pci) return err; } -EXPORT_SYMBOL (ssb_bus_pcibus_register);#endif /* CONFIG_SSB_PCIHOST */ #ifdef CONFIG_SSB_PCMCIAHOST
Signature · 1 line
1.8.4.5
PATCH 2/3 ssb: make ssb_sdio_switch_core static
It's used locally only.
--- drivers/ssb/sdio.c | 2 +- drivers/ssb/ssb_private.h | 6 ------ 2 files changed, 1 insertion(+), 7 deletions(-)
drivers/ssb/sdio.c +1 -1
@@ -200,7 +200,7 @@ out: }/* host must be already claimed */ -int ssb_sdio_switch_core (struct ssb_bus *bus,struct ssb_device *dev) +static int ssb_sdio_switch_core (struct ssb_bus *bus,struct ssb_device *dev) {u8 coreidx = dev->core_index;u32 sbaddr;
drivers/ssb/ssb_private.h +0 -6
@@ -132,7 +132,6 @@ extern int ssb_sdio_get_invariants(struct ssb_bus *bus, struct ssb_init_invariants *iv);extern u32 ssb_sdio_scan_read32 (struct ssb_bus *bus,u16 offset); -extern int ssb_sdio_switch_core (struct ssb_bus *bus,struct ssb_device *dev);extern int ssb_sdio_scan_switch_coreidx (struct ssb_bus *bus,u8 coreidx);extern int ssb_sdio_hardware_setup (struct ssb_bus *bus);extern void ssb_sdio_exit (struct ssb_bus *bus);
@@ -144,11 +143,6 @@ static inline u32 ssb_sdio_scan_read32(struct ssb_bus *bus, u16 offset) {return 0 ; } -static inline int ssb_sdio_switch_core (struct ssb_bus *bus, -struct ssb_device *dev) -{ -return 0 ; -}static inline int ssb_sdio_scan_switch_coreidx (struct ssb_bus *bus,u8 coreidx) {return 0 ;
Signature · 1 line
1.8.4.5
Re: [PATCH 2/3] ssb: make ssb_sdio_switch_core static
Quoted 35 lines · On Mon, 21 Sep 2015 09:47:19 +0200 Rafał Miłecki <[email protected]> wrote:
It's used locally only.
Signed-off-by Rafał Miłecki <[email protected]>--- drivers/ssb/sdio.c | 2 +- drivers/ssb/ssb_private.h | 6 ------ 2 files changed, 1 insertion(+), 7 deletions(-)drivers/ssb/sdio.c +1
-1@@ -200,7 +200,7 @@ out: }/* host must be already claimed */ -int ssb_sdio_switch_core (struct ssb_bus *bus,struct ssb_device *dev) +static int ssb_sdio_switch_core (struct ssb_bus *bus,struct ssb_device *dev) {u8 coreidx = dev->core_index;u32 sbaddr;drivers/ssb/ssb_private.h +0
-1@@ -132,7 +132,6 @@ extern int ssb_sdio_get_invariants(struct ssb_bus *bus, struct ssb_init_invariants *iv);extern u32 ssb_sdio_scan_read32 (struct ssb_bus *bus,u16 offset); -extern int ssb_sdio_switch_core (struct ssb_bus *bus,struct ssb_device *dev);extern int ssb_sdio_scan_switch_coreidx (struct ssb_bus *bus,u8 coreidx);extern int ssb_sdio_hardware_setup (struct ssb_bus *bus);extern void ssb_sdio_exit (struct ssb_bus *bus);@@ -144,11 +143,6 @@ static inline u32 ssb_sdio_scan_read32(struct ssb_bus *bus, u16 offset) {
drivers/ssb/ssb_private.h static inline u32 ssb_sdio_scan_read32(struct ssb_bus *bus, u16 offset) · line 148
Quoted 10 lines
drivers/ssb/ssb_private.h +0
-5return 0 ; } -static inline int ssb_sdio_switch_core (struct ssb_bus *bus, -struct ssb_device *dev) -{ -return 0 ; -}static inline int ssb_sdio_scan_switch_coreidx (struct ssb_bus *bus,u8 coreidx) {return 0 ;
Signature · 1 line
Michael
PATCH 3/3 ssb: drop declaration of non existing ssb_sdio_hardware_setup
In reply to Rafał Miłecki--- drivers/ssb/ssb_private.h | 5 ----- 1 file changed, 5 deletions(-)
drivers/ssb/ssb_private.h +0 -5
@@ -133,7 +133,6 @@ extern int ssb_sdio_get_invariants(struct ssb_bus *bus,extern u32 ssb_sdio_scan_read32 (struct ssb_bus *bus,u16 offset);extern int ssb_sdio_scan_switch_coreidx (struct ssb_bus *bus,u8 coreidx); -extern int ssb_sdio_hardware_setup (struct ssb_bus *bus);extern void ssb_sdio_exit (struct ssb_bus *bus);extern int ssb_sdio_init (struct ssb_bus *bus);
@@ -147,10 +146,6 @@ static inline int ssb_sdio_scan_switch_coreidx(struct ssb_bus *bus, u8 coreidx) {return 0 ; } -static inline int ssb_sdio_hardware_setup (struct ssb_bus *bus) -{ -return 0 ; -}static inline void ssb_sdio_exit (struct ssb_bus *bus) { }
Signature · 1 line
1.8.4.5
Re: [PATCH 3/3] ssb: drop declaration of non existing ssb_sdio_hardware_setup
Quoted 18 lines · On Mon, 21 Sep 2015 09:47:20 +0200 Rafał Miłecki <[email protected]> wrote:
Signed-off-by Rafał Miłecki <[email protected]>--- drivers/ssb/ssb_private.h | 5 ----- 1 file changed, 5 deletions(-)drivers/ssb/ssb_private.h +0
-1@@ -133,7 +133,6 @@ extern int ssb_sdio_get_invariants(struct ssb_bus *bus,extern u32 ssb_sdio_scan_read32 (struct ssb_bus *bus,u16 offset);extern int ssb_sdio_scan_switch_coreidx (struct ssb_bus *bus,u8 coreidx); -extern int ssb_sdio_hardware_setup (struct ssb_bus *bus);extern void ssb_sdio_exit (struct ssb_bus *bus);extern int ssb_sdio_init (struct ssb_bus *bus);
drivers/ssb/ssb_private.h static inline int ssb_sdio_scan_switch_coreidx(struct ssb_bus *bus, u8 coreidx) · line 151
Quoted 10 lines
drivers/ssb/ssb_private.h +0
-4@@ -147,10 +146,6 @@ static inline int ssb_sdio_scan_switch_coreidx(struct ssb_bus *bus, u8 coreidx) {return 0 ; } -static inline int ssb_sdio_hardware_setup (struct ssb_bus *bus) -{ -return 0 ; -}static inline void ssb_sdio_exit (struct ssb_bus *bus) { }
Signature · 1 line
Michael
Quoted 13 lines · On Mon, 21 Sep 2015 09:47:18 +0200 Rafał Miłecki <[email protected]> wrote:
It isn't used anywhere out of ssb code and we don't (plan to) build
pcihost_wrapper.cas a separated module.Signed-off-by Rafał Miłecki <[email protected]>--- drivers/ssb/main.c | 1 - 1 file changed, 1 deletion(-)drivers/ssb/main.c +0
-0
drivers/ssb/main.c int ssb_bus_pcibus_register(struct ssb_bus *bus, struct pci_dev *host_pci) · line 881
Quoted 7 lines
drivers/ssb/main.c +0
-1@@ -876,7 +876,6 @@ int ssb_bus_pcibus_register(struct ssb_bus *bus, struct pci_dev *host_pci) return err; } -EXPORT_SYMBOL (ssb_bus_pcibus_register);#endif /* CONFIG_SSB_PCIHOST */ #ifdef CONFIG_SSB_PCMCIAHOST
Signature · 1 line
Michael
Quoted 4 lines · Rafał Miłecki
It isn't used anywhere out of ssb code and we don't (plan to) build
pcihost_wrapper.cas a separated module.Signed-off-by Rafał Miłecki <[email protected]>
Thanks, all three patches manually applied.
Signature · 1 line
Kalle Valo