btrfs: change num_items type from u64 to unsigned int
PATCH v2 1/2 btrfs: change num_items type from u64 to unsigned int
The value of num_items that start_transaction() ultimately always takes is a small one, so a 64 bit integer is overkill.
Also change num_items for btrfs_start_transaction() and btrfs_start_transaction_lflush() as well.
Signed-off-by Alexandru Moise <[email protected]>
---
v2: followed dave's suggestion of all num_items equivalents to be unsigned ints.
fs/btrfs/transaction.c | 9 +++++---- fs/btrfs/transaction.h | 5 +++-- 2 files changed, 8 insertions(+), 6 deletions(-)
fs/btrfs/transaction.c +5 -4
@@ -415,8 +415,8 @@ static inline bool need_reserve_reloc_root(struct btrfs_root *root) }static struct btrfs_trans_handle * -start_transaction (struct btrfs_root *root,u64 num_items,unsigned int type, -enum btrfs_reserve_flush_enum flush) +start_transaction (struct btrfs_root *root,unsigned int num_items, +unsigned int type,enum btrfs_reserve_flush_enum flush) {struct btrfs_trans_handle *h;struct btrfs_transaction *cur_trans;
@@ -570,14 +570,15 @@ reserve_fail: }struct btrfs_trans_handle *btrfs_start_transaction (struct btrfs_root *root, -int num_items) +unsigned int num_items) {return start_transaction (root, num_items,TRANS_START ,BTRFS_RESERVE_FLUSH_ALL ); }struct btrfs_trans_handle *btrfs_start_transaction_lflush ( -struct btrfs_root *root,int num_items) +struct btrfs_root *root, +unsigned int num_items) {return start_transaction (root, num_items,TRANS_START ,BTRFS_RESERVE_FLUSH_LIMIT );
fs/btrfs/transaction.h +3 -2
@@ -182,9 +182,10 @@ static inline void btrfs_clear_skip_qgroup(struct btrfs_trans_handle *trans)int btrfs_end_transaction (struct btrfs_trans_handle *trans,struct btrfs_root *root);struct btrfs_trans_handle *btrfs_start_transaction (struct btrfs_root *root, -int num_items); +unsigned int num_items);struct btrfs_trans_handle *btrfs_start_transaction_lflush ( -struct btrfs_root *root,int num_items); +struct btrfs_root *root, +unsigned int num_items);struct btrfs_trans_handle *btrfs_join_transaction (struct btrfs_root *root);struct btrfs_trans_handle *btrfs_join_transaction_nolock (struct btrfs_root *root);struct btrfs_trans_handle *btrfs_attach_transaction (struct btrfs_root *root);
Signature · 1 line
2.5.3
Quoted 7 lines · Alexandru Moise
The value of
num_itemsthatstart_transaction()ultimately always takes is a small one, so a 64 bit integer is overkill.Also change
num_itemsforbtrfs_start_transaction()andbtrfs_start_transaction_lflush()as well.Signed-off-by Alexandru Moise <[email protected]>
Reviewed-by David Sterba <[email protected]>