Skip to contentSkip to conversation

arm64: dts: Add base stratix 10 dtsi

PATCH RESEND Superseded dinguyen at opensource.altera.com 3 participants 5 messages Sep 15, 2015 – Sep 23, 2015

Subsystems (4)

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH RESEND v3 1/1 arm64: dts: Add base stratix 10 dtsi

From: Dinh Nguyen <[email protected]>

Add the base DTS for Altera's SoCFPGA Stratix 10 platform.

---
v3: change #address-cells and #size-cells to <2>

    change the GIC address to 0xfffc1000
    update the GIC virtual CPU reg length to 0x2000
v2: use interrupt-affinity for pmu node
---
 arch/arm64/Kconfig.platforms                       |   5 +
 arch/arm64/boot/dts/Makefile                       |   1 +
 arch/arm64/boot/dts/altera/Makefile                |   5 +
 arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi  | 357 +++++++++++++++++++++
 .../boot/dts/altera/socfpga_stratix10_socdk.dts    |  39 +++
 arch/arm64/configs/defconfig                       |   1 +
 6 files changed, 408 insertions(+)
 create mode 100644 arch/arm64/boot/dts/altera/Makefile
 create mode 100644 arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
 create mode 100644 arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
arch/arm64/Kconfig.platforms +5 -0
index 23800a1..36303c8 100644
@@ -66,6 +66,11 @@ config ARCH_SEATTLE
 	help
 	  This enables support for AMD Seattle SOC Family
 
+config ARCH_STRATIX10
+	bool "Altera's Stratix 10 SoCFPGA Family"
+	help
+	  This enables support for Altera's Stratix 10 SoCFPGA Family.
+
 config ARCH_TEGRA
 	bool "NVIDIA Tegra SoC Family"
 	select ARCH_HAS_RESET_CONTROLLER
arch/arm64/boot/dts/Makefile +1 -0
index d9f8833..f585606 100644
@@ -1,3 +1,4 @@
+dts-dirs += altera
 dts-dirs += amd
 dts-dirs += apm
 dts-dirs += arm
arch/arm64/boot/dts/altera/Makefile new file +5 -0
new file mode 100644
index 0000000..d7a6416
@@ -0,0 +1,5 @@
+dtb-$(CONFIG_ARCH_STRATIX10) += socfpga_stratix10_socdk.dtb
+
+always		:= $(dtb-y)
+subdir-y	:= $(dts-dirs)
+clean-files	:= *.dtb
arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi new file +357 -0

357 lines not on this page · raw message

arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts new file +39 -0
new file mode 100644
index 0000000..41ea2db
@@ -0,0 +1,39 @@
+/*
+ * Copyright Altera Corporation (C) 2015. All rights reserved.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms and conditions of the GNU General Public License,
+ * version 2, as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+/include/ "socfpga_stratix10.dtsi"
+
+/ {
+	model = "SoCFPGA Stratix 10 SoCDK";
+
+	aliases {
+		serial0 = &uart0;
+	};
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
+	memory {
+		device_type = "memory";
+		/* We expect the bootloader to fill in the reg */
+		reg = <0 0 0 0>;
+	};
+};
+
+&uart0 {
+	status = "okay";
+};
arch/arm64/configs/defconfig +1 -0
index 34d71dd..7f78e18 100644
@@ -39,6 +39,7 @@ CONFIG_ARCH_HISI=y
 CONFIG_ARCH_MEDIATEK=y
 CONFIG_ARCH_ROCKCHIP=y
 CONFIG_ARCH_SEATTLE=y
+CONFIG_ARCH_STRATIX10=y
 CONFIG_ARCH_TEGRA=y
 CONFIG_ARCH_TEGRA_132_SOC=y
 CONFIG_ARCH_QCOM=y
Signature · 1 line
2.4.5
reviewer
#1 lore raw

PATCH RESEND v3 1/1 arm64: dts: Add base stratix 10 dtsi

Quoted 4 lines
arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi new file +4 -0
+/ {
+	compatible = "altr,socfpga-stratix10";
+	#address-cells = <2>;
+	#size-cells = <2>;

[...]

arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi line 89

Quoted 6 lines
arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi new file +6 -0
+	soc {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		compatible = "simple-bus";
+		device_type = "soc";
+		interrupt-parent = <&intc>;

As far as I am aware, this requires a (non-empty) ranges property, given the parent node has {address,size}-cells = <2>.

Does the kernel not complain currently?

Otherwise this looks OK to me. Please fix the rangers property and ask for this to be taken via arm-soc. I note neither Arnd nor Olof are on Cc currently.

Thanks,
Mark.

#2 lore raw

PATCH RESEND v3 1/1 arm64: dts: Add base stratix 10 dtsi

Quoted 14 lines · Mark Rutland
Quoted 4 lines
arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi new file +4 -0
+/ {
+     compatible = "altr,socfpga-stratix10";
+     #address-cells = <2>;
+     #size-cells = <2>;

[...]

arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi line 89

Quoted 6 lines
arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi new file +6 -0
+     soc {
+             #address-cells = <1>;
+             #size-cells = <1>;
+             compatible = "simple-bus";
+             device_type = "soc";
+             interrupt-parent = <&intc>;
Quoted 5 lines

As far as I am aware, this requires a (non-empty) ranges property, given the parent node has {address,size}-cells = <2>.

Does the kernel not complain currently?

I do not see any complaints without ranges here, but with ranges, I get:

DTC arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dtb
Warning (ranges_format): /soc has empty "ranges" property but its #address-cells (1) differs from / (2)
Warning (ranges_format): /soc has empty "ranges" property but its #size-cells (1) differs from / (2)

Dinh

reviewer
#3 lore raw

PATCH RESEND v3 1/1 arm64: dts: Add base stratix 10 dtsi

Quoted 15 lines · Dinh Nguyen
Quoted 14 lines · Mark Rutland
Quoted 4 lines
arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi new file +4 -0
+/ {
+     compatible = "altr,socfpga-stratix10";
+     #address-cells = <2>;
+     #size-cells = <2>;

[...]

Quoted 6 lines
arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi new file +6 -0
+     soc {
+             #address-cells = <1>;
+             #size-cells = <1>;
+             compatible = "simple-bus";
+             device_type = "soc";
+             interrupt-parent = <&intc>;
Quoted 7 lines
Quoted 5 lines

As far as I am aware, this requires a (non-empty) ranges property, given the parent node has {address,size}-cells = <2>.

Does the kernel not complain currently?

I do not see any complaints without ranges here, but with ranges, I get:

I'm surprised (and a little worried) that we don't warn in the absence of ranges when #{address,size}-cells changes. That doesn't feel right.

Quoted 5 lines

DTC arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dtb
Warning (ranges_format): /soc has empty "ranges" property but its #address-cells (1) differs from / (2)
Warning (ranges_format): /soc has empty "ranges" property but its #size-cells (1) differs from / (2)

As I mentioned, the ranges proeprty should be non-empty.

Thanks,
Mark.

#4 lore raw

PATCH RESEND v3 1/1 arm64: dts: Add base stratix 10 dtsi

In reply to dinguyen at opensource.altera.com
Quoted 7 lines · On Tue, Sep 15, 2015 at 4:47 PM, <[email protected]> wrote:

From: Dinh Nguyen <[email protected]>

Add the base DTS for Altera's SoCFPGA Stratix 10 platform.

---
v3: change #address-cells and #size-cells to <2>

Quoted 15 lines
    change the GIC address to 0xfffc1000
    update the GIC virtual CPU reg length to 0x2000
v2: use interrupt-affinity for pmu node
---
 arch/arm64/Kconfig.platforms                       |   5 +
 arch/arm64/boot/dts/Makefile                       |   1 +
 arch/arm64/boot/dts/altera/Makefile                |   5 +
 arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi  | 357 +++++++++++++++++++++
 .../boot/dts/altera/socfpga_stratix10_socdk.dts    |  39 +++
 arch/arm64/configs/defconfig                       |   1 +
 6 files changed, 408 insertions(+)
 create mode 100644 arch/arm64/boot/dts/altera/Makefile
 create mode 100644 arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
 create mode 100644 arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts

Gentle ping?

Thanks,
Dinh