Skip to contentSkip to conversation

compaction.h: undefined CONFIG_ZONE_HIGHMEM_

PATCH Valentin Rothberg 2 participants 3 messages Sep 23, 2015 Tracing

lore
Share & tools
lore
#0 lore raw

Hi Vlastimil,

your commit 1434c81a47e3 ("mm, compaction: export tracepoints zone names to userspace") has shown up in todays linux-next tree (i.e., 20150923) adding the following lines of code:

include/trace/events/compaction.h +0 -0
@@ -18,6 +18,31 @@

[...]
+#ifdef CONFIG_ZONE_HIGHMEM_
+#define IFDEF_ZONE_HIGHMEM(X) X
+#else
+#define IFDEF_ZONE_HIGHMEM(X)
+#endif

At the current state, the #ifdef block will not see a compiler since CONFIG_ZONE_HIGHMEM_ is not defined anywhere. At first I thought it's a typo as it ends with '_', but even ZONE_HIGHMEM isn't defined in Kconfig. Is there a patch queued somewhere to fix the issue?

I detected the issue with undertaker-checkpatch from [1]. We run a bot daily on linux-next to detect some Kconfig related issues and bugs.

Kind regards,
Valentin

[1] https://undertaker.cs.fau.de

#1 lore raw
Quoted 16 lines · Valentin Rothberg

Hi Vlastimil,

your commit 1434c81a47e3 ("mm, compaction: export tracepoints zone names to userspace") has shown up in todays linux-next tree (i.e., 20150923) adding the following lines of code:

include/trace/events/compaction.h +5 -0
@@ -18,6 +18,31 @@
[...]
+#ifdef CONFIG_ZONE_HIGHMEM_
+#define IFDEF_ZONE_HIGHMEM(X) X
+#else
+#define IFDEF_ZONE_HIGHMEM(X)
+#endif
Quoted 2 lines

At the current state, the #ifdef block will not see a compiler since CONFIG_ZONE_HIGHMEM_ is not defined anywhere.

Ah damn, that's why a simple compile test won't catch this typo.

Quoted 3 lines

At first I thought it's a
typo as it ends with '_', but even ZONE_HIGHMEM isn't defined in Kconfig. Is there a patch queued somewhere to fix the issue?

It's actually just CONFIG_HIGHMEM (who needs consistency anyway?). Patch below. I didn't rename the IFDEF_ZONE_HIGHMEM as it's internal.

When looking at zone_names I've noticed a CONFIG_ZONE_DEVICE. I assume compaction can't be run on this one so I'll ignore it. At worst the tracepoint string would be missing.

Quoted 3 lines

I detected the issue with undertaker-checkpatch from [1]. We run a bot daily on linux-next to detect some Kconfig related issues and bugs.

Yeah I've heard about it on last year's Plumbers. Thanks for catching this!

Quoted 3 lines

Kind regards, Valentin

[1] https://undertaker.cs.fau.de

------8<------
From: Vlastimil Babka <[email protected]>
Date: Wed, 23 Sep 2015 11:31:10 +0200
Subject: [PATCH] mm, compaction: export tracepoints zone names to
userspace-fix

Through undertaker-checkpatch it was reported that HighMem would be missing in the tracepoint output due to checking CONFIG_ZONE_HIGHMEM_ instead of CONFIG_HIGHMEM. Fix it.

---
 include/trace/events/compaction.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/trace/events/compaction.h +1 -1
index 5604994..c92d1e1 100644
@@ -31,7 +31,7 @@
 #define IFDEF_ZONE_DMA32(X)
 #endif
 
-#ifdef CONFIG_ZONE_HIGHMEM_
+#ifdef CONFIG_HIGHMEM
 #define IFDEF_ZONE_HIGHMEM(X) X
 #else
 #define IFDEF_ZONE_HIGHMEM(X)
Signature · 1 line
2.5.1
#2 lore raw
Quoted 33 lines · Vlastimil Babka
Quoted 16 lines · Valentin Rothberg

Hi Vlastimil,

your commit 1434c81a47e3 ("mm, compaction: export tracepoints zone names to userspace") has shown up in todays linux-next tree (i.e., 20150923) adding the following lines of code:

include/trace/events/compaction.h +5 -0
@@ -18,6 +18,31 @@
[...]
+#ifdef CONFIG_ZONE_HIGHMEM_
+#define IFDEF_ZONE_HIGHMEM(X) X
+#else
+#define IFDEF_ZONE_HIGHMEM(X)
+#endif
Quoted 2 lines

At the current state, the #ifdef block will not see a compiler since CONFIG_ZONE_HIGHMEM_ is not defined anywhere.

Ah damn, that's why a simple compile test won't catch this typo.

Quoted 3 lines

At first I thought it's a
typo as it ends with '_', but even ZONE_HIGHMEM isn't defined in Kconfig. Is there a patch queued somewhere to fix the issue?

It's actually just CONFIG_HIGHMEM (who needs consistency anyway?). Patch below. I didn't rename the IFDEF_ZONE_HIGHMEM as it's internal.

When looking at zone_names I've noticed a CONFIG_ZONE_DEVICE. I assume compaction can't be run on this one so I'll ignore it. At worst the tracepoint string would be missing.

Quoted 5 lines
Quoted 3 lines

I detected the issue with undertaker-checkpatch from [1]. We run a bot daily on linux-next to detect some Kconfig related issues and bugs.

Yeah I've heard about it on last year's Plumbers. Thanks for catching this!

Cool, happy to hear when people know our tools!

We put parts of the symbolic analysis such as the "CONFIG_ZONE_HIGHMEM_" case into scripts/checkkconfigsymbols.py. It's quite funny that checkkconfigsymbols did not catch your commit since it requires Kconfig symbols to end with something alphanumerical, if not they will be ignored - an everlasting fight with false postives and false negatives :)

Thanks,
Valentin