Add RPM/SMD Support for QCOM platforms
Subsystems (4)
v2 cover Add RPM/SMD Support for QCOM platforms
This patch set cleans up the documentation that is currently in place for the SMD, SMD-RPM, and SMD-RPM regulators. In addition, this patch set adds support for the PM8916 found on MSM8916 platforms and the PMA8084 found on APQ8084 platforms.
All of the relevant DTS information is fleshed out for the regulators and their dependencies for all of the platforms which support SMD-RPM regulators.
Changes since v1:
- Fixed various review comments
- Removed MSM8974 patches as there was already an outstanding patch
Andy Gross (10):
soc: qcom: documentation: Update SMD/RPM Docs
soc: qcom: smd-rpm: Add existing platform support
arm64: dts: qcom: Add MSM8916 SMEM nodes
arm64: dts: qcom: Add RPM/SMD support on MSM8916
arm64: dts: Add PM8916 support on MSM8916
regulators: qcom-smd: Add PM8916 support
arm: dts: Add APQ8084 SMEM nodes
arm: dts: Add RPM/SMD support on APQ8084
arm: dts: Add support for PMA8084 on APQ8084
regulator: qcom-smd: Add support for PMA8084
.../devicetree/bindings/soc/qcom,smd-rpm.txt | 117 -------------- .../bindings/soc/qcom/qcom,smd-rpm-regulator.txt | 156 +++++++++++++++++++ .../devicetree/bindings/soc/qcom/qcom,smd-rpm.txt | 57 +++++++ arch/arm/boot/dts/qcom-apq8084.dtsi | 103 +++++++++++++ arch/arm64/boot/dts/qcom/msm8916.dtsi | 84 +++++++++++ drivers/regulator/qcom_smd-regulator.c | 159 ++++++++++++++++++++ drivers/soc/qcom/smd-rpm.c | 2 + 7 files changed, 561 insertions(+), 117 deletions(-) delete mode 100644 Documentation/devicetree/bindings/soc/qcom,smd-rpm.txt create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm-regulator.txt create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.txt
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
PATCH v2 1/10 soc: qcom: documentation: Update SMD/RPM Docs
This patch moves the qcom,smd-rpm.txt to the correct location and splits out the smd and rpm documentation. In addition, a smd-rpm-regulator document is added.
--- .../devicetree/bindings/soc/qcom,smd-rpm.txt | 117 -------------------- .../bindings/soc/qcom/qcom,smd-rpm-regulator.txt | 103 +++++++++++++++++ .../devicetree/bindings/soc/qcom/qcom,smd-rpm.txt | 55 +++++++++ 3 files changed, 158 insertions(+), 117 deletions(-) delete mode 100644 Documentation/devicetree/bindings/soc/qcom,smd-rpm.txt create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm-regulator.txt create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.txt
Documentation/devicetree/bindings/soc/qcom,smd-rpm.txt deleted +0 -117
@@ -1,117 +0,0 @@ -Qualcomm Resource Power Manager (RPM) over SMD - -This driver is used to interface with the Resource Power Manager (RPM) found in -various Qualcomm platforms. The RPM allows each component in the system to vote -for state of the system resources, such as clocks, regulators and bus -frequencies. - -- compatible: - Usage: required - Value type: <string> - Definition: must be one of: - "qcom,rpm-msm8974" - -- qcom,smd-channels: - Usage: required - Value type: <stringlist> - Definition: Shared Memory channel used for communication with the RPM - -= SUBDEVICES - -The RPM exposes resources to its subnodes. The below bindings specify the set -of valid subnodes that can operate on these resources. - -== Regulators - -Regulator nodes are identified by their compatible: - -- compatible: - Usage: required - Value type: <string> - Definition: must be one of: - "qcom,rpm-pm8841-regulators" - "qcom,rpm-pm8941-regulators" - -- vdd_s1-supply: -- vdd_s2-supply: -- vdd_s3-supply: -- vdd_s4-supply: -- vdd_s5-supply: -- vdd_s6-supply: -- vdd_s7-supply: -- vdd_s8-supply: - Usage: optional (pm8841 only) - Value type: <phandle> - Definition: reference to regulator supplying the input pin, as - described in the data sheet - -- vdd_s1-supply: -- vdd_s2-supply: -- vdd_s3-supply: -- vdd_l1_l3-supply: -- vdd_l2_lvs1_2_3-supply: -- vdd_l4_l11-supply: -- vdd_l5_l7-supply: -- vdd_l6_l12_l14_l15-supply: -- vdd_l8_l16_l18_l19-supply: -- vdd_l9_l10_l17_l22-supply: -- vdd_l13_l20_l23_l24-supply: -- vdd_l21-supply: -- vin_5vs-supply: - Usage: optional (pm8941 only) - Value type: <phandle> - Definition: reference to regulator supplying the input pin, as - described in the data sheet - -The regulator node houses sub-nodes for each regulator within the device. Each -sub-node is identified using the node's name, with valid values listed for each -of the pmics below. - -pm8841: - s1, s2, s3, s4, s5, s6, s7, s8 - -pm8941: - s1, s2, s3, s4, l1, l2, l3, l4, l5, l6, l7, l8, l9, l10, l11, l12, l13, - l14, l15, l16, l17, l18, l19, l20, l21, l22, l23, l24, lvs1, lvs2, - lvs3, 5vs1, 5vs2 - -The content of each sub-node is defined by the standard binding for regulators - -see regulator.txt. - -= EXAMPLE - - smd { - compatible = "qcom,smd"; - - rpm { - interrupts = <0 168 1>; - qcom,ipc = <&apcs 8 0>; - qcom,smd-edge = <15>; - - rpm_requests { - compatible = "qcom,rpm-msm8974"; - qcom,smd-channels = "rpm_requests"; - - pm8941-regulators { - compatible = "qcom,rpm-pm8941-regulators"; - vdd_l13_l20_l23_l24-supply = <&pm8941_boost>; - - pm8941_s3: s3 { - regulator-min-microvolt = <1800000>; - regulator-max-microvolt = <1800000>; - }; - - pm8941_boost: s4 { - regulator-min-microvolt = <5000000>; - regulator-max-microvolt = <5000000>; - }; - - pm8941_l20: l20 { - regulator-min-microvolt = <2950000>; - regulator-max-microvolt = <2950000>; - }; - }; - }; - }; - }; -
Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm-regulator.txt new file +103 -0
103 lines not on this page · raw message
Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.txt new file +55 -0
55 lines not on this page · raw message
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
PATCH v2 2/10 soc: qcom: smd-rpm: Add existing platform support
In reply to Andy GrossThis patch adds support for all current Qualcomm platforms which utilize RPM over SMD. This includes both MSM8916 and APQ8084.
--- .../devicetree/bindings/soc/qcom/qcom,smd-rpm.txt | 2 ++ drivers/soc/qcom/smd-rpm.c | 2 ++ 2 files changed, 4 insertions(+)
Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.txt +2 -0
@@ -20,6 +20,8 @@ resources. Value type: <string> Definition: must be one of: "qcom,rpm-msm8974" + "qcom,rpm-msm8916" + "qcom,rpm-apq8084" - qcom,smd-channels: Usage: required
drivers/soc/qcom/smd-rpm.c +2 -0
@@ -212,6 +212,8 @@ static void qcom_smd_rpm_remove(struct qcom_smd_device *sdev)static const struct of_device_id qcom_smd_rpm_of_match[] = { { .compatible ="qcom,rpm-msm8974" }, + { .compatible ="qcom,rpm-msm8916" }, + { .compatible ="qcom,rpm-apq8084" }, {} };MODULE_DEVICE_TABLE (of, qcom_smd_rpm_of_match);
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
Re: [Patch v2 02/10] soc: qcom: smd-rpm: Add existing platform support
Quoted 27 lines · Andy Gross
This patch adds support for all current Qualcomm platforms which utilize RPM over SMD. This includes both MSM8916 and APQ8084.
Signed-off-by Andy Gross <[email protected]>--- .../devicetree/bindings/soc/qcom/qcom,smd-rpm.txt | 2 ++ drivers/soc/qcom/smd-rpm.c | 2 ++ 2 files changed, 4 insertions(+)Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.txt +2
-0@@ -20,6 +20,8 @@ resources. Value type: <string> Definition: must be one of: "qcom,rpm-msm8974" + "qcom,rpm-msm8916" + "qcom,rpm-apq8084" - qcom,smd-channels: Usage: requireddrivers/soc/qcom/smd-rpm.c +0
-0
drivers/soc/qcom/smd-rpm.c static void qcom_smd_rpm_remove(struct qcom_smd_device *sdev) · line 217
Quoted 6 lines
drivers/soc/qcom/smd-rpm.c +2
-0@@ -212,6 +212,8 @@ static void qcom_smd_rpm_remove(struct qcom_smd_device *sdev)static const struct of_device_id qcom_smd_rpm_of_match[] = { { .compatible ="qcom,rpm-msm8974" }, + { .compatible ="qcom,rpm-msm8916" }, + { .compatible ="qcom,rpm-apq8084" }, {}
This is now how the alphabet works, please update the order and add:
Regards,
Bjorn
Re: [Patch v2 02/10] soc: qcom: smd-rpm: Add existing platform support
Quoted 38 lines · Bjorn Andersson
Quoted 27 lines · Andy Gross
This patch adds support for all current Qualcomm platforms which utilize RPM over SMD. This includes both MSM8916 and APQ8084.
Signed-off-by Andy Gross <[email protected]>--- .../devicetree/bindings/soc/qcom/qcom,smd-rpm.txt | 2 ++ drivers/soc/qcom/smd-rpm.c | 2 ++ 2 files changed, 4 insertions(+)Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.txt +2
-0@@ -20,6 +20,8 @@ resources. Value type: <string> Definition: must be one of: "qcom,rpm-msm8974" + "qcom,rpm-msm8916" + "qcom,rpm-apq8084" - qcom,smd-channels: Usage: requireddrivers/soc/qcom/smd-rpm.c +0
-0drivers/soc/qcom/smd-rpm.c static void qcom_smd_rpm_remove(struct qcom_smd_device *sdev) · line 217
Quoted 6 lines
drivers/soc/qcom/smd-rpm.c +2
-0@@ -212,6 +212,8 @@ static void qcom_smd_rpm_remove(struct qcom_smd_device *sdev)static const struct of_device_id qcom_smd_rpm_of_match[] = { { .compatible ="qcom,rpm-msm8974" }, + { .compatible ="qcom,rpm-msm8916" }, + { .compatible ="qcom,rpm-apq8084" }, {}This is now how the alphabet works, please update the order and add:
Quoted 4 lines
Reviewed-by Bjorn Andersson <[email protected]>Regards,
Bjorn
I'll fixup before applying. Thanks!
Signature · 3 lines
Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
PATCH v2 3/10 arm64: dts: qcom: Add MSM8916 SMEM nodes
In reply to Andy GrossThis patch adds the nodes necessary to support the SMEM driver on MSM8916 platforms.
--- arch/arm64/boot/dts/qcom/msm8916.dtsi | 36 +++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+)
arch/arm64/boot/dts/qcom/msm8916.dtsi +36 -0
@@ -37,6 +37,22 @@ reg = <0 0 0 0>; }; + reserved-memory { + #address-cells = <2>; + #size-cells = <2>; + ranges; + + reserve_aligned at 86000000 { + reg = <0x0 0x86000000 0x0 0x0300000>; + no-map; + }; + + smem_mem: smem_region at 86300000 { + reg = <0x0 0x86300000 0x0 0x0100000>; + no-map; + }; + }; + cpus { #address-cells = <1>; #size-cells = <0>;
@@ -102,6 +118,26 @@ reg = <0x1800000 0x80000>; }; + tcsr_mutex_regs: syscon at 1905000 { + compatible = "syscon"; + reg = <0x1905000 0x20000>; + }; + + tcsr_mutex: hwlock { + compatible = "qcom,tcsr-mutex"; + syscon = <&tcsr_mutex_regs 0 0x1000>; + #hwlock-cells = <1>; + }; + + smem { + compatible = "qcom,smem"; + reg = <0x60000 0x8000>; + reg-names = "aux-mem1"; + + memory-region = <&smem_mem>; + hwlocks = <&tcsr_mutex 3>; + }; + blsp1_uart2: serial at 78b0000 { compatible = "qcom,msm-uartdm-v1.4", "qcom,msm-uartdm"; reg = <0x78b0000 0x200>;
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
PATCH v2 4/10 arm64: dts: qcom: Add RPM/SMD support on MSM8916
In reply to Andy GrossAdd support for the SMD and RPM devices found on MSM8916 platforms.
--- arch/arm64/boot/dts/qcom/msm8916.dtsi | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)
arch/arm64/boot/dts/qcom/msm8916.dtsi +20 -0
@@ -138,6 +138,11 @@ hwlocks = <&tcsr_mutex 3>; }; + apcs: syscon at b011000 { + compatible = "syscon"; + reg = <0x0b011000 0x1000>; + }; + blsp1_uart2: serial at 78b0000 { compatible = "qcom,msm-uartdm-v1.4", "qcom,msm-uartdm"; reg = <0x78b0000 0x200>;
@@ -427,6 +432,21 @@ #interrupt-cells = <4>; }; }; + + smd { + compatible = "qcom,smd"; + + rpm { + interrupts = <GIC_SPI 168 IRQ_TYPE_EDGE_RISING>; + qcom,ipc = <&apcs 8 0>; + qcom,smd-edge = <15>; + + rpm_requests { + compatible = "qcom,rpm-msm8916"; + qcom,smd-channels = "rpm_requests"; + }; + }; + }; }; #include "msm8916-pins.dtsi"
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
PATCH v2 5/10 arm64: dts: Add PM8916 support on MSM8916
In reply to Andy GrossThis patch adds the PM8916 regulator nodes found on MSM8916 platforms.
--- arch/arm64/boot/dts/qcom/msm8916.dtsi | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+)
arch/arm64/boot/dts/qcom/msm8916.dtsi +28 -0
@@ -444,6 +444,34 @@ rpm_requests { compatible = "qcom,rpm-msm8916"; qcom,smd-channels = "rpm_requests"; + + pm8916-regulators { + compatible = "qcom,rpm-pm8916-regulators"; + + pm8916_s1: s1 {}; + pm8916_s2: s2 {}; + pm8916_s3: s3 {}; + pm8916_s4: s4 {}; + + pm8916_l1: l1 {}; + pm8916_l2: l2 {}; + pm8916_l3: l3 {}; + pm8916_l4: l4 {}; + pm8916_l5: l5 {}; + pm8916_l6: l6 {}; + pm8916_l7: l7 {}; + pm8916_l8: l8 {}; + pm8916_l9: l9 {}; + pm8916_l10: l10 {}; + pm8916_l11: l11 {}; + pm8916_l12: l12 {}; + pm8916_l13: l13 {}; + pm8916_l14: l14 {}; + pm8916_l15: l15 {}; + pm8916_l16: l16 {}; + pm8916_l17: l17 {}; + pm8916_l18: l18 {}; + }; }; }; };
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
PATCH v2 6/10 regulators: qcom-smd: Add PM8916 support
In reply to Andy GrossThis patch adds support and documentation for the PM8916 regulators found on MSM8916 platforms.
--- .../bindings/soc/qcom/qcom,smd-rpm-regulator.txt | 18 ++++++ drivers/regulator/qcom_smd-regulator.c | 64 ++++++++++++++++++++ 2 files changed, 82 insertions(+)
Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm-regulator.txt +18 -0
@@ -18,6 +18,7 @@ Regulator nodes are identified by their compatible: Definition: must be one of: "qcom,rpm-pm8841-regulators" "qcom,rpm-pm8941-regulators" + "qcom,rpm-pm8916-regulators" - vdd_s1-supply: - vdd_s2-supply:
@@ -50,6 +51,19 @@ Regulator nodes are identified by their compatible: Definition: reference to regulator supplying the input pin, as described in the data sheet +- vdd_s1-supply: +- vdd_s2-supply: +- vdd_s3-supply: +- vdd_s4-supply: +- vdd_l1_l2_l3-supply +- vdd_l4_l5_l6-supply +- vdd_l7-supply +- vdd_l8_l9_l10_l11_l12_l13_l14_l15_l16_l17_l18-supply: + Usage: optional (pm8916 only) + Value type: <phandle> + Definition: reference to regulator supplying the input pin, as + described in the data sheet + The regulator node houses sub-nodes for each regulator within the device. Each sub-node is identified using the node's name, with valid values listed for each of the pmics below.
@@ -62,6 +76,10 @@ pm8941: l14, l15, l16, l17, l18, l19, l20, l21, l22, l23, l24, lvs1, lvs2, lvs3, 5vs1, 5vs2 +pm8916: + s1, s2, s3, s4, l1, l2, l3, l4, l5, l6, l7, l8, l9, l10, l11, l12, l13, + l14, l15, l16, l17, l18 + The content of each sub-node is defined by the standard binding for regulators - see regulator.txt.
drivers/regulator/qcom_smd-regulator.c +64 -0
82 lines not on this page · raw message
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
Re: [Patch v2 06/10] regulators: qcom-smd: Add PM8916 support
Quoted 14 lines · Andy Gross
This patch adds support and documentation for the PM8916 regulators found on MSM8916 platforms.
Signed-off-by Andy Gross <[email protected]>--- .../bindings/soc/qcom/qcom,smd-rpm-regulator.txt | 18 ++++++ drivers/regulator/qcom_smd-regulator.c | 64 ++++++++++++++++++++ 2 files changed, 82 insertions(+)Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm-regulator.txt +0
-0
Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm-regulator.txt Regulator nodes are identified by their compatible: · line 21
Quoted 4 lines
Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm-regulator.txt +1
-0@@ -18,6 +18,7 @@ Regulator nodes are identified by their compatible: Definition: must be one of: "qcom,rpm-pm8841-regulators" "qcom,rpm-pm8941-regulators" + "qcom,rpm-pm8916-regulators"
Alphabetical please
Quoted 4 lines
Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm-regulator.txt +0
-0- vdd_s1-supply: - vdd_s2-supply:
Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm-regulator.txt Regulator nodes are identified by their compatible: · line 60
Quoted 10 lines
Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm-regulator.txt +7
-0@@ -50,6 +51,19 @@ Regulator nodes are identified by their compatible: Definition: reference to regulator supplying the input pin, as described in the data sheet +- vdd_s1-supply: +- vdd_s2-supply: +- vdd_s3-supply: +- vdd_s4-supply: +- vdd_l1_l2_l3-supply +- vdd_l4_l5_l6-supply +- vdd_l7-supply
End these with ':' as well
Quoted 6 lines
Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm-regulator.txt +6
-0+- vdd_l8_l9_l10_l11_l12_l13_l14_l15_l16_l17_l18-supply: + Usage: optional (pm8916 only) + Value type: <phandle> + Definition: reference to regulator supplying the input pin, as + described in the data sheet +
[..]
Quoted 1 line
drivers/regulator/qcom_smd-regulator.c +0
-0
[..]
drivers/regulator/qcom_smd-regulator.c static const struct rpm_regulator_data rpm_pm8941_regulators[] = { · line 339
Quoted 2 lines
static const struct
of_device_idrpm_of_match[] = {drivers/regulator/qcom_smd-regulator.c +1
-0+ { .compatible = "qcom,rpm-pm8916-regulators", .data = &rpm_pm8916_regulators },
pm8916 > pm8841
drivers/regulator/qcom_smd-regulator.c static const struct rpm_regulator_data rpm_pm8941_regulators[] = { · line 342
Quoted 3 lines
drivers/regulator/qcom_smd-regulator.c +0
-0{ .compatible = "qcom,rpm-pm8841-regulators", .data = &rpm_pm8841_regulators }, { .compatible = "qcom,rpm-pm8941-regulators", .data = &rpm_pm8941_regulators }, {}
With these nits:
Regards,
Bjorn
Re: [Patch v2 06/10] regulators: qcom-smd: Add PM8916 support
Quoted 58 lines · Bjorn Andersson
Quoted 14 lines · Andy Gross
This patch adds support and documentation for the PM8916 regulators found on MSM8916 platforms.
Signed-off-by Andy Gross <[email protected]>--- .../bindings/soc/qcom/qcom,smd-rpm-regulator.txt | 18 ++++++ drivers/regulator/qcom_smd-regulator.c | 64 ++++++++++++++++++++ 2 files changed, 82 insertions(+)Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm-regulator.txt +0
-0Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm-regulator.txt Regulator nodes are identified by their compatible: · line 21
Quoted 4 lines
Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm-regulator.txt +1
-0@@ -18,6 +18,7 @@ Regulator nodes are identified by their compatible: Definition: must be one of: "qcom,rpm-pm8841-regulators" "qcom,rpm-pm8941-regulators" + "qcom,rpm-pm8916-regulators"Alphabetical please
Quoted 4 lines
Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm-regulator.txt +0
-0- vdd_s1-supply: - vdd_s2-supply:Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm-regulator.txt Regulator nodes are identified by their compatible: · line 60
Quoted 10 lines
Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm-regulator.txt +7
-0@@ -50,6 +51,19 @@ Regulator nodes are identified by their compatible: Definition: reference to regulator supplying the input pin, as described in the data sheet +- vdd_s1-supply: +- vdd_s2-supply: +- vdd_s3-supply: +- vdd_s4-supply: +- vdd_l1_l2_l3-supply +- vdd_l4_l5_l6-supply +- vdd_l7-supplyEnd these with ':' as well
Quoted 6 lines
Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm-regulator.txt +6
-0+- vdd_l8_l9_l10_l11_l12_l13_l14_l15_l16_l17_l18-supply: + Usage: optional (pm8916 only) + Value type: <phandle> + Definition: reference to regulator supplying the input pin, as + described in the data sheet +[..]
Quoted 1 line
drivers/regulator/qcom_smd-regulator.c +0
-0[..]
drivers/regulator/qcom_smd-regulator.c static const struct rpm_regulator_data rpm_pm8941_regulators[] = { · line 339
Quoted 2 lines
static const struct
of_device_idrpm_of_match[] = {drivers/regulator/qcom_smd-regulator.c +1
-0+ { .compatible = "qcom,rpm-pm8916-regulators", .data = &rpm_pm8916_regulators },pm8916 > pm8841
drivers/regulator/qcom_smd-regulator.c static const struct rpm_regulator_data rpm_pm8941_regulators[] = { · line 342
Quoted 3 lines
drivers/regulator/qcom_smd-regulator.c +0
-0{ .compatible = "qcom,rpm-pm8841-regulators", .data = &rpm_pm8841_regulators }, { .compatible = "qcom,rpm-pm8941-regulators", .data = &rpm_pm8941_regulators }, {}
Quoted 6 lines
With these nits:
Acked-by Bjorn Andersson <[email protected]>Regards,
Bjorn
I'll fixup this when I apply it. Thanks!
Signature · 3 lines
Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
PATCH v2 7/10 arm: dts: Add APQ8084 SMEM nodes
In reply to Andy GrossThis patch adds all the required nodes to support SMEM on APQ8084
--- arch/arm/boot/dts/qcom-apq8084.dtsi | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+)
arch/arm/boot/dts/qcom-apq8084.dtsi +31 -0
@@ -10,6 +10,17 @@ compatible = "qcom,apq8084"; interrupt-parent = <&intc>; + reserved-memory { + #address-cells = <1>; + #size-cells = <1>; + ranges; + + smem_mem: smem_region at fa00000 { + reg = <0xfa00000 0x200000>; + no-map; + }; + }; + cpus { #address-cells = <1>; #size-cells = <0>;
@@ -224,6 +235,26 @@ reg = <0xfc400000 0x4000>; }; + tcsr_mutex_regs: syscon at fd484000 { + compatible = "syscon"; + reg = <0xfd484000 0x2000>; + }; + + tcsr_mutex: hwlock { + compatible = "qcom,tcsr-mutex"; + syscon = <&tcsr_mutex_regs 0 0x80>; + #hwlock-cells = <1>; + }; + + smem { + compatible = "qcom,smem"; + reg = <0xfc428000 0x4000>; + reg-names = "aux-mem1"; + + memory-region = <&smem_mem>; + hwlocks = <&tcsr_mutex 3>; + }; + tlmm: pinctrl at fd510000 { compatible = "qcom,apq8084-pinctrl"; reg = <0xfd510000 0x4000>;
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
PATCH v2 8/10 arm: dts: Add RPM/SMD support on APQ8084
In reply to Andy GrossThis patch adds support for RPM and SMD nodes that are present on APQ8084 platforms.
--- arch/arm/boot/dts/qcom-apq8084.dtsi | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)
arch/arm/boot/dts/qcom-apq8084.dtsi +20 -0
@@ -114,6 +114,11 @@ <0xf9002000 0x1000>; }; + apcs: syscon at f9011000 { + compatible = "syscon"; + reg = <0xf9011000 0x1000>; + }; + timer at f9020000 { #address-cells = <1>; #size-cells = <1>;
@@ -312,4 +317,19 @@ #interrupt-cells = <4>; }; }; + + smd { + compatible = "qcom,smd"; + + rpm { + interrupts = <0 168 1>; + qcom,ipc = <&apcs 8 0>; + qcom,smd-edge = <15>; + + rpm_requests { + compatible = "qcom,rpm-apq8084"; + qcom,smd-channels = "rpm_requests"; + }; + }; + }; };
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
PATCH v2 9/10 arm: dts: Add support for PMA8084 on APQ8084
In reply to Andy GrossThis patch adds support for the PMA8084 regulators found on APQ8084 platforms.
--- arch/arm/boot/dts/qcom-apq8084.dtsi | 52 +++++++++++++++++++++++++++++++++++ 1 file changed, 52 insertions(+)
arch/arm/boot/dts/qcom-apq8084.dtsi +52 -0
@@ -329,6 +329,58 @@ rpm_requests { compatible = "qcom,rpm-apq8084"; qcom,smd-channels = "rpm_requests"; + + pma8084-regulators { + compatible = "qcom,rpm-pma8084-regulators"; + + pma8084_s1: s1 {}; + pma8084_s2: s2 {}; + pma8084_s3: s3 {}; + pma8084_s4: s4 {}; + pma8084_s5: s5 {}; + pma8084_s6: s6 {}; + pma8084_s7: s7 {}; + pma8084_s8: s8 {}; + pma8084_s9: s9 {}; + pma8084_s10: s10 {}; + pma8084_s11: s11 {}; + pma8084_s12: s12 {}; + + pma8084_l1: l1 {}; + pma8084_l2: l2 {}; + pma8084_l3: l3 {}; + pma8084_l4: l4 {}; + pma8084_l5: l5 {}; + pma8084_l6: l6 {}; + pma8084_l7: l7 {}; + pma8084_l8: l8 {}; + pma8084_l9: l9 {}; + pma8084_l10: l10 {}; + pma8084_l11: l11 {}; + pma8084_l12: l12 {}; + pma8084_l13: l13 {}; + pma8084_l14: l14 {}; + pma8084_l15: l15 {}; + pma8084_l16: l16 {}; + pma8084_l17: l17 {}; + pma8084_l18: l18 {}; + pma8084_l19: l19 {}; + pma8084_l20: l20 {}; + pma8084_l21: l21 {}; + pma8084_l22: l22 {}; + pma8084_l23: l23 {}; + pma8084_l24: l24 {}; + pma8084_l25: l25 {}; + pma8084_l26: l26 {}; + pma8084_l27: l27 {}; + + pma8084_lvs1: lvs1 {}; + pma8084_lvs2: lvs2 {}; + pma8084_lvs3: lvs3 {}; + pma8084_lvs4: lvs4 {}; + + pma8084_5vs1: 5vs1 {}; + }; }; }; };
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
PATCH v2 10/10 regulator: qcom-smd: Add support for PMA8084
In reply to Andy GrossThis patch adds support and documentation for the PMA8084 regulators found on APQ8084 platforms.
--- .../bindings/soc/qcom/qcom,smd-rpm-regulator.txt | 35 ++++++++ drivers/regulator/qcom_smd-regulator.c | 95 ++++++++++++++++++++ 2 files changed, 130 insertions(+)
Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm-regulator.txt +35 -0
@@ -19,6 +19,7 @@ Regulator nodes are identified by their compatible: "qcom,rpm-pm8841-regulators" "qcom,rpm-pm8941-regulators" "qcom,rpm-pm8916-regulators" + "qcom,rpm-pma8084-regulators" - vdd_s1-supply: - vdd_s2-supply:
@@ -64,6 +65,35 @@ Regulator nodes are identified by their compatible: Definition: reference to regulator supplying the input pin, as described in the data sheet +- vdd_s1-supply: +- vdd_s2-supply: +- vdd_s3-supply: +- vdd_s4-supply: +- vdd_s5-supply: +- vdd_s6-supply: +- vdd_s7-supply: +- vdd_s8-supply: +- vdd_s9-supply: +- vdd_s10-supply: +- vdd_s11-supply: +- vdd_s12-supply: +- vdd_l1_l11-supply: +- vdd_l2_l3_l4_l27-supply: +- vdd_l5_l7-supply: +- vdd_l6_l12_l14_l15_l26-supply: +- vdd_l8-supply: +- vdd_l9_l10_l13_l20_l23_l24-supply: +- vdd_l16_l25-supply: +- vdd_l17-supply: +- vdd_l18-supply: +- vdd_l19-supply: +- vdd_l21-supply: +- vdd_l22-supply: + Usage: optional (pma8084 only) + Value type: <phandle> + Definition: reference to regulator supplying the input pin, as + described in the data sheet + The regulator node houses sub-nodes for each regulator within the device. Each sub-node is identified using the node's name, with valid values listed for each of the pmics below.
@@ -80,6 +110,11 @@ pm8916: s1, s2, s3, s4, l1, l2, l3, l4, l5, l6, l7, l8, l9, l10, l11, l12, l13, l14, l15, l16, l17, l18 +pma8084: + s1, s2, s3, s4, s5, s6, s7, s8, s9, s10, s11, s12, l1, l2, l3, l4, l5, + l6, l7, l8, l9, l10, l11, l12, l13, l14, l15, l16, l17, l18, l19, l20, + l21, l22, l23, l24, l25, l26, l27, lvs1, lvs2, lvs3, lvs4, 5vs1 + The content of each sub-node is defined by the standard binding for regulators - see regulator.txt.
drivers/regulator/qcom_smd-regulator.c +95 -0
111 lines not on this page · raw message
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation