Skip to contentSkip to conversation

libwebsockets: add option to enable/disable ipv6 support

PATCH New Andreas Wetzel 5 participants 14 messages Sep 23, 2015 – Oct 10, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libwebsockets: add option to enable/disable ipv6 support

Added configuration option BR2_PACKAGE_LIBWEBSOCKETS_IPV6 that adds -DLWS_IPV6=ON/OFF to LIBWEBSOCKETS_CONF_OPTS.

---
 package/libwebsockets/Config.in        | 7 +++++++
 package/libwebsockets/libwebsockets.mk | 8 +++++++-
 2 files changed, 14 insertions(+), 1 deletion(-)
package/libwebsockets/Config.in +7 -0
index 2b350bf..e3c7eea 100644
@@ -8,3 +8,10 @@ config BR2_PACKAGE_LIBWEBSOCKETS
 	  in both directions.
 
 	  http://libwebsockets.org/
+
+if BR2_PACKAGE_LIBWEBSOCKETS
+
+config BR2_PACKAGE_LIBWEBSOCKETS_IPV6
+    bool "Compile with support for ipv6"
+
+endif
package/libwebsockets/libwebsockets.mk +7 -1
index 2f83748..f4a3db2 100644
@@ -11,7 +11,7 @@ LIBWEBSOCKETS_LICENSE = LGPLv2.1 with exceptions
 LIBWEBSOCKETS_LICENSE_FILES = LICENSE
 LIBWEBSOCKETS_DEPENDENCIES = zlib
 LIBWEBSOCKETS_INSTALL_STAGING = YES
-LIBWEBSOCKETS_CONF_OPTS = -DLWS_WITHOUT_TESTAPPS=ON -DLWS_IPV6=ON
+LIBWEBSOCKETS_CONF_OPTS = -DLWS_WITHOUT_TESTAPPS=ON
 
 ifeq ($(BR2_PACKAGE_OPENSSL),y)
 LIBWEBSOCKETS_DEPENDENCIES += openssl host-openssl
@@ -20,4 +20,10 @@ else
 LIBWEBSOCKETS_CONF_OPTS += -DLWS_WITH_SSL=OFF
 endif
 
+ifeq ($(BR2_PACKAGE_LIBWEBSOCKETS_IPV6),y)
+LIBWEBSOCKETS_CONF_OPTS += -DLWS_IPV6=ON
+else
+LIBWEBSOCKETS_CONF_OPTS += -DLWS_IPV6=OFF
+endif
+
 $(eval $(cmake-package))
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/1 libwebsockets: add option to enable/disable ipv6 support

Dear Andreas Wetzel,

Quoted 14 lines · Andreas Wetzel

Added configuration option BR2_PACKAGE_LIBWEBSOCKETS_IPV6 that adds -DLWS_IPV6=ON/OFF to LIBWEBSOCKETS_CONF_OPTS.

---
 package/libwebsockets/Config.in        | 7 +++++++
 package/libwebsockets/libwebsockets.mk | 8 +++++++-
 2 files changed, 14 insertions(+), 1 deletion(-)
package/libwebsockets/Config.in +0 -0
index 2b350bf..e3c7eea 100644

package/libwebsockets/Config.in config BR2_PACKAGE_LIBWEBSOCKETS · line 15

Quoted 8 lines
package/libwebsockets/Config.in +5 -0
@@ -8,3 +8,10 @@ config BR2_PACKAGE_LIBWEBSOCKETS
 	  in both directions.
 
 	  http://libwebsockets.org/
+
+if BR2_PACKAGE_LIBWEBSOCKETS
+
+config BR2_PACKAGE_LIBWEBSOCKETS_IPV6
+    bool "Compile with support for ipv6"

please use tabs for indentation, not spaces.

Regards,

Vincent.

Quoted 27 lines
package/libwebsockets/Config.in +2 -0
+
+endif
package/libwebsockets/libwebsockets.mk +7 -1
index 2f83748..f4a3db2 100644
@@ -11,7 +11,7 @@ LIBWEBSOCKETS_LICENSE = LGPLv2.1 with exceptions
 LIBWEBSOCKETS_LICENSE_FILES = LICENSE
 LIBWEBSOCKETS_DEPENDENCIES = zlib
 LIBWEBSOCKETS_INSTALL_STAGING = YES
-LIBWEBSOCKETS_CONF_OPTS = -DLWS_WITHOUT_TESTAPPS=ON -DLWS_IPV6=ON
+LIBWEBSOCKETS_CONF_OPTS = -DLWS_WITHOUT_TESTAPPS=ON
 
 ifeq ($(BR2_PACKAGE_OPENSSL),y)
 LIBWEBSOCKETS_DEPENDENCIES += openssl host-openssl
@@ -20,4 +20,10 @@ else
 LIBWEBSOCKETS_CONF_OPTS += -DLWS_WITH_SSL=OFF
 endif
 
+ifeq ($(BR2_PACKAGE_LIBWEBSOCKETS_IPV6),y)
+LIBWEBSOCKETS_CONF_OPTS += -DLWS_IPV6=ON
+else
+LIBWEBSOCKETS_CONF_OPTS += -DLWS_IPV6=OFF
+endif
+
 $(eval $(cmake-package))
#2 lore raw

PATCH 1/1 libwebsockets: add option to enable/disable ipv6 support

Hi Vincente,

Please find the corrected (with tabs) patch in the attachment.

Regards,
Andi

________________________________________
From: Vicente Olivert Riera <[email protected]>
Sent: Wednesday, September 23, 2015 16:08
To: Wetzel Andreas
Cc: buildroot
Subject: Re: [Buildroot] [PATCH 1/1] libwebsockets: add option to enable/disable ipv6 support

Dear Andreas Wetzel,

Quoted 14 lines · Andreas Wetzel

Added configuration option BR2_PACKAGE_LIBWEBSOCKETS_IPV6 that adds -DLWS_IPV6=ON/OFF to LIBWEBSOCKETS_CONF_OPTS.

---
 package/libwebsockets/Config.in        | 7 +++++++
 package/libwebsockets/libwebsockets.mk | 8 +++++++-
 2 files changed, 14 insertions(+), 1 deletion(-)
package/libwebsockets/Config.in +0 -0
index 2b350bf..e3c7eea 100644

package/libwebsockets/Config.in config BR2_PACKAGE_LIBWEBSOCKETS · line 15

Quoted 8 lines
package/libwebsockets/Config.in +5 -0
@@ -8,3 +8,10 @@ config BR2_PACKAGE_LIBWEBSOCKETS
        in both directions.
 
        http://libwebsockets.org/
+
+if BR2_PACKAGE_LIBWEBSOCKETS
+
+config BR2_PACKAGE_LIBWEBSOCKETS_IPV6
+    bool "Compile with support for ipv6"

please use tabs for indentation, not spaces.

Regards,

Vincent.

Quoted 17 lines
package/libwebsockets/Config.in +2 -0
+
+endif
package/libwebsockets/libwebsockets.mk +1 -1
index 2f83748..f4a3db2 100644
@@ -11,7 +11,7 @@ LIBWEBSOCKETS_LICENSE = LGPLv2.1 with exceptions
 LIBWEBSOCKETS_LICENSE_FILES = LICENSE
 LIBWEBSOCKETS_DEPENDENCIES = zlib
 LIBWEBSOCKETS_INSTALL_STAGING = YES
-LIBWEBSOCKETS_CONF_OPTS = -DLWS_WITHOUT_TESTAPPS=ON -DLWS_IPV6=ON
+LIBWEBSOCKETS_CONF_OPTS = -DLWS_WITHOUT_TESTAPPS=ON
 
 ifeq ($(BR2_PACKAGE_OPENSSL),y)
 LIBWEBSOCKETS_DEPENDENCIES += openssl host-openssl

package/libwebsockets/libwebsockets.mk else · line 29

Quoted 10 lines
package/libwebsockets/libwebsockets.mk +6 -0
@@ -20,4 +20,10 @@ else
 LIBWEBSOCKETS_CONF_OPTS += -DLWS_WITH_SSL=OFF
 endif
 
+ifeq ($(BR2_PACKAGE_LIBWEBSOCKETS_IPV6),y)
+LIBWEBSOCKETS_CONF_OPTS += -DLWS_IPV6=ON
+else
+LIBWEBSOCKETS_CONF_OPTS += -DLWS_IPV6=OFF
+endif
+
 $(eval $(cmake-package))

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-libwebsockets-add-option-to-enable-disable-ipv6-supp_v2.patch
Type: text/x-patch
Size: 1847 bytes
Desc: 0001-libwebsockets-add-option-to-enable-disable-ipv6-supp_v2.patch
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20150923/f5ae5df2/attachment.bin>

#3 lore raw

PATCH 1/1 libwebsockets: add option to enable/disable ipv6 support

Dear Wetzel Andreas,

thanks for fixing the issue.

Quoted 3 lines · Wetzel Andreas

Hi Vincente,

Please find the corrected (with tabs) patch in the attachment.

why don't you send the v2 of your patch using git send-email? The Buildroot project strongly prefers patches to be sent using git send-email. It easier for everyone to review them and also for the maintainer to apply them.

Regards,

Vincent.

Quoted 72 lines

Regards,
Andi

________________________________________
From: Vicente Olivert Riera <[email protected]>
Sent: Wednesday, September 23, 2015 16:08
To: Wetzel Andreas
Cc: buildroot
Subject: Re: [Buildroot] [PATCH 1/1] libwebsockets: add option to enable/disable ipv6 support

Dear Andreas Wetzel,

Quoted 14 lines · Andreas Wetzel

Added configuration option BR2_PACKAGE_LIBWEBSOCKETS_IPV6 that adds -DLWS_IPV6=ON/OFF to LIBWEBSOCKETS_CONF_OPTS.

---
 package/libwebsockets/Config.in        | 7 +++++++
 package/libwebsockets/libwebsockets.mk | 8 +++++++-
 2 files changed, 14 insertions(+), 1 deletion(-)
package/libwebsockets/Config.in +0 -0
index 2b350bf..e3c7eea 100644

package/libwebsockets/Config.in config BR2_PACKAGE_LIBWEBSOCKETS · line 15

Quoted 8 lines
package/libwebsockets/Config.in +5 -0
@@ -8,3 +8,10 @@ config BR2_PACKAGE_LIBWEBSOCKETS
        in both directions.
 
        http://libwebsockets.org/
+
+if BR2_PACKAGE_LIBWEBSOCKETS
+
+config BR2_PACKAGE_LIBWEBSOCKETS_IPV6
+    bool "Compile with support for ipv6"

please use tabs for indentation, not spaces.

Regards,

Vincent.

Quoted 27 lines
package/libwebsockets/Config.in +2 -0
+
+endif
package/libwebsockets/libwebsockets.mk +7 -1
index 2f83748..f4a3db2 100644
@@ -11,7 +11,7 @@ LIBWEBSOCKETS_LICENSE = LGPLv2.1 with exceptions
 LIBWEBSOCKETS_LICENSE_FILES = LICENSE
 LIBWEBSOCKETS_DEPENDENCIES = zlib
 LIBWEBSOCKETS_INSTALL_STAGING = YES
-LIBWEBSOCKETS_CONF_OPTS = -DLWS_WITHOUT_TESTAPPS=ON -DLWS_IPV6=ON
+LIBWEBSOCKETS_CONF_OPTS = -DLWS_WITHOUT_TESTAPPS=ON
 
 ifeq ($(BR2_PACKAGE_OPENSSL),y)
 LIBWEBSOCKETS_DEPENDENCIES += openssl host-openssl
@@ -20,4 +20,10 @@ else
 LIBWEBSOCKETS_CONF_OPTS += -DLWS_WITH_SSL=OFF
 endif
 
+ifeq ($(BR2_PACKAGE_LIBWEBSOCKETS_IPV6),y)
+LIBWEBSOCKETS_CONF_OPTS += -DLWS_IPV6=ON
+else
+LIBWEBSOCKETS_CONF_OPTS += -DLWS_IPV6=OFF
+endif
+
 $(eval $(cmake-package))
#4 lore raw

PATCH 1/1 libwebsockets: add option to enable/disable ipv6 support

Hi Vincente,

I thought about using git send-email again. But then favoured a reply to have the history included in the mail body. Sorry for that.

Next time I will use git send-email again. I don't like our outlook webmail anyway :)

Regards,
Andi

________________________________________
From: Vicente Olivert Riera <[email protected]>
Sent: Wednesday, September 23, 2015 16:51
To: Wetzel Andreas
Cc: buildroot
Subject: Re: [Buildroot] [PATCH 1/1] libwebsockets: add option to enable/disable ipv6 support

Dear Wetzel Andreas,

thanks for fixing the issue.

Quoted 3 lines · Wetzel Andreas

Hi Vincente,

Please find the corrected (with tabs) patch in the attachment.

why don't you send the v2 of your patch using git send-email? The Buildroot project strongly prefers patches to be sent using git send-email. It easier for everyone to review them and also for the maintainer to apply them.

Regards,

Vincent.

Quoted 72 lines

Regards,
Andi

________________________________________
From: Vicente Olivert Riera <[email protected]>
Sent: Wednesday, September 23, 2015 16:08
To: Wetzel Andreas
Cc: buildroot
Subject: Re: [Buildroot] [PATCH 1/1] libwebsockets: add option to enable/disable ipv6 support

Dear Andreas Wetzel,

Quoted 14 lines · Andreas Wetzel

Added configuration option BR2_PACKAGE_LIBWEBSOCKETS_IPV6 that adds -DLWS_IPV6=ON/OFF to LIBWEBSOCKETS_CONF_OPTS.

---
 package/libwebsockets/Config.in        | 7 +++++++
 package/libwebsockets/libwebsockets.mk | 8 +++++++-
 2 files changed, 14 insertions(+), 1 deletion(-)
package/libwebsockets/Config.in +0 -0
index 2b350bf..e3c7eea 100644

package/libwebsockets/Config.in config BR2_PACKAGE_LIBWEBSOCKETS · line 15

Quoted 8 lines
package/libwebsockets/Config.in +5 -0
@@ -8,3 +8,10 @@ config BR2_PACKAGE_LIBWEBSOCKETS
        in both directions.
 
        http://libwebsockets.org/
+
+if BR2_PACKAGE_LIBWEBSOCKETS
+
+config BR2_PACKAGE_LIBWEBSOCKETS_IPV6
+    bool "Compile with support for ipv6"

please use tabs for indentation, not spaces.

Regards,

Vincent.

Quoted 27 lines
package/libwebsockets/Config.in +2 -0
+
+endif
package/libwebsockets/libwebsockets.mk +7 -1
index 2f83748..f4a3db2 100644
@@ -11,7 +11,7 @@ LIBWEBSOCKETS_LICENSE = LGPLv2.1 with exceptions
 LIBWEBSOCKETS_LICENSE_FILES = LICENSE
 LIBWEBSOCKETS_DEPENDENCIES = zlib
 LIBWEBSOCKETS_INSTALL_STAGING = YES
-LIBWEBSOCKETS_CONF_OPTS = -DLWS_WITHOUT_TESTAPPS=ON -DLWS_IPV6=ON
+LIBWEBSOCKETS_CONF_OPTS = -DLWS_WITHOUT_TESTAPPS=ON
 
 ifeq ($(BR2_PACKAGE_OPENSSL),y)
 LIBWEBSOCKETS_DEPENDENCIES += openssl host-openssl
@@ -20,4 +20,10 @@ else
 LIBWEBSOCKETS_CONF_OPTS += -DLWS_WITH_SSL=OFF
 endif
 
+ifeq ($(BR2_PACKAGE_LIBWEBSOCKETS_IPV6),y)
+LIBWEBSOCKETS_CONF_OPTS += -DLWS_IPV6=ON
+else
+LIBWEBSOCKETS_CONF_OPTS += -DLWS_IPV6=OFF
+endif
+
 $(eval $(cmake-package))
#5 lore raw

PATCH 1/1 libwebsockets: add option to enable/disable ipv6 support

Dear Wetzel Andreas,

Quoted 5 lines · Wetzel Andreas

Hi Vincente,

I thought about using git send-email again. But then favoured a reply to have the history included in the mail body. Sorry for that.

Next time I will use git send-email again. I don't like our outlook webmail anyway :)

Nobody will do it for you, so I suggest you to send the v2 using send email. That's what I would do if I were you :P

Regards,

Vincent.

Quoted 103 lines

Regards,
Andi

________________________________________
From: Vicente Olivert Riera <[email protected]>
Sent: Wednesday, September 23, 2015 16:51
To: Wetzel Andreas
Cc: buildroot
Subject: Re: [Buildroot] [PATCH 1/1] libwebsockets: add option to enable/disable ipv6 support

Dear Wetzel Andreas,

thanks for fixing the issue.

Quoted 3 lines · Wetzel Andreas

Hi Vincente,

Please find the corrected (with tabs) patch in the attachment.

why don't you send the v2 of your patch using git send-email? The Buildroot project strongly prefers patches to be sent using git send-email. It easier for everyone to review them and also for the maintainer to apply them.

Regards,

Vincent.

Quoted 72 lines

Regards,
Andi

________________________________________
From: Vicente Olivert Riera <[email protected]>
Sent: Wednesday, September 23, 2015 16:08
To: Wetzel Andreas
Cc: buildroot
Subject: Re: [Buildroot] [PATCH 1/1] libwebsockets: add option to enable/disable ipv6 support

Dear Andreas Wetzel,

Quoted 14 lines · Andreas Wetzel

Added configuration option BR2_PACKAGE_LIBWEBSOCKETS_IPV6 that adds -DLWS_IPV6=ON/OFF to LIBWEBSOCKETS_CONF_OPTS.

---
 package/libwebsockets/Config.in        | 7 +++++++
 package/libwebsockets/libwebsockets.mk | 8 +++++++-
 2 files changed, 14 insertions(+), 1 deletion(-)
package/libwebsockets/Config.in +0 -0
index 2b350bf..e3c7eea 100644

package/libwebsockets/Config.in config BR2_PACKAGE_LIBWEBSOCKETS · line 15

Quoted 8 lines
package/libwebsockets/Config.in +5 -0
@@ -8,3 +8,10 @@ config BR2_PACKAGE_LIBWEBSOCKETS
        in both directions.
 
        http://libwebsockets.org/
+
+if BR2_PACKAGE_LIBWEBSOCKETS
+
+config BR2_PACKAGE_LIBWEBSOCKETS_IPV6
+    bool "Compile with support for ipv6"

please use tabs for indentation, not spaces.

Regards,

Vincent.

Quoted 27 lines
package/libwebsockets/Config.in +2 -0
+
+endif
package/libwebsockets/libwebsockets.mk +7 -1
index 2f83748..f4a3db2 100644
@@ -11,7 +11,7 @@ LIBWEBSOCKETS_LICENSE = LGPLv2.1 with exceptions
 LIBWEBSOCKETS_LICENSE_FILES = LICENSE
 LIBWEBSOCKETS_DEPENDENCIES = zlib
 LIBWEBSOCKETS_INSTALL_STAGING = YES
-LIBWEBSOCKETS_CONF_OPTS = -DLWS_WITHOUT_TESTAPPS=ON -DLWS_IPV6=ON
+LIBWEBSOCKETS_CONF_OPTS = -DLWS_WITHOUT_TESTAPPS=ON
 
 ifeq ($(BR2_PACKAGE_OPENSSL),y)
 LIBWEBSOCKETS_DEPENDENCIES += openssl host-openssl
@@ -20,4 +20,10 @@ else
 LIBWEBSOCKETS_CONF_OPTS += -DLWS_WITH_SSL=OFF
 endif
 
+ifeq ($(BR2_PACKAGE_LIBWEBSOCKETS_IPV6),y)
+LIBWEBSOCKETS_CONF_OPTS += -DLWS_IPV6=ON
+else
+LIBWEBSOCKETS_CONF_OPTS += -DLWS_IPV6=OFF
+endif
+
 $(eval $(cmake-package))
#6 lore raw

PATCH 1/1 libwebsockets: add option to enable/disable ipv6 support

In reply to Andreas Wetzel

Dear Andreas Wetzel,

Quoted 4 lines · Andreas Wetzel

Added configuration option BR2_PACKAGE_LIBWEBSOCKETS_IPV6 that adds -DLWS_IPV6=ON/OFF to LIBWEBSOCKETS_CONF_OPTS.

We stopped supporting IPv6 as an optional feature in the toolchain, and made it mandatory. So, to go in the same direction, I would suggest to simply always enable IPv6 in libwebsockets.

What is the size overhead of enabling IPv6 ? If it's reasonable, then we want IPv6 to be unconditionally enabled.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#7 lore raw

PATCH 1/1 libwebsockets: add option to enable/disable ipv6 support

Hi Thomas,

Ok, I was not aware that you made IPv6 mandantory. Sorry for that.

Currently, IPv6 is always enabled for libwebsockets.
In a project we used a kernel without support for IPv6. libwebsockets (with ipv6 support) seem to cause problems if the kernel does not support IPv6 at all. That's why I thought such configuration option would make sense.

Size is no reason. Including IPv6 support is a matter of a few kilobytes.

So my resolution is to add IPv6 support to the linux kernel we use to.

Thank you,
Andi
________________________________________
From: Thomas Petazzoni <[email protected]>
Sent: Wednesday, September 23, 2015 23:02
To: Wetzel Andreas
Cc: buildroot at busybox.net; Gustavo Zacarias
Subject: Re: [Buildroot] [PATCH 1/1] libwebsockets: add option to enable/disable ipv6 support

Dear Andreas Wetzel,

Quoted 4 lines · Andreas Wetzel

Added configuration option BR2_PACKAGE_LIBWEBSOCKETS_IPV6 that adds -DLWS_IPV6=ON/OFF to LIBWEBSOCKETS_CONF_OPTS.

We stopped supporting IPv6 as an optional feature in the toolchain, and made it mandatory. So, to go in the same direction, I would suggest to simply always enable IPv6 in libwebsockets.

What is the size overhead of enabling IPv6 ? If it's reasonable, then we want IPv6 to be unconditionally enabled.

Best regards,

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

#8 lore raw

PATCH 1/1 libwebsockets: add option to enable/disable ipv6 support

Hello Andreas,

Quoted 8 lines · Wetzel Andreas

Ok, I was not aware that you made IPv6 mandantory. Sorry for that.

Currently, IPv6 is always enabled for libwebsockets.
In a project we used a kernel without support for IPv6. libwebsockets (with ipv6 support) seem to cause problems if the kernel does not support IPv6 at all. That's why I thought such configuration option would make sense.

Size is no reason. Including IPv6 support is a matter of a few kilobytes.

So my resolution is to add IPv6 support to the linux kernel we use to.

What is the size difference of the kernel with/without IPv6 enabled? If it's very significant, then maybe we need to revisit this? Gustavo?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#9 lore raw

PATCH 1/1 libwebsockets: add option to enable/disable ipv6 support

Quoted 8 lines · Thomas Petazzoni
Quoted 3 lines

Size is no reason. Including IPv6 support is a matter of a few kilobytes.

So my resolution is to add IPv6 support to the linux kernel we use to.

What is the size difference of the kernel with/without IPv6 enabled? If it's very significant, then maybe we need to revisit this? Gustavo?

Thomas

Hi Thomas.
Size delta kernel 4.2.1 x86_64_defconfig:
System is 5879 kB vs 5704 kB
Not much.

Keep in mind that even if we introduce the ipv6 option back this will be an issue anyway with glibc and musl-based systems since the kernel might lack ipv6 as well, sounds more like a bug than anything else.

Regards.

#10 lore raw

PATCH 1/1 libwebsockets: add option to enable/disable ipv6 support

Hello,

Quoted 4 lines · Gustavo Zacarias

Hi Thomas.
Size delta kernel 4.2.1 x86_64_defconfig:
System is 5879 kB vs 5704 kB
Not much.

Still quite a bit, but not huge either.

Quoted 3 lines

Keep in mind that even if we introduce the ipv6 option back this will be an issue anyway with glibc and musl-based systems since the kernel might lack ipv6 as well, sounds more like a bug than anything else.

Yes, probably libwebsockets should be able to work with IPv6 enabled even if IPv6 support is disabled in the kernel, no?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#11 lore raw

PATCH 1/1 libwebsockets: add option to enable/disable ipv6 support

In reply to Andreas Wetzel
Quoted 4 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Andreas" == Andreas Wetzel <[email protected]> writes:

Added configuration option BR2_PACKAGE_LIBWEBSOCKETS_IPV6 that adds -DLWS_IPV6=ON/OFF to LIBWEBSOCKETS_CONF_OPTS.

So apparently this is a bug in libwebsockets? Have you brought up the issue with the libwebsockets developers?

Signature · 1 line
Bye, Peter Korsgaard
#12 lore raw

PATCH 1/1 libwebsockets: add option to enable/disable ipv6 support

Quoted 7 lines
Quoted 4 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Andreas" == Andreas Wetzel <[email protected]> writes:

Added configuration option BR2_PACKAGE_LIBWEBSOCKETS_IPV6 that adds -DLWS_IPV6=ON/OFF to LIBWEBSOCKETS_CONF_OPTS.

So apparently this is a bug in libwebsockets? Have you brought up the issue with the libwebsockets developers?

I have not yet done that, but I'll for sure ask for comments in the libwebsockets list.

Regards,
Andi

#13 lore raw

PATCH 1/1 libwebsockets: add option to enable/disable ipv6 support

In reply to Andreas Wetzel

Dear Andreas Wetzel,

Quoted 4 lines · Andreas Wetzel

Added configuration option BR2_PACKAGE_LIBWEBSOCKETS_IPV6 that adds -DLWS_IPV6=ON/OFF to LIBWEBSOCKETS_CONF_OPTS.

Have you received some news from the upstream developers to explain why an IPv6-enabled libwebsocket breaks with a non-IPv6 capable kernel?

In the mean time, I'll mark your patch as Changes Requested in our patch tracking system, since you have received some comments. So please make sure you repost a new version once you receive more feedback from upstream (hopefully a patch for libwebsockets that makes it work correctly even if the kernel doesn't have IPv6 support).

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com