Staging: rtl8712: rtl871x_mp.h: Coding style warnings fix for block comment
PATCH 1/1 Staging: rtl8712: rtl871x_mp.h: Coding style warnings fix for block comment
This is a patch to the rtl871x_mp.h that fixes up following warnings reported by checkpatch.pl :
-Block comments use a trailing */ on a separate line
--- drivers/staging/rtl8712/rtl871x_mp.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/rtl8712/rtl871x_mp.h +2 -1
@@ -108,7 +108,8 @@ struct mp_priv {unsigned char network_macaddr[6 ];/*Testing Flag*/ u32 mode;/*0 for normal type packet, -* 1 for loopback packet (16bytes TXCMD)*/ +* 1 for loopback packet (16bytes TXCMD) +*/ sint prev_fw_state;u8 *pallocated_mp_xmitframe_buf;u8 *pmp_xmtframe_buf;
Signature · 1 line
2.5.2
Quoted 15 lines · Punit Vara
This is a patch to the
rtl871x_mp.hthat fixes up following warnings reported by checkpatch.pl :-Block comments use a trailing */ on a separate line
Signed-off-by Punit Vara <[email protected]>--- drivers/staging/rtl8712/rtl871x_mp.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/staging/rtl8712/rtl871x_mp.h +0
-0
drivers/staging/rtl8712/rtl871x_mp.h struct mp_priv { · line 110
Quoted 3 lines
drivers/staging/rtl8712/rtl871x_mp.h +0
-0@@ -108,7 +108,8 @@ struct mp_priv {unsigned char network_macaddr[6 ];/*Testing Flag*/ u32 mode;/*0 for normal type packet,
This first line is missing some spaces so the whole comment needs to be redone.
u32 mode; /* 0 for normal type packet,
* 1 for loopback packet (16bytes TXCMD) */
regards,
dan carpenter
Quoted 23 lines · Dan Carpenter
Quoted 15 lines · Punit Vara
This is a patch to the
rtl871x_mp.hthat fixes up following warnings reported by checkpatch.pl :-Block comments use a trailing */ on a separate line
Signed-off-by Punit Vara <[email protected]>--- drivers/staging/rtl8712/rtl871x_mp.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/staging/rtl8712/rtl871x_mp.h +0
-0drivers/staging/rtl8712/rtl871x_mp.h struct mp_priv { · line 110
Quoted 3 lines
drivers/staging/rtl8712/rtl871x_mp.h +0
-0@@ -108,7 +108,8 @@ struct mp_priv {unsigned char network_macaddr[6 ];/*Testing Flag*/ u32 mode;/*0 for normal type packet, This first line is missing some spaces so the whole comment needs to be redone.
Quoted 3 lines
u32 mode; /* 0 for normal type packet,
* 1 for loopback packet (16bytes TXCMD) */
If he is modifying the first line then shouldn't it be:
u32 mode; /* * 0 for normal type packet, * 1 for loopback packet (16bytes TXCMD) */
regards
sudip
Quoted 24 lines · Sudip Mukherjee
Quoted 23 lines · Dan Carpenter
Quoted 15 lines · Punit Vara
This is a patch to the
rtl871x_mp.hthat fixes up following warnings reported by checkpatch.pl :-Block comments use a trailing */ on a separate line
Signed-off-by Punit Vara <[email protected]>--- drivers/staging/rtl8712/rtl871x_mp.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/staging/rtl8712/rtl871x_mp.h +0
-0drivers/staging/rtl8712/rtl871x_mp.h struct mp_priv { · line 110
Quoted 3 lines
drivers/staging/rtl8712/rtl871x_mp.h +0
-0@@ -108,7 +108,8 @@ struct mp_priv {unsigned char network_macaddr[6 ];/*Testing Flag*/ u32 mode;/*0 for normal type packet, This first line is missing some spaces so the whole comment needs to be redone.
Quoted 9 lines
Quoted 3 lines
u32 mode; /* 0 for normal type packet,
* 1 for loopback packet (16bytes TXCMD) */If he is modifying the first line then shouldn't it be:
u32 mode; /* * 0 for normal type packet, * 1 for loopback packet (16bytes TXCMD) */
Networking code doesn't use the empty first line.
regards,
dan carpenter
Quoted 35 lines · Dan Carpenter
Quoted 24 lines · Sudip Mukherjee
Quoted 23 lines · Dan Carpenter
Quoted 15 lines · Punit Vara
This is a patch to the
rtl871x_mp.hthat fixes up following warnings reported by checkpatch.pl :-Block comments use a trailing */ on a separate line
Signed-off-by Punit Vara <[email protected]>--- drivers/staging/rtl8712/rtl871x_mp.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/staging/rtl8712/rtl871x_mp.h +0
-0drivers/staging/rtl8712/rtl871x_mp.h struct mp_priv { · line 110
Quoted 3 lines
drivers/staging/rtl8712/rtl871x_mp.h +0
-0@@ -108,7 +108,8 @@ struct mp_priv {unsigned char network_macaddr[6 ];/*Testing Flag*/ u32 mode;/*0 for normal type packet, This first line is missing some spaces so the whole comment needs to be redone.
Quoted 9 lines
Quoted 3 lines
u32 mode; /* 0 for normal type packet,
* 1 for loopback packet (16bytes TXCMD) */If he is modifying the first line then shouldn't it be:
u32 mode; /*
* 0 for normal type packet,
* 1 for loopback packet (16bytes TXCMD) */
Quoted 5 lines
Networking code doesn't use the empty first line.
regards,
dan carpenter
Yes I did that mistake in 2-3 files but after that I have got I was doing mistake . Then I did not repeat the mistake. I Am waiting for Greg's response whether again I have to send all patches in series So I will definitely resend after fixing it.