Skip to contentSkip to conversation

usb: doc: Add bindings for ULPI platform driver

RFC PATCH In review Subbaraya Sundeep Bhatta 6 participants 9 messages Sep 23, 2015 – Oct 28, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/2 usb: doc: Add bindings for ULPI platform driver

This patch adds binding doc info for generic ULPI PHYs platform driver.

---
 .../devicetree/bindings/usb/ulpi-platform-phy.txt  |   34 ++++++++++++++++++++
 1 files changed, 34 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt
Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt new file +34 -0
new file mode 100644
index 0000000..7b8cbb4
@@ -0,0 +1,34 @@
+Platform driver for generic ULPI PHYs
+
+Required properties:
+- compatible		: Should be "ulpi-phy"
+- reg			: Physical base address and size of the USB
+			  controller registers map to which this PHY
+			  is connected.
+- view-port		: Should contain viewport register offset of the
+			  USB controller to which this PHY is connected
+Optional properties:
+- drv-vbus		: required if turning VBUS on/off has to be driven
+			  by writing to PHY. This feature depends on board
+			  design.
+
+Example:
+Below example shows the PHY binding for Chipidea USB controller which has
+ulpi viewport register at 0x0170
+
+		usb_phy0: phy0 {
+                	compatible = "ulpi-phy";
+                	reg = <0xe0002000 0x1000>;
+                	view-port = <0x0170>;
+                	drv-vbus;
+        	};
+
+		usb0: usb@e0002000 {
+                        compatible = "chipidea,usb2";
+                        interrupt-parent = <&intc>;
+                        interrupts = <0 21 4>;
+                        reg = <0xe0002000 0x1000>;
+                        phy_type = "ulpi";
+			dr_mode = "host";
+			usb-phy = <&usb_phy0>;
+                };
Signature · 1 line
1.7.1
#1 lore raw
Quoted 35 lines · Subbaraya Sundeep Bhatta

This patch adds binding doc info for generic ULPI PHYs platform driver.

---
 .../devicetree/bindings/usb/ulpi-platform-phy.txt  |   34 ++++++++++++++++++++
 1 files changed, 34 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt
Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt new file +20 -0
new file mode 100644
index 0000000..7b8cbb4
@@ -0,0 +1,34 @@
+Platform driver for generic ULPI PHYs
+
+Required properties:
+- compatible		: Should be "ulpi-phy"
+- reg			: Physical base address and size of the USB
+			  controller registers map to which this PHY
+			  is connected.
+- view-port		: Should contain viewport register offset of the
+			  USB controller to which this PHY is connected
+Optional properties:
+- drv-vbus		: required if turning VBUS on/off has to be driven
+			  by writing to PHY. This feature depends on board
+			  design.
+
+Example:
+Below example shows the PHY binding for Chipidea USB controller which has
+ulpi viewport register at 0x0170
+
+		usb_phy0: phy0 {
+                	compatible = "ulpi-phy";

Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt line 30

Quoted 10 lines
Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt new file +10 -0
+                	reg = <0xe0002000 0x1000>;
+                	view-port = <0x0170>;
+                	drv-vbus;
+        	};
+
+		usb0: usb at e0002000 {
+                        compatible = "chipidea,usb2";
+                        interrupt-parent = <&intc>;
+                        interrupts = <0 21 4>;
+                        reg = <0xe0002000 0x1000>;

Although just call devm_ioremap twice for the same register region does not cause any errors, I am not sure if it will has other potential problems. Cc: arm list.

Quoted 7 lines
Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt new file +4 -0
+                        phy_type = "ulpi";
+			dr_mode = "host";
+			usb-phy = <&usb_phy0>;
+                };
Signature · 1 line
1.7.1
Signature · 2 lines
Best Regards,
Peter Chen
#2 lore raw

Hi Peter,

Quoted 56 lines

-----Original Message-----
From: Peter Chen [mailto:peter.chen at freescale.com]
Sent: Thursday, September 24, 2015 2:41 PM
To: Subbaraya Sundeep Bhatta
Cc: balbi at ti.com; devicetree at vger.kernel.org; kishon at ti.com; gregkh at linuxfoundation.org; linux-usb at vger.kernel.org; linux- kernel at vger.kernel.org; Punnaiah Choudary Kalluri; Subbaraya Sundeep Bhatta; linux-arm-kernel at lists.infradead.org
Subject: Re: [RFC PATCH 1/2] usb: doc: Add bindings for ULPI platform driver

Quoted 6 lines · Subbaraya Sundeep Bhatta

This patch adds binding doc info for generic ULPI PHYs platform driver.

---
 .../devicetree/bindings/usb/ulpi-platform-phy.txt  |   34

++++++++++++++++++++

Quoted 37 lines
 1 files changed, 34 insertions(+), 0 deletions(-)  create mode 100644

Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt

diff --git a/Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt b/Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt new file mode 100644
index 0000000..7b8cbb4

Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt new file +26 -0
@@ -0,0 +1,34 @@
+Platform driver for generic ULPI PHYs
+
+Required properties:
+- compatible		: Should be "ulpi-phy"
+- reg			: Physical base address and size of the USB
+			  controller registers map to which this PHY
+			  is connected.
+- view-port		: Should contain viewport register offset of the
+			  USB controller to which this PHY is connected Optional
+properties:
+- drv-vbus		: required if turning VBUS on/off has to be driven
+			  by writing to PHY. This feature depends on board
+			  design.
+
+Example:
+Below example shows the PHY binding for Chipidea USB controller which
+has ulpi viewport register at 0x0170
+
+		usb_phy0: phy0 {
+                	compatible = "ulpi-phy";
+                	reg = <0xe0002000 0x1000>;
+                	view-port = <0x0170>;
+                	drv-vbus;
+        	};
+
+		usb0: usb at e0002000 {
Quoted 8 lines

Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt line 30

Quoted 4 lines
Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt new file +4 -0
+                        compatible = "chipidea,usb2";
+                        interrupt-parent = <&intc>;
+                        interrupts = <0 21 4>;
+                        reg = <0xe0002000 0x1000>;

Although just call devm_ioremap twice for the same register region does not cause any errors, I am not sure if it will has other potential problems. Cc: arm list.

Yes Peter I was also in doubt to call devm_ioremap twice for same register region. devm_ioremap_resource complained hence modified to devm_ioremap. Thanks for adding arm-list.

Sundeep

Quoted 13 lines
Quoted 8 lines
Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt new file +4 -1
+                        phy_type = "ulpi";
+			dr_mode = "host";
+			usb-phy = <&usb_phy0>;
+                };
--

1.7.1

--

Best Regards,
Peter Chen

maintainer
#3 lore raw
Quoted 67 lines · Subbaraya Sundeep Bhatta

Hi Peter,

Quoted 56 lines

-----Original Message-----
From: Peter Chen [mailto:peter.chen at freescale.com]
Sent: Thursday, September 24, 2015 2:41 PM
To: Subbaraya Sundeep Bhatta
Cc: balbi at ti.com; devicetree at vger.kernel.org; kishon at ti.com; gregkh at linuxfoundation.org; linux-usb at vger.kernel.org; linux- kernel at vger.kernel.org; Punnaiah Choudary Kalluri; Subbaraya Sundeep Bhatta; linux-arm-kernel at lists.infradead.org
Subject: Re: [RFC PATCH 1/2] usb: doc: Add bindings for ULPI platform driver

Quoted 6 lines · Subbaraya Sundeep Bhatta

This patch adds binding doc info for generic ULPI PHYs platform driver.

---
 .../devicetree/bindings/usb/ulpi-platform-phy.txt  |   34

++++++++++++++++++++

Quoted 37 lines
 1 files changed, 34 insertions(+), 0 deletions(-)  create mode 100644

Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt

diff --git a/Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt b/Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt new file mode 100644
index 0000000..7b8cbb4

Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt new file +26 -0
@@ -0,0 +1,34 @@
+Platform driver for generic ULPI PHYs
+
+Required properties:
+- compatible               : Should be "ulpi-phy"
+- reg                      : Physical base address and size of the USB
+                     controller registers map to which this PHY
+                     is connected.
+- view-port                : Should contain viewport register offset of the
+                     USB controller to which this PHY is connected Optional
+properties:
+- drv-vbus         : required if turning VBUS on/off has to be driven
+                     by writing to PHY. This feature depends on board
+                     design.
+
+Example:
+Below example shows the PHY binding for Chipidea USB controller which
+has ulpi viewport register at 0x0170
+
+           usb_phy0: phy0 {
+                   compatible = "ulpi-phy";
+                   reg = <0xe0002000 0x1000>;
+                   view-port = <0x0170>;
+                   drv-vbus;
+           };
+
+           usb0: usb at e0002000 {
Quoted 8 lines

Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt line 30

Quoted 4 lines
Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt new file +4 -0
+                        compatible = "chipidea,usb2";
+                        interrupt-parent = <&intc>;
+                        interrupts = <0 21 4>;
+                        reg = <0xe0002000 0x1000>;

Although just call devm_ioremap twice for the same register region does not cause any errors, I am not sure if it will has other potential problems. Cc: arm list.

Quoted 3 lines

Yes Peter I was also in doubt to call devm_ioremap twice for same register region. devm_ioremap_resource complained hence modified to devm_ioremap. Thanks for adding arm-list.

Don't put overlapping resources in the DT. Having 2 drivers accessing the same registers is not a clean or safe design.

Rob

#4 lore raw
Quoted 69 lines · Rob Herring
Quoted 67 lines · Subbaraya Sundeep Bhatta

Hi Peter,

Quoted 64 lines

-----Original Message-----
From: Peter Chen [mailto:peter.chen at freescale.com]
Sent: Thursday, September 24, 2015 2:41 PM
To: Subbaraya Sundeep Bhatta
Cc: balbi at ti.com; devicetree at vger.kernel.org; kishon at ti.com; gregkh at linuxfoundation.org; linux-usb at vger.kernel.org; linux- kernel at vger.kernel.org; Punnaiah Choudary Kalluri; Subbaraya Sundeep Bhatta; linux-arm-kernel at lists.infradead.org
Subject: Re: [RFC PATCH 1/2] usb: doc: Add bindings for ULPI platform driver

Quoted 6 lines · Subbaraya Sundeep Bhatta

This patch adds binding doc info for generic ULPI PHYs platform driver.

---
 .../devicetree/bindings/usb/ulpi-platform-phy.txt  |   34

++++++++++++++++++++

Quoted 31 lines
 1 files changed, 34 insertions(+), 0 deletions(-)  create mode 100644

Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt

diff --git a/Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt b/Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt new file mode 100644
index 0000000..7b8cbb4

Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt new file +20 -0
@@ -0,0 +1,34 @@
+Platform driver for generic ULPI PHYs
+
+Required properties:
+- compatible               : Should be "ulpi-phy"
+- reg                      : Physical base address and size of the USB
+                     controller registers map to which this PHY
+                     is connected.
+- view-port                : Should contain viewport register offset of the
+                     USB controller to which this PHY is connected Optional
+properties:
+- drv-vbus         : required if turning VBUS on/off has to be driven
+                     by writing to PHY. This feature depends on board
+                     design.
+
+Example:
+Below example shows the PHY binding for Chipidea USB controller which
+has ulpi viewport register at 0x0170
+
+           usb_phy0: phy0 {
+                   compatible = "ulpi-phy";

Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt line 30

Quoted 10 lines
Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt new file +10 -0
+                   reg = <0xe0002000 0x1000>;
+                   view-port = <0x0170>;
+                   drv-vbus;
+           };
+
+           usb0: usb at e0002000 {
+                        compatible = "chipidea,usb2";
+                        interrupt-parent = <&intc>;
+                        interrupts = <0 21 4>;
+                        reg = <0xe0002000 0x1000>;

Although just call devm_ioremap twice for the same register region does not cause any errors, I am not sure if it will has other potential problems. Cc: arm list.

Quoted 6 lines
Quoted 3 lines

Yes Peter I was also in doubt to call devm_ioremap twice for same register region. devm_ioremap_resource complained hence modified to devm_ioremap. Thanks for adding arm-list.

Don't put overlapping resources in the DT. Having 2 drivers accessing the same registers is not a clean or safe design.

thanks, saves me the trouble of saying the same thing.

Bottom line, if devm_ioremap_resource() fails, you're wrong. Just fix your driver and move on.

Signature · 8 lines
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150930/dbaeba0c/attachment-0001.sig>
#5 lore raw
Quoted 74 lines · Felipe Balbi
Quoted 73 lines · Rob Herring
Quoted 70 lines · Subbaraya Sundeep Bhatta

Hi Peter,

Quoted 56 lines

-----Original Message-----
From: Peter Chen [mailto:peter.chen at freescale.com]
Sent: Thursday, September 24, 2015 2:41 PM
To: Subbaraya Sundeep Bhatta
Cc: balbi at ti.com; devicetree at vger.kernel.org; kishon at ti.com; gregkh at linuxfoundation.org; linux-usb at vger.kernel.org; linux- kernel at vger.kernel.org; Punnaiah Choudary Kalluri; Subbaraya Sundeep Bhatta; linux-arm-kernel at lists.infradead.org
Subject: Re: [RFC PATCH 1/2] usb: doc: Add bindings for ULPI platform driver

Quoted 6 lines · Subbaraya Sundeep Bhatta

This patch adds binding doc info for generic ULPI PHYs platform driver.

---
 .../devicetree/bindings/usb/ulpi-platform-phy.txt  |   34

++++++++++++++++++++

Quoted 37 lines
 1 files changed, 34 insertions(+), 0 deletions(-)  create mode 100644

Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt

diff --git a/Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt b/Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt new file mode 100644
index 0000000..7b8cbb4

Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt new file +26 -0
@@ -0,0 +1,34 @@
+Platform driver for generic ULPI PHYs
+
+Required properties:
+- compatible               : Should be "ulpi-phy"
+- reg                      : Physical base address and size of the USB
+                     controller registers map to which this PHY
+                     is connected.
+- view-port                : Should contain viewport register offset of the
+                     USB controller to which this PHY is connected Optional
+properties:
+- drv-vbus         : required if turning VBUS on/off has to be driven
+                     by writing to PHY. This feature depends on board
+                     design.
+
+Example:
+Below example shows the PHY binding for Chipidea USB controller which
+has ulpi viewport register at 0x0170
+
+           usb_phy0: phy0 {
+                   compatible = "ulpi-phy";
+                   reg = <0xe0002000 0x1000>;
+                   view-port = <0x0170>;
+                   drv-vbus;
+           };
+
+           usb0: usb at e0002000 {
Quoted 8 lines

Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt line 30

Quoted 4 lines
Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt new file +4 -0
+                        compatible = "chipidea,usb2";
+                        interrupt-parent = <&intc>;
+                        interrupts = <0 21 4>;
+                        reg = <0xe0002000 0x1000>;

Although just call devm_ioremap twice for the same register region does not cause any errors, I am not sure if it will has other potential problems. Cc: arm list.

Yes Peter I was also in doubt to call devm_ioremap twice for same register region. devm_ioremap_resource complained hence modified to devm_ioremap. Thanks for adding arm-list.

Quoted 7 lines
Quoted 2 lines

Don't put overlapping resources in the DT. Having 2 drivers accessing the same registers is not a clean or safe design.

thanks, saves me the trouble of saying the same thing.

Bottom line, if devm_ioremap_resource() fails, you're wrong. Just fix your driver and move on.

Any suggestions on how to move further?
Chipidea controller provides ulpi view port register for accessing the usb phy registers. Now we want to add new driver for ulpi phy configuration and that obviously it need of ulpi view port register access. So, sharing the register space between these two drivers is necessary here.

Regards,
Punnaiah

Quoted 3 lines

--
balbi

#6 lore raw

Hi,

Quoted 80 lines · punnaiah choudary kalluri
Quoted 79 lines · Felipe Balbi
Quoted 69 lines · Rob Herring
Quoted 67 lines · Subbaraya Sundeep Bhatta

Hi Peter,

Quoted 64 lines

-----Original Message-----
From: Peter Chen [mailto:peter.chen at freescale.com]
Sent: Thursday, September 24, 2015 2:41 PM
To: Subbaraya Sundeep Bhatta
Cc: balbi at ti.com; devicetree at vger.kernel.org; kishon at ti.com; gregkh at linuxfoundation.org; linux-usb at vger.kernel.org; linux- kernel at vger.kernel.org; Punnaiah Choudary Kalluri; Subbaraya Sundeep Bhatta; linux-arm-kernel at lists.infradead.org
Subject: Re: [RFC PATCH 1/2] usb: doc: Add bindings for ULPI platform driver

Quoted 6 lines · Subbaraya Sundeep Bhatta

This patch adds binding doc info for generic ULPI PHYs platform driver.

---
 .../devicetree/bindings/usb/ulpi-platform-phy.txt  |   34

++++++++++++++++++++

Quoted 31 lines
 1 files changed, 34 insertions(+), 0 deletions(-)  create mode 100644

Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt

diff --git a/Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt b/Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt new file mode 100644
index 0000000..7b8cbb4

Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt new file +20 -0
@@ -0,0 +1,34 @@
+Platform driver for generic ULPI PHYs
+
+Required properties:
+- compatible               : Should be "ulpi-phy"
+- reg                      : Physical base address and size of the USB
+                     controller registers map to which this PHY
+                     is connected.
+- view-port                : Should contain viewport register offset of the
+                     USB controller to which this PHY is connected Optional
+properties:
+- drv-vbus         : required if turning VBUS on/off has to be driven
+                     by writing to PHY. This feature depends on board
+                     design.
+
+Example:
+Below example shows the PHY binding for Chipidea USB controller which
+has ulpi viewport register at 0x0170
+
+           usb_phy0: phy0 {
+                   compatible = "ulpi-phy";

Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt line 30

Quoted 10 lines
Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt new file +10 -0
+                   reg = <0xe0002000 0x1000>;
+                   view-port = <0x0170>;
+                   drv-vbus;
+           };
+
+           usb0: usb at e0002000 {
+                        compatible = "chipidea,usb2";
+                        interrupt-parent = <&intc>;
+                        interrupts = <0 21 4>;
+                        reg = <0xe0002000 0x1000>;

Although just call devm_ioremap twice for the same register region does not cause any errors, I am not sure if it will has other potential problems. Cc: arm list.

Quoted 6 lines
Quoted 3 lines

Yes Peter I was also in doubt to call devm_ioremap twice for same register region. devm_ioremap_resource complained hence modified to devm_ioremap. Thanks for adding arm-list.

Don't put overlapping resources in the DT. Having 2 drivers accessing the same registers is not a clean or safe design.

thanks, saves me the trouble of saying the same thing.

Quoted 8 lines
Quoted 2 lines

Bottom line, if devm_ioremap_resource() fails, you're wrong. Just fix your driver and move on.

Any suggestions on how to move further?
Chipidea controller provides ulpi view port register for accessing the usb phy registers. Now we want to add new driver for ulpi phy configuration and that obviously it need of ulpi view port register access. So, sharing the register space between these two drivers is necessary here.

Why not program ULPI the same way as DWC3 does?

Thanks
Kishon

#7 lore raw

Hi Kishon,

Quoted 101 lines

-----Original Message-----
From: Kishon Vijay Abraham I [mailto:kishon at ti.com]
Sent: Sunday, October 11, 2015 8:11 PM
To: Punnaiah Choudary Kalluri; balbi at ti.com
Cc: Rob Herring; Subbaraya Sundeep Bhatta; Peter Chen; devicetree at vger.kernel.org; gregkh at linuxfoundation.org; linux- usb at vger.kernel.org; linux-kernel at vger.kernel.org; linux-arm- kernel at lists.infradead.org
Subject: Re: [RFC PATCH 1/2] usb: doc: Add bindings for ULPI platform driver

Hi,

Quoted 17 lines · punnaiah choudary kalluri
Quoted 16 lines · Felipe Balbi
Quoted 15 lines · Rob Herring
Quoted 13 lines · Subbaraya Sundeep Bhatta

Hi Peter,

Quoted 11 lines

-----Original Message-----
From: Peter Chen [mailto:peter.chen at freescale.com]
Sent: Thursday, September 24, 2015 2:41 PM
To: Subbaraya Sundeep Bhatta
Cc: balbi at ti.com; devicetree at vger.kernel.org; kishon at ti.com; gregkh at linuxfoundation.org; linux-usb at vger.kernel.org; linux- kernel at vger.kernel.org; Punnaiah Choudary Kalluri; Subbaraya Sundeep Bhatta; linux-arm-kernel at lists.infradead.org
Subject: Re: [RFC PATCH 1/2] usb: doc: Add bindings for ULPI platform driver

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

On Wed, Sep 23, 2015 at 06:24:01PM +0530, Subbaraya Sundeep

Bhatta

Quoted 56 lines
Quoted 56 lines
Quoted 56 lines
Quoted 56 lines
Quoted 55 lines
Quoted 6 lines · wrote:

This patch adds binding doc info for generic ULPI PHYs platform driver.

---
 .../devicetree/bindings/usb/ulpi-platform-phy.txt  |   34

++++++++++++++++++++

Quoted 33 lines
 1 files changed, 34 insertions(+), 0 deletions(-)  create mode

100644 Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt

diff --git a/Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt b/Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt new file mode 100644
index 0000000..7b8cbb4

Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt new file +21 -0
@@ -0,0 +1,34 @@
+Platform driver for generic ULPI PHYs
+
+Required properties:
+- compatible               : Should be "ulpi-phy"
+- reg                      : Physical base address and size of the USB
+                     controller registers map to which this PHY
+                     is connected.
+- view-port                : Should contain viewport register offset of the
+                     USB controller to which this PHY is
+connected Optional
+properties:
+- drv-vbus         : required if turning VBUS on/off has to be driven
+                     by writing to PHY. This feature depends on board
+                     design.
+
+Example:
+Below example shows the PHY binding for Chipidea USB controller
+which has ulpi viewport register at 0x0170
+
+           usb_phy0: phy0 {
+                   compatible = "ulpi-phy";

Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt line 31

Quoted 10 lines
Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt new file +10 -0
+                   reg = <0xe0002000 0x1000>;
+                   view-port = <0x0170>;
+                   drv-vbus;
+           };
+
+           usb0: usb at e0002000 {
+                        compatible = "chipidea,usb2";
+                        interrupt-parent = <&intc>;
+                        interrupts = <0 21 4>;
+                        reg = <0xe0002000 0x1000>;

Although just call devm_ioremap twice for the same register region does not cause any errors, I am not sure if it will has other potential problems. Cc: arm list.

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

Yes Peter I was also in doubt to call devm_ioremap twice for same register

region.

Quoted 11 lines
Quoted 10 lines
Quoted 5 lines
Quoted 2 lines

devm_ioremap_resource complained hence modified to devm_ioremap. Thanks for adding arm-list.

Don't put overlapping resources in the DT. Having 2 drivers accessing the same registers is not a clean or safe design.

thanks, saves me the trouble of saying the same thing.

Bottom line, if devm_ioremap_resource() fails, you're wrong. Just fix your driver and move on.

Quoted 8 lines
Quoted 5 lines

Any suggestions on how to move further?
Chipidea controller provides ulpi view port register for accessing the usb phy registers. Now we want to add new driver for ulpi phy configuration and that obviously it need of ulpi view port register access. So, sharing the register space between these two drivers is necessary

here.

Why not program ULPI the same way as DWC3 does?

Sorry for delay in response, back from long vacation.
Can we call generic PHY phy->power_on and power_off functions to do similar function as usb2_phy->set_vbus? I assume it is to power on whole PHY chip but not to enable 5V on VBUS line.

Thanks,
Sundeep

Quoted 3 lines

Thanks
Kishon

maintainer
#8 lore raw
In reply to Subbaraya Sundeep Bhatta
Quoted 15 lines · Subbaraya Sundeep Bhatta

This patch adds binding doc info for generic ULPI PHYs platform driver.

---
 .../devicetree/bindings/usb/ulpi-platform-phy.txt  |   34 ++++++++++++++++++++
 1 files changed, 34 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt
Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt new file +0 -0
new file mode 100644
index 0000000..7b8cbb4

Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt line 1

Quoted 1 line
Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt new file +1 -0
@@ -0,0 +1,34 @@
+Platform driver for generic ULPI PHYs

Platform driver has nothing to do with DT bindings.

Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt line 4

Quoted 3 lines
Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt new file +3 -0
+
+Required properties:
+- compatible           : Should be "ulpi-phy"

This needs a more specific compatible in addition.

Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt line 9

Quoted 5 lines
Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt new file +5 -0
+- reg                  : Physical base address and size of the USB
+                         controller registers map to which this PHY
+                         is connected.
+- view-port            : Should contain viewport register offset of the
+                         USB controller to which this PHY is connected

This is a property of the controller, not the phy.

Quoted 14 lines
Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt new file +14 -0
+Optional properties:
+- drv-vbus             : required if turning VBUS on/off has to be driven
+                         by writing to PHY. This feature depends on board
+                         design.
+
+Example:
+Below example shows the PHY binding for Chipidea USB controller which has
+ulpi viewport register at 0x0170
+
+               usb_phy0: phy0 {
+                       compatible = "ulpi-phy";
+                       reg = <0xe0002000 0x1000>;
+                       view-port = <0x0170>;
+                       drv-vbus;

Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt line 33

Quoted 10 lines
Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt new file +10 -0
+               };
+
+               usb0: usb@e0002000 {
+                        compatible = "chipidea,usb2";
+                        interrupt-parent = <&intc>;
+                        interrupts = <0 21 4>;
+                        reg = <0xe0002000 0x1000>;
+                        phy_type = "ulpi";
+                       dr_mode = "host";
+                       usb-phy = <&usb_phy0>;

usb-phy is deprecated. Use phys and the generic phy binding instead.

Quoted 8 lines
Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt new file +1 -1
+                };
--

1.7.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html