Skip to contentSkip to conversation

squeezelite: new package

PATCH Superseded kei-k at ca2.so-net.ne.jp 3 participants 15 messages Sep 24, 2015 – Sep 26, 2015

v12 of 14 Superseded Latest is v14 →

lore
Share & tools
lore
#0 lore raw

PATCH v12 1/1 squeezelite: new package

Dear, reviewers.

Thank you for your many comment and suggestions.

I'm very sorry to post patches so many times.
I think I reflected all feedbacks except TARGET_CONFIGURE_OPTS issue. I'm not sure the right way to fix this, so would anyone suggest me?

v11 -> v12
- remove -DRESAMPLE_MP, because libsoxr is compiled without openMP support in buildroot, so meaningless for now.
- add -DLINKALL to resolve symbols in optional libraries (libsoxr, etc).
- add more configuration options : ffmpeg, DSD, Visualizer. lirc support is not included for now, because more work will be necessary to use it (eg: modifying package/lirc-tools to add LIRC_TOOLS_INSTALL_STAGING = YES).

---
 package/Config.in                  |    1 +
 package/squeezelite/Config.in      |   46 ++++++++++++++++++++++++++++++++++++
 package/squeezelite/squeezelite.mk |   42 ++++++++++++++++++++++++++++++++
 3 files changed, 89 insertions(+), 0 deletions(-)
 create mode 100644 package/squeezelite/Config.in
 create mode 100644 package/squeezelite/squeezelite.mk
package/Config.in +1 -0
index 5158371..2a47420 100644
@@ -33,6 +33,7 @@ menu "Audio and video applications"
 	source "package/opus-tools/Config.in"
 	source "package/pulseaudio/Config.in"
 	source "package/sox/Config.in"
+	source "package/squeezelite/Config.in"
 	source "package/tidsp-binaries/Config.in"
 	source "package/tovid/Config.in"
 	source "package/tstools/Config.in"
package/squeezelite/Config.in new file +46 -0

46 lines not on this page · raw message

package/squeezelite/squeezelite.mk new file +42 -0

42 lines not on this page · raw message

Signature · 4 lines
1.7.1

============================================================
    Hiroshi Kawashima
#1 lore raw

PATCH v12 1/1 squeezelite: new package

Dear Hiroshi Kawashima,

are you able to download squeezelite? I'm having this problem:

Quoted 1 line
Quoted 1 line
Quoted 1 line

squeezelite v1.8 Downloading

Doing shallow clone
Initialized empty Git repository in /br/output/build/.squeezelite-v1.8.tar.gz.pb3XtQ/squeezelite-v1.8/
remote: Counting objects: 82, done.
Unpacking objects: 100% (82/82), done.
warning: Remote branch v1.8 not found in upstream origin, using HEAD instead
fatal: unable to read tree 668edec073bef579bedf43817f65aee3a592d0ef

Quoted 7 lines · On 09/24/2015 02:32 PM, kei-k at ca2.so-net.ne.jp wrote:

Dear, reviewers.

Thank you for your many comment and suggestions.

I'm very sorry to post patches so many times.
I think I reflected all feedbacks except TARGET_CONFIGURE_OPTS issue. I'm not sure the right way to fix this, so would anyone suggest me?

TARGET_CONFIGURE_OPTS is a variable which defines PATH, CC, LD and more things. You can have a look at it in package/Makefile.in, line #247.

Instead of passing CC="$(TARGET_CC)" LD="$(TARGET_LD) to the make command, you could just pass $(TARGET_CONFIGURE_OPTS).

There is a comment at the end where I show you how to use it.

Quoted 9 lines

v11 -> v12
- remove -DRESAMPLE_MP, because libsoxr is compiled without openMP support in buildroot, so meaningless for now.
- add -DLINKALL to resolve symbols in optional libraries (libsoxr, etc).
- add more configuration options : ffmpeg, DSD, Visualizer. lirc support is not included for now, because more work will be necessary to use it (eg: modifying package/lirc-tools to add LIRC_TOOLS_INSTALL_STAGING = YES).

Remember the changelog goes below "---".

Quoted 2 lines

---

Here is where the changelog should be.

Please read:

http://buildroot.org/downloads/manual/manual.html#submitting-patches

Scroll down until "21.5.2. Patch revision changelog" subsection.

Quoted 7 lines
 package/Config.in                  |    1 +
 package/squeezelite/Config.in      |   46 ++++++++++++++++++++++++++++++++++++
 package/squeezelite/squeezelite.mk |   42 ++++++++++++++++++++++++++++++++
 3 files changed, 89 insertions(+), 0 deletions(-)
 create mode 100644 package/squeezelite/Config.in
 create mode 100644 package/squeezelite/squeezelite.mk

[snip]

Quoted 31 lines
package/squeezelite/squeezelite.mk new file +25 -0
new file mode 100644
index 0000000..9611b97
@@ -0,0 +1,42 @@
+################################################################################
+#
+# squeezelite
+#
+################################################################################
+
+SQUEEZELITE_VERSION = v1.8
+SQUEEZELITE_SITE = https://code.google.com/p/squeezelite
+SQUEEZELITE_SITE_METHOD = git
+SQUEEZELITE_LICENSE = GPLv3
+SQUEEZELITE_LICENSE_FILE = LICENSE.txt
+SQUEEZELITE_DEPENDENCIES = alsa-lib flac libmad libvorbis faad2 mpg123
+SQUEEZELITE_MAKE_OPTS = -DLINKALL
+
+ifeq ($(BR2_PACKAGE_SQUEEZELITE_FF),y)
+SQUEEZELITE_DEPENDENCIES += ffmpeg
+SQUEEZELITE_MAKE_OPTS += -DFFMPEG
+endif
+
+ifeq ($(BR2_PACKAGE_SQUEEZELITE_DSD),y)
+SQUEEZELITE_MAKE_OPTS += -DDSD
+endif
+
+ifeq ($(BR2_PACKAGE_SQUEEZELITE_RESAMPLE),y)
+SQUEEZELITE_DEPENDENCIES += libsoxr

package/squeezelite/squeezelite.mk line 35

Quoted 10 lines
package/squeezelite/squeezelite.mk new file +10 -0
+SQUEEZELITE_MAKE_OPTS += -DRESAMPLE
+endif
+
+ifeq ($(BR2_PACKAGE_SQUEEZELITE_VISEXPORT),y)
+SQUEEZELITE_MAKE_OPTS += -DVISEXPORT
+endif
+
+define SQUEEZELITE_BUILD_CMDS
+	$(TARGET_MAKE_ENV) $(MAKE) OPTS="$(SQUEEZELITE_MAKE_OPTS)" \
+		CC="$(TARGET_CC)" LD="$(TARGET_LD)" -C $(@D) all

Here is where you could use the $(TARGET_CONFIGURE_OPTS) variable:

	$(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) \
		OPTS="$(SQUEEZELITE_MAKE_OPTS)" -C $(@D) all

Perhaps using $(TARGET_CONFIGURE_OPTS) as environment variable would work as well, and since it also defines PATH, then $(TARGET_MAKE_ENV) wouldn't be needed:

	$(TARGET_CONFIGURE_OPTS) $(MAKE) \
		OPTS="$(SQUEEZELITE_MAKE_OPTS)" -C $(@D) all

Regards,

Vincent.

Quoted 8 lines
package/squeezelite/squeezelite.mk new file +7 -0
+endef
+
+define SQUEEZELITE_INSTALL_TARGET_CMDS
+	$(INSTALL) -D -m 0755 $(@D)/squeezelite $(TARGET_DIR)/usr/bin
+endef
+
+$(eval $(generic-package))
#2 lore raw

PATCH v12 1/1 squeezelite: new package

Dear Hiroshi Kawashima,

On 09/24/2015 03:28 PM, Vicente Olivert Riera wrote:
[snip]

Quoted 6 lines

Perhaps using $(TARGET_CONFIGURE_OPTS) as environment variable would work as well, and since it also defines PATH, then $(TARGET_MAKE_ENV) wouldn't be needed:

	$(TARGET_CONFIGURE_OPTS) $(MAKE) \
		OPTS="$(SQUEEZELITE_MAKE_OPTS)" -C $(@D) all

By the way this could be in one line, as it would have exactly 79 characters.

Regards,

Vincent.

#3 lore raw

PATCH v12 1/1 squeezelite: new package

In reply to Vicente Olivert Riera

Dear, Vincente.

Thank you for your test and comment.

Quoted 4 lines · Vicente Olivert Riera

Dear Hiroshi Kawashima,

are you able to download squeezelite? I'm having this problem:

Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line

squeezelite v1.8 Downloading

Doing shallow clone
Initialized empty Git repository in /br/output/build/.squeezelite-v1.8.tar.gz.pb3XtQ/squeezelite-v1.8/
remote: Counting objects: 82, done.
Unpacking objects: 100% (82/82), done.
warning: Remote branch v1.8 not found in upstream origin, using HEAD instead
fatal: unable to read tree 668edec073bef579bedf43817f65aee3a592d0ef

Hmm...
I have been working on my cached source, so I did not realize it. Yes, I can reproduce your problem with real clean buildroot tree. Maybe something changed https://code.google.com/p/squeezelite repo since my last fetch.
I'm considering to change SQUEEZELITE_SITE to github repo like:
https://github.com/sixeyed/squeezelite
Does this repo work for you too ?

Quoted 10 lines
Quoted 2 lines

I think I reflected all feedbacks except TARGET_CONFIGURE_OPTS issue. I'm not sure the right way to fix this, so would anyone suggest me?

TARGET_CONFIGURE_OPTS is a variable which defines PATH, CC, LD and more things. You can have a look at it in package/Makefile.in, line #247.

Instead of passing CC="$(TARGET_CC)" LD="$(TARGET_LD) to the make command, you could just pass $(TARGET_CONFIGURE_OPTS).

There is a comment at the end where I show you how to use it.

[snip]

Quoted 9 lines

package/squeezelite/squeezelite.mk line 35

Quoted 3 lines
package/squeezelite/squeezelite.mk new file +3 -0
+define SQUEEZELITE_BUILD_CMDS
+	$(TARGET_MAKE_ENV) $(MAKE) OPTS="$(SQUEEZELITE_MAKE_OPTS)" \
+		CC="$(TARGET_CC)" LD="$(TARGET_LD)" -C $(@D) all

Here is where you could use the $(TARGET_CONFIGURE_OPTS) variable:

	$(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) \
		OPTS="$(SQUEEZELITE_MAKE_OPTS)" -C $(@D) all
Quoted 6 lines

Perhaps using $(TARGET_CONFIGURE_OPTS) as environment variable would work as well, and since it also defines PATH, then $(TARGET_MAKE_ENV) wouldn't be needed:

	$(TARGET_CONFIGURE_OPTS) $(MAKE) \
		OPTS="$(SQUEEZELITE_MAKE_OPTS)" -C $(@D) all

Yes, I know basic usage of TARGET_CONFIGURE_OPTS as you explained, thanks.
But just changing like this does not work with squeezelite's Makefile. I included squeezelite's Makefile in last of this e-mail. It determines optional libraries to be linked, I choose libsoxr as example like this:
...
CFLAGS ?= -Wall -fPIC -O2 $(OPTS)
LDFLAGS ?= -lasound -lpthread -lm -lrt
...
OPT_RESAMPLE= -DRESAMPLE
...
LINKALL_RESAMPLE = -lsoxr
...
ifneq (,$(findstring $(OPT_RESAMPLE), $(CFLAGS)))

        LDFLAGS += $(LINKALL_RESAMPLE)
endif
...
$(EXECUTABLE): $(OBJECTS)
	$(CC) $(OBJECTS) $(LDFLAGS) -o $@
...
.c.o:
	$(CC) $(CFLAGS) $(CPPFLAGS) $< -c -o $@

...

But TARGET_CONFIGURE_OPTS override CFLAGS, LDFLAGS, etc. It results original Makefile logic does not work.
Can you suggest me right way (of buildroot) how to solve this ? How should I control final CFLAGS, LDFLAGS, etc from squeezelite.mk file ?

Regards,
Kawashima

=== squeezelite Makefile ====
# Cross compile support - create a Makefile which defines these three variables and then includes this Makefile... CFLAGS ?= -Wall -fPIC -O2 $(OPTS)
LDFLAGS ?= -lasound -lpthread -lm -lrt
EXECUTABLE ?= squeezelite

# passing one or more of these in $(OPTS) enables optional feature inclusion
OPT_DSD     = -DDSD
OPT_FF      = -DFFMPEG
OPT_LINKALL = -DLINKALL
OPT_RESAMPLE= -DRESAMPLE
OPT_VIS     = -DVISEXPORT
OPT_IR      = -DIR
SOURCES = \
	main.c slimproto.c buffer.c stream.c utils.c \
	output.c output_alsa.c output_pa.c output_stdout.c output_pack.c decode.c \
	flac.c pcm.c mad.c vorbis.c faad.c mpg.c

SOURCES_DSD = dsd.c dop.c dsd2pcm/dsd2pcm.c
SOURCES_FF = ffmpeg.c
SOURCES_RESAMPLE = process.c resample.c
SOURCES_VIS = output_vis.c
SOURCES_IR = ir.c

LINK_LINUX = -ldl

LINKALL = -lFLAC -lmad -lvorbisfile -lfaad -lmpg123
LINKALL_FF = -lavcodec -lavformat -lavutil
LINKALL_RESAMPLE = -lsoxr
LINKALL_IR = -llirc_client

DEPS = squeezelite.h slimproto.h

UNAME = $(shell uname -s)

# add optional sources
ifneq (,$(findstring $(OPT_DSD), $(CFLAGS)))
	SOURCES += $(SOURCES_DSD)
endif
ifneq (,$(findstring $(OPT_FF), $(CFLAGS)))
	SOURCES += $(SOURCES_FF)
endif
ifneq (,$(findstring $(OPT_RESAMPLE), $(CFLAGS)))
	SOURCES += $(SOURCES_RESAMPLE)
endif
ifneq (,$(findstring $(OPT_VIS), $(CFLAGS)))
	SOURCES += $(SOURCES_VIS)
endif
ifneq (,$(findstring $(OPT_IR), $(CFLAGS)))
	SOURCES += $(SOURCES_IR)
endif
# add optional link options
ifneq (,$(findstring $(OPT_LINKALL), $(CFLAGS)))
	LDFLAGS += $(LINKALL)
ifneq (,$(findstring $(OPT_FF), $(CFLAGS)))
	LDFLAGS += $(LINKALL_FF)
endif
ifneq (,$(findstring $(OPT_RESAMPLE), $(CFLAGS)))
	LDFLAGS += $(LINKALL_RESAMPLE)
endif
ifneq (,$(findstring $(OPT_IR), $(CFLAGS)))
	LDFLAGS += $(LINKALL_IR)
endif
else
# if not LINKALL and linux add LINK_LINUX
ifeq ($(UNAME), Linux)
	LDFLAGS += $(LINK_LINUX)
endif
endif

OBJECTS = $(SOURCES:.c=.o)

all: $(EXECUTABLE)

$(EXECUTABLE): $(OBJECTS)

	$(CC) $(OBJECTS) $(LDFLAGS) -o $@

$(OBJECTS): $(DEPS)

.c.o:

	$(CC) $(CFLAGS) $(CPPFLAGS) $< -c -o $@

clean:

	rm -f $(OBJECTS) $(EXECUTABLE)

=== end of squeezelite Makefile ====
============================================================
Hiroshi Kawashima

#4 lore raw

PATCH v12 1/1 squeezelite: new package

Dear Hiroshi Kawashima,

Peter, Thomas, there is an issue commented below and I think it would be good to have your opinion on it.

Quoted 17 lines · On 09/25/2015 04:04 AM, kei-k at ca2.so-net.ne.jp wrote:

Dear, Vincente.

Thank you for your test and comment.

Quoted 4 lines · Vicente Olivert Riera

Dear Hiroshi Kawashima,

are you able to download squeezelite? I'm having this problem:

Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line

squeezelite v1.8 Downloading

Doing shallow clone
Initialized empty Git repository in /br/output/build/.squeezelite-v1.8.tar.gz.pb3XtQ/squeezelite-v1.8/
remote: Counting objects: 82, done.
Unpacking objects: 100% (82/82), done.
warning: Remote branch v1.8 not found in upstream origin, using HEAD instead
fatal: unable to read tree 668edec073bef579bedf43817f65aee3a592d0ef

Quoted 8 lines

Hmm...
I have been working on my cached source, so I did not realize it. Yes, I can reproduce your problem with real clean buildroot tree. Maybe something changed https://code.google.com/p/squeezelite repo since my last fetch.
I'm considering to change SQUEEZELITE_SITE to github repo like:
https://github.com/sixeyed/squeezelite
Does this repo work for you too ?

the fact that it works or not is not the problem. The problem is that right now there isn't any official repository for that project, so that repository could disappear tomorrow. And I don't know if the owner of that repository has made any change to the source code or not.

Perhaps downloading the tarballs from Google Code and putting them in mirror.buildroot.org would be the best option. I have added Peter and Thomas on CC so they can tell their opinion about this issue.

Hiroshi, there is one more little comment below; keep scrolling down.

Quoted 51 lines
Quoted 10 lines
Quoted 2 lines

I think I reflected all feedbacks except TARGET_CONFIGURE_OPTS issue. I'm not sure the right way to fix this, so would anyone suggest me?

TARGET_CONFIGURE_OPTS is a variable which defines PATH, CC, LD and more things. You can have a look at it in package/Makefile.in, line #247.

Instead of passing CC="$(TARGET_CC)" LD="$(TARGET_LD) to the make command, you could just pass $(TARGET_CONFIGURE_OPTS).

There is a comment at the end where I show you how to use it.

[snip]

Quoted 9 lines

package/squeezelite/squeezelite.mk line 35

Quoted 3 lines
package/squeezelite/squeezelite.mk new file +3 -0
+define SQUEEZELITE_BUILD_CMDS
+	$(TARGET_MAKE_ENV) $(MAKE) OPTS="$(SQUEEZELITE_MAKE_OPTS)" \
+		CC="$(TARGET_CC)" LD="$(TARGET_LD)" -C $(@D) all

Here is where you could use the $(TARGET_CONFIGURE_OPTS) variable:

	$(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) \
		OPTS="$(SQUEEZELITE_MAKE_OPTS)" -C $(@D) all
Quoted 6 lines

Perhaps using $(TARGET_CONFIGURE_OPTS) as environment variable would work as well, and since it also defines PATH, then $(TARGET_MAKE_ENV) wouldn't be needed:

	$(TARGET_CONFIGURE_OPTS) $(MAKE) \
		OPTS="$(SQUEEZELITE_MAKE_OPTS)" -C $(@D) all

Yes, I know basic usage of TARGET_CONFIGURE_OPTS as you explained, thanks.
But just changing like this does not work with squeezelite's Makefile. I included squeezelite's Makefile in last of this e-mail. It determines optional libraries to be linked, I choose libsoxr as example like this:
...
CFLAGS ?= -Wall -fPIC -O2 $(OPTS)
LDFLAGS ?= -lasound -lpthread -lm -lrt
...
OPT_RESAMPLE= -DRESAMPLE
...
LINKALL_RESAMPLE = -lsoxr
...
ifneq (,$(findstring $(OPT_RESAMPLE), $(CFLAGS)))

        LDFLAGS += $(LINKALL_RESAMPLE)
endif
...
$(EXECUTABLE): $(OBJECTS)
	$(CC) $(OBJECTS) $(LDFLAGS) -o $@
...
.c.o:
	$(CC) $(CFLAGS) $(CPPFLAGS) $< -c -o $@
Quoted 7 lines

...

But TARGET_CONFIGURE_OPTS override CFLAGS, LDFLAGS, etc. It results original Makefile logic does not work.
Can you suggest me right way (of buildroot) how to solve this ? How should I control final CFLAGS, LDFLAGS, etc from squeezelite.mk file ?

Well, if it doesn't work, then I guess is fine doing it by passing CC="$(TARGET_CC)" and LD="$(TARGET_LD)" as you already do.

Regards,

Vincent.

Quoted 93 lines

Regards,
Kawashima

=== squeezelite Makefile ====
# Cross compile support - create a Makefile which defines these three variables and then includes this Makefile... CFLAGS ?= -Wall -fPIC -O2 $(OPTS)
LDFLAGS ?= -lasound -lpthread -lm -lrt
EXECUTABLE ?= squeezelite

# passing one or more of these in $(OPTS) enables optional feature inclusion
OPT_DSD     = -DDSD
OPT_FF      = -DFFMPEG
OPT_LINKALL = -DLINKALL
OPT_RESAMPLE= -DRESAMPLE
OPT_VIS     = -DVISEXPORT
OPT_IR      = -DIR
SOURCES = \
	main.c slimproto.c buffer.c stream.c utils.c \
	output.c output_alsa.c output_pa.c output_stdout.c output_pack.c decode.c \
	flac.c pcm.c mad.c vorbis.c faad.c mpg.c

SOURCES_DSD = dsd.c dop.c dsd2pcm/dsd2pcm.c
SOURCES_FF = ffmpeg.c
SOURCES_RESAMPLE = process.c resample.c
SOURCES_VIS = output_vis.c
SOURCES_IR = ir.c

LINK_LINUX = -ldl

LINKALL = -lFLAC -lmad -lvorbisfile -lfaad -lmpg123
LINKALL_FF = -lavcodec -lavformat -lavutil
LINKALL_RESAMPLE = -lsoxr
LINKALL_IR = -llirc_client

DEPS = squeezelite.h slimproto.h

UNAME = $(shell uname -s)

# add optional sources
ifneq (,$(findstring $(OPT_DSD), $(CFLAGS)))
	SOURCES += $(SOURCES_DSD)
endif
ifneq (,$(findstring $(OPT_FF), $(CFLAGS)))
	SOURCES += $(SOURCES_FF)
endif
ifneq (,$(findstring $(OPT_RESAMPLE), $(CFLAGS)))
	SOURCES += $(SOURCES_RESAMPLE)
endif
ifneq (,$(findstring $(OPT_VIS), $(CFLAGS)))
	SOURCES += $(SOURCES_VIS)
endif
ifneq (,$(findstring $(OPT_IR), $(CFLAGS)))
	SOURCES += $(SOURCES_IR)
endif
# add optional link options
ifneq (,$(findstring $(OPT_LINKALL), $(CFLAGS)))
	LDFLAGS += $(LINKALL)
ifneq (,$(findstring $(OPT_FF), $(CFLAGS)))
	LDFLAGS += $(LINKALL_FF)
endif
ifneq (,$(findstring $(OPT_RESAMPLE), $(CFLAGS)))
	LDFLAGS += $(LINKALL_RESAMPLE)
endif
ifneq (,$(findstring $(OPT_IR), $(CFLAGS)))
	LDFLAGS += $(LINKALL_IR)
endif
else
# if not LINKALL and linux add LINK_LINUX
ifeq ($(UNAME), Linux)
	LDFLAGS += $(LINK_LINUX)
endif
endif

OBJECTS = $(SOURCES:.c=.o)

all: $(EXECUTABLE)

$(EXECUTABLE): $(OBJECTS)

	$(CC) $(OBJECTS) $(LDFLAGS) -o $@

$(OBJECTS): $(DEPS)

.c.o:

	$(CC) $(CFLAGS) $(CPPFLAGS) $< -c -o $@

clean:

	rm -f $(OBJECTS) $(EXECUTABLE)

=== end of squeezelite Makefile ====
============================================================
Hiroshi Kawashima

author
#5 lore raw

PATCH v12 1/1 squeezelite: new package

Dear, all.

Quoted 9 lines
Quoted 8 lines

Hmm...
I have been working on my cached source, so I did not realize it. Yes, I can reproduce your problem with real clean buildroot tree. Maybe something changed https://code.google.com/p/squeezelite repo since my last fetch.
I'm considering to change SQUEEZELITE_SITE to github repo like:
https://github.com/sixeyed/squeezelite
Does this repo work for you too ?

Quoted 9 lines

the fact that it works or not is not the problem. The problem is that right now there isn't any official repository for that project, so that repository could disappear tomorrow. And I don't know if the owner of that repository has made any change to the source code or not.

Perhaps downloading the tarballs from Google Code and putting them in mirror.buildroot.org would be the best option. I have added Peter and Thomas on CC so they can tell their opinion about this issue.

Of course, I know what is the essential problem, do not kidding me.

If buildroot can host it, I appreciate.

Quoted 55 lines

Hiroshi, there is one more little comment below; keep scrolling down.

Quoted 53 lines
Quoted 10 lines
Quoted 2 lines

I think I reflected all feedbacks except TARGET_CONFIGURE_OPTS issue. I'm not sure the right way to fix this, so would anyone suggest me?

TARGET_CONFIGURE_OPTS is a variable which defines PATH, CC, LD and more things. You can have a look at it in package/Makefile.in, line #247.

Instead of passing CC="$(TARGET_CC)" LD="$(TARGET_LD) to the make command, you could just pass $(TARGET_CONFIGURE_OPTS).

There is a comment at the end where I show you how to use it.

[snip]

Quoted 9 lines

package/squeezelite/squeezelite.mk line 35

Quoted 3 lines
package/squeezelite/squeezelite.mk new file +3 -0
+define SQUEEZELITE_BUILD_CMDS
+	$(TARGET_MAKE_ENV) $(MAKE) OPTS="$(SQUEEZELITE_MAKE_OPTS)" \
+		CC="$(TARGET_CC)" LD="$(TARGET_LD)" -C $(@D) all

Here is where you could use the $(TARGET_CONFIGURE_OPTS) variable:

	$(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) \
		OPTS="$(SQUEEZELITE_MAKE_OPTS)" -C $(@D) all
Quoted 6 lines

Perhaps using $(TARGET_CONFIGURE_OPTS) as environment variable would work as well, and since it also defines PATH, then $(TARGET_MAKE_ENV) wouldn't be needed:

	$(TARGET_CONFIGURE_OPTS) $(MAKE) \
		OPTS="$(SQUEEZELITE_MAKE_OPTS)" -C $(@D) all

Yes, I know basic usage of TARGET_CONFIGURE_OPTS as you explained, thanks.
But just changing like this does not work with squeezelite's Makefile. I included squeezelite's Makefile in last of this e-mail. It determines optional libraries to be linked, I choose libsoxr as example like this:
...
CFLAGS ?= -Wall -fPIC -O2 $(OPTS)
LDFLAGS ?= -lasound -lpthread -lm -lrt
...
OPT_RESAMPLE= -DRESAMPLE
...
LINKALL_RESAMPLE = -lsoxr
...
ifneq (,$(findstring $(OPT_RESAMPLE), $(CFLAGS)))

       LDFLAGS += $(LINKALL_RESAMPLE)
endif
...
$(EXECUTABLE): $(OBJECTS)
	$(CC) $(OBJECTS) $(LDFLAGS) -o $@
...
.c.o:
	$(CC) $(CFLAGS) $(CPPFLAGS) $< -c -o $@

...

Quoted 8 lines
Quoted 5 lines

But TARGET_CONFIGURE_OPTS override CFLAGS, LDFLAGS, etc. It results original Makefile logic does not work.
Can you suggest me right way (of buildroot) how to solve this ? How should I control final CFLAGS, LDFLAGS, etc from squeezelite.mk file ?

Well, if it doesn't work, then I guess is fine doing it by passing CC="$(TARGET_CC)" and LD="$(TARGET_LD)" as you already do.

Really, you accept it ?
Anyway it is not so easy anyway that keeping consistency with toolchains.

Kawashima

author
#6 lore raw

PATCH v12 1/1 squeezelite: new package

Dear, Thomas.

I deeply appreciate if you can technically suggest me about following. (from the view point of right root build way).

Regards,
Kawashima

Quoted 63 lines
Quoted 63 lines

Hiroshi, there is one more little comment below; keep scrolling down.

Quoted 51 lines
Quoted 10 lines
Quoted 2 lines

I think I reflected all feedbacks except TARGET_CONFIGURE_OPTS issue. I'm not sure the right way to fix this, so would anyone suggest me?

TARGET_CONFIGURE_OPTS is a variable which defines PATH, CC, LD and more things. You can have a look at it in package/Makefile.in, line #247.

Instead of passing CC="$(TARGET_CC)" LD="$(TARGET_LD) to the make command, you could just pass $(TARGET_CONFIGURE_OPTS).

There is a comment at the end where I show you how to use it.

[snip]

Quoted 9 lines

package/squeezelite/squeezelite.mk line 35

Quoted 3 lines
package/squeezelite/squeezelite.mk new file +3 -0
+define SQUEEZELITE_BUILD_CMDS
+	$(TARGET_MAKE_ENV) $(MAKE) OPTS="$(SQUEEZELITE_MAKE_OPTS)" \
+		CC="$(TARGET_CC)" LD="$(TARGET_LD)" -C $(@D) all

Here is where you could use the $(TARGET_CONFIGURE_OPTS) variable:

	$(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) \
		OPTS="$(SQUEEZELITE_MAKE_OPTS)" -C $(@D) all
Quoted 6 lines

Perhaps using $(TARGET_CONFIGURE_OPTS) as environment variable would work as well, and since it also defines PATH, then $(TARGET_MAKE_ENV) wouldn't be needed:

	$(TARGET_CONFIGURE_OPTS) $(MAKE) \
		OPTS="$(SQUEEZELITE_MAKE_OPTS)" -C $(@D) all

Yes, I know basic usage of TARGET_CONFIGURE_OPTS as you explained, thanks.
But just changing like this does not work with squeezelite's Makefile. I included squeezelite's Makefile in last of this e-mail. It determines optional libraries to be linked, I choose libsoxr as example like this:
...
CFLAGS ?= -Wall -fPIC -O2 $(OPTS)
LDFLAGS ?= -lasound -lpthread -lm -lrt
...
OPT_RESAMPLE= -DRESAMPLE
...
LINKALL_RESAMPLE = -lsoxr
...
ifneq (,$(findstring $(OPT_RESAMPLE), $(CFLAGS)))

      LDFLAGS += $(LINKALL_RESAMPLE)
endif
...
$(EXECUTABLE): $(OBJECTS)
	$(CC) $(OBJECTS) $(LDFLAGS) -o $@
...
.c.o:
	$(CC) $(CFLAGS) $(CPPFLAGS) $< -c -o $@
Quoted 7 lines

...

But TARGET_CONFIGURE_OPTS override CFLAGS, LDFLAGS, etc. It results original Makefile logic does not work.
Can you suggest me right way (of buildroot) how to solve this ? How should I control final CFLAGS, LDFLAGS, etc from squeezelite.mk file ?

Well, if it doesn't work, then I guess is fine doing it by passing CC="$(TARGET_CC)" and LD="$(TARGET_LD)" as you already do.

author
#7 lore raw

PATCH v12 1/1 squeezelite: new package

Sorry, s/root build/buildroot/

Quoted 77 lines · kei

Dear, Thomas.

I deeply appreciate if you can technically suggest me about following. (from the view point of right root build way).

Regards,
Kawashima

Quoted 55 lines
Quoted 55 lines

Hiroshi, there is one more little comment below; keep scrolling down.

Quoted 53 lines
Quoted 10 lines
Quoted 2 lines

I think I reflected all feedbacks except TARGET_CONFIGURE_OPTS issue. I'm not sure the right way to fix this, so would anyone suggest me?

TARGET_CONFIGURE_OPTS is a variable which defines PATH, CC, LD and more things. You can have a look at it in package/Makefile.in, line #247.

Instead of passing CC="$(TARGET_CC)" LD="$(TARGET_LD) to the make command, you could just pass $(TARGET_CONFIGURE_OPTS).

There is a comment at the end where I show you how to use it.

[snip]

Quoted 9 lines

package/squeezelite/squeezelite.mk line 35

Quoted 3 lines
package/squeezelite/squeezelite.mk new file +3 -0
+define SQUEEZELITE_BUILD_CMDS
+	$(TARGET_MAKE_ENV) $(MAKE) OPTS="$(SQUEEZELITE_MAKE_OPTS)" \
+		CC="$(TARGET_CC)" LD="$(TARGET_LD)" -C $(@D) all

Here is where you could use the $(TARGET_CONFIGURE_OPTS) variable:

	$(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) \
		OPTS="$(SQUEEZELITE_MAKE_OPTS)" -C $(@D) all
Quoted 6 lines

Perhaps using $(TARGET_CONFIGURE_OPTS) as environment variable would work as well, and since it also defines PATH, then $(TARGET_MAKE_ENV) wouldn't be needed:

	$(TARGET_CONFIGURE_OPTS) $(MAKE) \
		OPTS="$(SQUEEZELITE_MAKE_OPTS)" -C $(@D) all

Yes, I know basic usage of TARGET_CONFIGURE_OPTS as you explained, thanks.
But just changing like this does not work with squeezelite's Makefile. I included squeezelite's Makefile in last of this e-mail. It determines optional libraries to be linked, I choose libsoxr as example like this:
...
CFLAGS ?= -Wall -fPIC -O2 $(OPTS)
LDFLAGS ?= -lasound -lpthread -lm -lrt
...
OPT_RESAMPLE= -DRESAMPLE
...
LINKALL_RESAMPLE = -lsoxr
...
ifneq (,$(findstring $(OPT_RESAMPLE), $(CFLAGS)))

     LDFLAGS += $(LINKALL_RESAMPLE)
endif
...
$(EXECUTABLE): $(OBJECTS)
	$(CC) $(OBJECTS) $(LDFLAGS) -o $@
...
.c.o:
	$(CC) $(CFLAGS) $(CPPFLAGS) $< -c -o $@

...

Quoted 8 lines
Quoted 8 lines
Quoted 5 lines

But TARGET_CONFIGURE_OPTS override CFLAGS, LDFLAGS, etc. It results original Makefile logic does not work.
Can you suggest me right way (of buildroot) how to solve this ? How should I control final CFLAGS, LDFLAGS, etc from squeezelite.mk file ?

Well, if it doesn't work, then I guess is fine doing it by passing CC="$(TARGET_CC)" and LD="$(TARGET_LD)" as you already do.

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

author
#8 lore raw

PATCH v12 1/1 squeezelite: new package

In reply to kei

Thomas,

Anyway, please advise me what should I do next to be pulled to your trunk.

Kawashima

Quoted 79 lines

2015/09/26 0:07?kei <[email protected]> ?????

Dear, Thomas.

I deeply appreciate if you can technically suggest me about following. (from the view point of right root build way).

Regards,
Kawashima

Quoted 55 lines
Quoted 55 lines

Hiroshi, there is one more little comment below; keep scrolling down.

Quoted 53 lines
Quoted 10 lines
Quoted 2 lines

I think I reflected all feedbacks except TARGET_CONFIGURE_OPTS issue. I'm not sure the right way to fix this, so would anyone suggest me?

TARGET_CONFIGURE_OPTS is a variable which defines PATH, CC, LD and more things. You can have a look at it in package/Makefile.in, line #247.

Instead of passing CC="$(TARGET_CC)" LD="$(TARGET_LD) to the make command, you could just pass $(TARGET_CONFIGURE_OPTS).

There is a comment at the end where I show you how to use it.

[snip]

Quoted 9 lines

package/squeezelite/squeezelite.mk line 35

Quoted 3 lines
package/squeezelite/squeezelite.mk new file +3 -0
+define SQUEEZELITE_BUILD_CMDS
+	$(TARGET_MAKE_ENV) $(MAKE) OPTS="$(SQUEEZELITE_MAKE_OPTS)" \
+		CC="$(TARGET_CC)" LD="$(TARGET_LD)" -C $(@D) all

Here is where you could use the $(TARGET_CONFIGURE_OPTS) variable:

	$(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) \
		OPTS="$(SQUEEZELITE_MAKE_OPTS)" -C $(@D) all
Quoted 6 lines

Perhaps using $(TARGET_CONFIGURE_OPTS) as environment variable would work as well, and since it also defines PATH, then $(TARGET_MAKE_ENV) wouldn't be needed:

	$(TARGET_CONFIGURE_OPTS) $(MAKE) \
		OPTS="$(SQUEEZELITE_MAKE_OPTS)" -C $(@D) all

Yes, I know basic usage of TARGET_CONFIGURE_OPTS as you explained, thanks.
But just changing like this does not work with squeezelite's Makefile. I included squeezelite's Makefile in last of this e-mail. It determines optional libraries to be linked, I choose libsoxr as example like this:
...
CFLAGS ?= -Wall -fPIC -O2 $(OPTS)
LDFLAGS ?= -lasound -lpthread -lm -lrt
...
OPT_RESAMPLE= -DRESAMPLE
...
LINKALL_RESAMPLE = -lsoxr
...
ifneq (,$(findstring $(OPT_RESAMPLE), $(CFLAGS)))

     LDFLAGS += $(LINKALL_RESAMPLE)
endif
...
$(EXECUTABLE): $(OBJECTS)
	$(CC) $(OBJECTS) $(LDFLAGS) -o $@
...
.c.o:
	$(CC) $(CFLAGS) $(CPPFLAGS) $< -c -o $@

...

Quoted 8 lines
Quoted 8 lines
Quoted 5 lines

But TARGET_CONFIGURE_OPTS override CFLAGS, LDFLAGS, etc. It results original Makefile logic does not work.
Can you suggest me right way (of buildroot) how to solve this ? How should I control final CFLAGS, LDFLAGS, etc from squeezelite.mk file ?

Well, if it doesn't work, then I guess is fine doing it by passing CC="$(TARGET_CC)" and LD="$(TARGET_LD)" as you already do.

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

author
#9 lore raw

PATCH v12 1/1 squeezelite: new package

In reply to Vicente Olivert Riera

Dear, all.

If it is difficult to host it on buildroot, I can host it on my web site.

Please tell me which is preferred.

Regards,
Kawashima

Quoted 37 lines · Vicente Olivert Riera

Peter, Thomas, there is an issue commented below and I think it would be good to have your opinion on it.

Quoted 17 lines · On 09/25/2015 04:04 AM, kei-k at ca2.so-net.ne.jp wrote:

Dear, Vincente.

Thank you for your test and comment.

Quoted 4 lines · Vicente Olivert Riera

Dear Hiroshi Kawashima,

are you able to download squeezelite? I'm having this problem:

Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line

squeezelite v1.8 Downloading

Doing shallow clone
Initialized empty Git repository in /br/output/build/.squeezelite-v1.8.tar.gz.pb3XtQ/squeezelite-v1.8/
remote: Counting objects: 82, done.
Unpacking objects: 100% (82/82), done.
warning: Remote branch v1.8 not found in upstream origin, using HEAD instead
fatal: unable to read tree 668edec073bef579bedf43817f65aee3a592d0ef

Quoted 8 lines

Hmm...
I have been working on my cached source, so I did not realize it. Yes, I can reproduce your problem with real clean buildroot tree. Maybe something changed https://code.google.com/p/squeezelite repo since my last fetch.
I'm considering to change SQUEEZELITE_SITE to github repo like:
https://github.com/sixeyed/squeezelite
Does this repo work for you too ?

the fact that it works or not is not the problem. The problem is that right now there isn't any official repository for that project, so that repository could disappear tomorrow. And I don't know if the owner of that repository has made any change to the source code or not.

Perhaps downloading the tarballs from Google Code and putting them in mirror.buildroot.org would be the best option. I have added Peter and Thomas on CC so they can tell their opinion about this issue.

#10 lore raw

PATCH v12 1/1 squeezelite: new package

In reply to Vicente Olivert Riera

Hello,

Quoted 17 lines · Vicente Olivert Riera
Quoted 8 lines
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line

squeezelite v1.8 Downloading

Doing shallow clone
Initialized empty Git repository in /br/output/build/.squeezelite-v1.8.tar.gz.pb3XtQ/squeezelite-v1.8/
remote: Counting objects: 82, done.
Unpacking objects: 100% (82/82), done.
warning: Remote branch v1.8 not found in upstream origin, using HEAD instead
fatal: unable to read tree 668edec073bef579bedf43817f65aee3a592d0ef

Quoted 8 lines

Hmm...
I have been working on my cached source, so I did not realize it. Yes, I can reproduce your problem with real clean buildroot tree. Maybe something changed https://code.google.com/p/squeezelite repo since my last fetch.
I'm considering to change SQUEEZELITE_SITE to github repo like:
https://github.com/sixeyed/squeezelite
Does this repo work for you too ?

Quoted 8 lines

the fact that it works or not is not the problem. The problem is that right now there isn't any official repository for that project, so that repository could disappear tomorrow. And I don't know if the owner of that repository has made any change to the source code or not.

Perhaps downloading the tarballs from Google Code and putting them in mirror.buildroot.org would be the best option. I have added Peter and Thomas on CC so they can tell their opinion about this issue.

What do you want to do this instead of just using the Google Code tarballs? Yes, I know Google Code will disappear in the future, but right now, it works, and by the time it will be shut down, hopefully this project will have found a new hosting.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#11 lore raw

PATCH v12 1/1 squeezelite: new package

Hi Thomas,

Quoted 26 lines · Thomas Petazzoni

Hello,

Quoted 22 lines · Vicente Olivert Riera
Quoted 8 lines
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line

squeezelite v1.8 Downloading

Doing shallow clone
Initialized empty Git repository in /br/output/build/.squeezelite-v1.8.tar.gz.pb3XtQ/squeezelite-v1.8/
remote: Counting objects: 82, done.
Unpacking objects: 100% (82/82), done.
warning: Remote branch v1.8 not found in upstream origin, using HEAD instead
fatal: unable to read tree 668edec073bef579bedf43817f65aee3a592d0ef

Quoted 8 lines

Hmm...
I have been working on my cached source, so I did not realize it. Yes, I can reproduce your problem with real clean buildroot tree. Maybe something changed https://code.google.com/p/squeezelite repo since my last fetch.
I'm considering to change SQUEEZELITE_SITE to github repo like:
https://github.com/sixeyed/squeezelite
Does this repo work for you too ?

the fact that it works or not is not the problem. The problem is that right now there isn't any official repository for that project, so that repository could disappear tomorrow. And I don't know if the owner of that repository has made any change to the source code or not.

Quoted 8 lines
Quoted 3 lines

Perhaps downloading the tarballs from Google Code and putting them in mirror.buildroot.org would be the best option. I have added Peter and Thomas on CC so they can tell their opinion about this issue.

What do you want to do this instead of just using the Google Code tarballs? Yes, I know Google Code will disappear in the future, but right now, it works, and by the time it will be shut down, hopefully this project will have found a new hosting.

Because I don't see any tarball in Google Code which contains the sources. All I see are binary builds:

https://code.google.com/p/squeezelite/downloads/list?can=1&q=

Regards,

Vincent.

Quoted 3 lines

Thomas

#12 lore raw

PATCH v12 1/1 squeezelite: new package

Hi everyone,

Quoted 38 lines · Vicente Olivert Riera

Hi Thomas,

Quoted 26 lines · Thomas Petazzoni

Hello,

Quoted 22 lines · Vicente Olivert Riera
Quoted 8 lines
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line

squeezelite v1.8 Downloading

Doing shallow clone
Initialized empty Git repository in /br/output/build/.squeezelite-v1.8.tar.gz.pb3XtQ/squeezelite-v1.8/
remote: Counting objects: 82, done.
Unpacking objects: 100% (82/82), done.
warning: Remote branch v1.8 not found in upstream origin, using HEAD instead
fatal: unable to read tree 668edec073bef579bedf43817f65aee3a592d0ef

Quoted 8 lines

Hmm...
I have been working on my cached source, so I did not realize it. Yes, I can reproduce your problem with real clean buildroot tree. Maybe something changed https://code.google.com/p/squeezelite repo since my last fetch.
I'm considering to change SQUEEZELITE_SITE to github repo like:
https://github.com/sixeyed/squeezelite
Does this repo work for you too ?

the fact that it works or not is not the problem. The problem is that right now there isn't any official repository for that project, so that repository could disappear tomorrow. And I don't know if the owner of that repository has made any change to the source code or not.

Quoted 8 lines
Quoted 3 lines

Perhaps downloading the tarballs from Google Code and putting them in mirror.buildroot.org would be the best option. I have added Peter and Thomas on CC so they can tell their opinion about this issue.

What do you want to do this instead of just using the Google Code tarballs? Yes, I know Google Code will disappear in the future, but right now, it works, and by the time it will be shut down, hopefully this project will have found a new hosting.

Quoted 4 lines

Because I don't see any tarball in Google Code which contains the sources. All I see are binary builds:

https://code.google.com/p/squeezelite/downloads/list?can=1&q=

anyway, I think the git repo on Google Code started working again:

$ git clone https://code.google.com/p/squeezelite/
Initialized empty Git repository in /git-clones/squeezelite/.git/
remote: Counting objects: 845, done.
Receiving objects: 100% (845/845), 286.68 KiB, done.
Resolving deltas: 100% (570/570), done.
$

Regards,

Vincent.

Quoted 12 lines

Regards,

Vincent.

Quoted 3 lines

Thomas

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

author
#13 lore raw

PATCH v12 1/1 squeezelite: new package

Dear, Vincente.

Probably you are misunderstanding.
Full git clone is working, but shallow clone (of buildroot/support/download/git script) does not work for this repo.
That was pointed out by you, shallow clone does not work.
Try again make squeeze-source.

Kawashima

Quoted 71 lines · Vicente Olivert Riera

Hi everyone,

Quoted 38 lines · Vicente Olivert Riera

Hi Thomas,

Quoted 26 lines · Thomas Petazzoni

Hello,

Quoted 22 lines · Vicente Olivert Riera
Quoted 8 lines
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line

squeezelite v1.8 Downloading

Doing shallow clone
Initialized empty Git repository in /br/output/build/.squeezelite-v1.8.tar.gz.pb3XtQ/squeezelite-v1.8/
remote: Counting objects: 82, done.
Unpacking objects: 100% (82/82), done.
warning: Remote branch v1.8 not found in upstream origin, using HEAD instead
fatal: unable to read tree 668edec073bef579bedf43817f65aee3a592d0ef

Quoted 8 lines

Hmm...
I have been working on my cached source, so I did not realize it. Yes, I can reproduce your problem with real clean buildroot tree. Maybe something changed https://code.google.com/p/squeezelite repo since my last fetch.
I'm considering to change SQUEEZELITE_SITE to github repo like:
https://github.com/sixeyed/squeezelite
Does this repo work for you too ?

the fact that it works or not is not the problem. The problem is that right now there isn't any official repository for that project, so that repository could disappear tomorrow. And I don't know if the owner of that repository has made any change to the source code or not.

Quoted 8 lines
Quoted 3 lines

Perhaps downloading the tarballs from Google Code and putting them in mirror.buildroot.org would be the best option. I have added Peter and Thomas on CC so they can tell their opinion about this issue.

What do you want to do this instead of just using the Google Code tarballs? Yes, I know Google Code will disappear in the future, but right now, it works, and by the time it will be shut down, hopefully this project will have found a new hosting.

Quoted 4 lines

Because I don't see any tarball in Google Code which contains the sources. All I see are binary builds:

https://code.google.com/p/squeezelite/downloads/list?can=1&q=

anyway, I think the git repo on Google Code started working again:

$ git clone https://code.google.com/p/squeezelite/
Initialized empty Git repository in /git-clones/squeezelite/.git/
remote: Counting objects: 845, done.
Receiving objects: 100% (845/845), 286.68 KiB, done.
Resolving deltas: 100% (570/570), done.
$

Regards,

Vincent.

Quoted 12 lines

Regards,

Vincent.

Quoted 3 lines

Thomas

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

author
#14 lore raw

PATCH v12 1/1 squeezelite: new package

Sorry, s/squeeze-source/squeezelite-source/

Quoted 88 lines · kei

Dear, Vincente.

Probably you are misunderstanding.
Full git clone is working, but shallow clone (of buildroot/support/download/git script) does not work for this repo.
That was pointed out by you, shallow clone does not work.
Try again make squeeze-source.

Kawashima

Quoted 55 lines · Vicente Olivert Riera

Hi everyone,

Quoted 38 lines · Vicente Olivert Riera

Hi Thomas,

Quoted 26 lines · Thomas Petazzoni

Hello,

Quoted 22 lines · Vicente Olivert Riera
Quoted 8 lines
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line

squeezelite v1.8 Downloading

Doing shallow clone
Initialized empty Git repository in /br/output/build/.squeezelite-v1.8.tar.gz.pb3XtQ/squeezelite-v1.8/
remote: Counting objects: 82, done.
Unpacking objects: 100% (82/82), done.
warning: Remote branch v1.8 not found in upstream origin, using HEAD instead
fatal: unable to read tree 668edec073bef579bedf43817f65aee3a592d0ef

Quoted 8 lines

Hmm...
I have been working on my cached source, so I did not realize it. Yes, I can reproduce your problem with real clean buildroot tree. Maybe something changed https://code.google.com/p/squeezelite repo since my last fetch.
I'm considering to change SQUEEZELITE_SITE to github repo like:
https://github.com/sixeyed/squeezelite
Does this repo work for you too ?

the fact that it works or not is not the problem. The problem is that right now there isn't any official repository for that project, so that repository could disappear tomorrow. And I don't know if the owner of that repository has made any change to the source code or not.

Quoted 8 lines
Quoted 3 lines

Perhaps downloading the tarballs from Google Code and putting them in mirror.buildroot.org would be the best option. I have added Peter and Thomas on CC so they can tell their opinion about this issue.

What do you want to do this instead of just using the Google Code tarballs? Yes, I know Google Code will disappear in the future, but right now, it works, and by the time it will be shut down, hopefully this project will have found a new hosting.

Quoted 4 lines

Because I don't see any tarball in Google Code which contains the sources. All I see are binary builds:

https://code.google.com/p/squeezelite/downloads/list?can=1&q=

anyway, I think the git repo on Google Code started working again:

$ git clone https://code.google.com/p/squeezelite/
Initialized empty Git repository in /git-clones/squeezelite/.git/
remote: Counting objects: 845, done.
Receiving objects: 100% (845/845), 286.68 KiB, done.
Resolving deltas: 100% (570/570), done.
$
Quoted 16 lines

Regards,

Vincent.

Quoted 12 lines

Regards,

Vincent.

Quoted 3 lines

Thomas

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot