Skip to contentSkip to conversation

tile: fix build failure

PATCH In review Sudip Mukherjee 2 participants 3 messages Sep 7, 2015 – Sep 28, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tile: fix build failure

When building with allmodconfig the build was failing with the error:

arch/tile/kernel/usb.c:70:1: warning: data definition has no type or storage class [enabled by default] arch/tile/kernel/usb.c:70:1: error: type defaults to 'int' in declaration of 'arch_initcall' [-Werror=implicit-int] arch/tile/kernel/usb.c:70:1: warning: parameter names (without types) in function declaration [enabled by default] arch/tile/kernel/usb.c:63:19: warning: 'tilegx_usb_init' defined but not used [-Wunused-function]

Include linux/module.h to resolve the build failure.

---
 arch/tile/kernel/usb.c | 1 +
 1 file changed, 1 insertion(+)
arch/tile/kernel/usb.c +1 -0
index f0da5a2..9f1e05e 100644
@@ -22,6 +22,7 @@
 #include <linux/platform_device.h>
 #include <linux/usb/tilegx.h>
 #include <linux/init.h>
+#include <linux/module.h>
 #include <linux/types.h>
 
 static u64 ehci_dmamask = DMA_BIT_MASK(32);
Signature · 1 line
1.9.1
#1 lore raw
Quoted 7 lines · Sudip Mukherjee

When building with allmodconfig the build was failing with the error:

arch/tile/kernel/usb.c:70:1: warning: data definition has no type or storage class [enabled by default] arch/tile/kernel/usb.c:70:1: error: type defaults to 'int' in declaration of 'arch_initcall' [-Werror=implicit-int] arch/tile/kernel/usb.c:70:1: warning: parameter names (without types) in function declaration [enabled by default] arch/tile/kernel/usb.c:63:19: warning: 'tilegx_usb_init' defined but not used [-Wunused-function]

Quoted 6 lines

Include linux/module.h to resolve the build failure.

---
  arch/tile/kernel/usb.c | 1 +
  1 file changed, 1 insertion(+)

Thanks, taken into the tile tree.

Signature · 2 lines
Chris Metcalf, EZChip Semiconductor
http://www.ezchip.com
#2 lore raw
Quoted 8 lines · Chris Metcalf
Quoted 7 lines · Sudip Mukherjee

When building with allmodconfig the build was failing with the error:

arch/tile/kernel/usb.c:70:1: warning: data definition has no type or storage class [enabled by default] arch/tile/kernel/usb.c:70:1: error: type defaults to 'int' in declaration of 'arch_initcall' [-Werror=implicit-int] arch/tile/kernel/usb.c:70:1: warning: parameter names (without types) in function declaration [enabled by default] arch/tile/kernel/usb.c:63:19: warning: 'tilegx_usb_init' defined but not used [-Wunused-function]

Quoted 8 lines
Quoted 6 lines

Include linux/module.h to resolve the build failure.

---
 arch/tile/kernel/usb.c | 1 +
 1 file changed, 1 insertion(+)

Thanks, taken into the tile tree.

Hi,
I think it is still not sent to Linus. 4.3-rc3 also failed allmodconfig on tile and tilegx with same error.

regards
sudip