Staging: rts5208: Coding style warnings fix for block comments
PATCH 3/3 Staging: rts5208: Coding style warnings fix for block comments
This patch is to rtsx_chip.h that fixes up following warning reported by checkpatch.pl :
-Block comments use * on subsequent lines -Block comments use a trailing */ on a separate line
--- drivers/staging/rts5208/rtsx_chip.h | 66 +++++++++++++++++++++++-------------- 1 file changed, 42 insertions(+), 24 deletions(-)
drivers/staging/rts5208/rtsx_chip.h +42 -24
@@ -44,8 +44,10 @@#define MG_SET_ICV_SLOW /* HW may miss ERR/CMDNK signal when sampling INT status. */ #define MS_SAMPLE_INT_ERR -/* HW DO NOT support Wait_INT function during READ_BYTES -* transfer mode */ +/* +* HW DO NOT support Wait_INT function during READ_BYTES +* transfer mode +*/ #define READ_BYTES_WAIT_INT #endif
@@ -102,17 +104,19 @@#define TRANSPORT_ERROR 3/* Transport bad (i.e. device dead) */ -/*----------------------------------- -Start-Stop-Unit ------------------------------------*/ +/* ----------------------------------- +* Start-Stop-Unit +* ----------------------------------- +*/ #define STOP_MEDIUM 0x00/* access disable */ #define MAKE_MEDIUM_READY 0x01/* access enable */ #define UNLOAD_MEDIUM 0x02/* unload */ #define LOAD_MEDIUM 0x03/* load */ -/*----------------------------------- -STANDARD_INQUIRY ------------------------------------*/ +/* ----------------------------------- +* STANDARD_INQUIRY +* ----------------------------------- +*/ #define QULIFIRE 0x00#define AENC_FNC 0x00#define TRML_IOP 0x00
@@ -130,16 +134,24 @@/* Dynamic flag definitions: used in set_bit() etc. */ #define RTSX_FLIDX_TRANS_ACTIVE 18/* 0x00040000 transfer is active */ -#define RTSX_FLIDX_ABORTING 20/* 0x00100000 abort is in -* progress */ -#define RTSX_FLIDX_DISCONNECTING 21/* 0x00200000 disconnect -* in progress */ +#define RTSX_FLIDX_ABORTING 20/* +* 0x00100000 abort is in +* progress +*/ +#define RTSX_FLIDX_DISCONNECTING 21/* +* 0x00200000 disconnect +* in progress +*/ #define ABORTING_OR_DISCONNECTING ((1UL << US_FLIDX_ABORTING) | \ (1UL << US_FLIDX_DISCONNECTING)) -#define RTSX_FLIDX_RESETTING 22/* 0x00400000 device reset -* in progress */ -#define RTSX_FLIDX_TIMED_OUT 23/* 0x00800000 SCSI -* midlayer timed out */ +#define RTSX_FLIDX_RESETTING 22/* +* 0x00400000 device reset +* in progress +*/ +#define RTSX_FLIDX_TIMED_OUT 23/* +* 0x00800000 SCSI +* midlayer timed out +*/ #define DRCT_ACCESS_DEV 0x00/* Direct Access Device */ #define RMB_DISC 0x80/* The Device is Removable */
@@ -174,9 +186,10 @@#define FIRST_RESET 0x01#define USED_EXIST 0x02 -/*----------------------------------- -SENSE_DATA ------------------------------------*/ +/* ----------------------------------- +* SENSE_DATA +* ----------------------------------- +*/ /*---- valid ----*/ #define SENSE_VALID 0x80/* Sense data is valid as SCSI2 */ #define SENSE_INVALID 0x00/* Sense data is invalid as SCSI2 */
@@ -712,9 +725,12 @@ struct rtsx_chip {int cur_card;unsigned long need_release;/* need release bit map */ -unsigned long need_reset;/* need reset -* bit map */ -/* Flag to indicate that this card is just resumed from SS state, +unsigned long need_reset;/* +* need reset +* bit map +*/ +/* +* Flag to indicate that this card is just resumed from SS state, * and need released before being resetted */ unsigned long need_reinit;
@@ -732,8 +748,10 @@ struct rtsx_chip {u8 card_ejected;/* card ejected bit map */ u8 card_wp;/* card write protected bit map */ -u8 lun_mc;/* flag to indicate whether to answer -* MediaChange */ +u8 lun_mc;/* +* flag to indicate whether to answer +* MediaChange +*/ #ifndef LED_AUTO_BLINK int led_toggle_counter;
Signature · 1 line
2.5.2
Greg KH
maintainerQuoted 10 lines · Punit Vara
This patch is to
rtsx_chip.hthat fixes up following warning reported by checkpatch.pl :(quoted diff) +0
-2-Block comments use * on subsequent lines -Block comments use a trailing */ on a separate lineSigned-off-by Punit Vara <[email protected]>--- drivers/staging/rts5208/rtsx_chip.h | 66 +++++++++++++++++++++++-------------- 1 file changed, 42 insertions(+), 24 deletions(-)
Where is patch 1/3 and 2/3?
You have sent me almost 60 different patches, yet you gave me no idea what order to apply them in at all, what am I supposed to do with all of them?
Please redo all of your outstanding patches that I have not taken and resend them in a proper patch series, numbered correctly so that I have a chance to know what order to apply the. I've now purged my todo queue of all of your patches.
thanks,
greg k-h
Quoted 18 lines · Greg KH
Quoted 10 lines · Punit Vara
This patch is to
rtsx_chip.hthat fixes up following warning reported by checkpatch.pl :(quoted diff) +0
-2-Block comments use * on subsequent lines -Block comments use a trailing */ on a separate lineSigned-off-by Punit Vara <[email protected]>--- drivers/staging/rts5208/rtsx_chip.h | 66 +++++++++++++++++++++++-------------- 1 file changed, 42 insertions(+), 24 deletions(-)Where is patch 1/3 and 2/3?
You have sent me almost 60 different patches, yet you gave me no idea what order to apply them in at all, what am I supposed to do with all of them?
Quoted 8 lines
Please redo all of your outstanding patches that I have not taken and resend them in a proper patch series, numbered correctly so that I have a chance to know what order to apply the. I've now purged my todo queue of all of your patches.
thanks,
greg k-h
I will resend you all the patches whichever having block comment warnings as soon as I get some time.
Thanks !