Skip to contentSkip to conversation

libbluray: add optional fontconfig dependency

PATCH New Baruch Siach 2 participants 5 messages Sep 29, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 libbluray: add optional fontconfig dependency

Fixes:
http://autobuild.buildroot.net/results/dbf/dbfbf09f48e7ec09be34a3a40d3c859b74379eaf/
http://autobuild.buildroot.net/results/3fb/3fb9c077d4fe772774f53c7611b4dcbaad361312/
http://autobuild.buildroot.net/results/f9c/f9c1f3cf8bfa9eeacb7719459c22bdf7dea26ddb/

and more.

---
 package/libbluray/libbluray.mk | 6 ++++++
 1 file changed, 6 insertions(+)
package/libbluray/libbluray.mk +6 -0
index e10f7dbc8c73..f6a501a1083f 100644
@@ -24,6 +24,12 @@ else
 LIBBLURAY_CONF_OPTS += --without-freetype
 endif
 
+ifeq ($(BR2_PACKAGE_FONTCONFIG),y)
+LIBBLURAY_DEPENDENCIES += fontconfig
+else
+LIBBLURAY_CONF_OPTS += --without-fontconfig
+endif
+
 ifeq ($(BR2_PACKAGE_LIBXML2),y)
 LIBBLURAY_DEPENDENCIES += libxml2
 else
Signature · 1 line
2.5.3
#1 lore raw

PATCH 2/2 libbluray: disable BD-Java

BD-Java requires host-ant which is not currently available in Buildroot.

Fixes:
http://autobuild.buildroot.net/results/e87/e8790359cc12d73a22a168a61f59215e50a58f0f/
http://autobuild.buildroot.net/results/bb3/bb33effb844fd6c06efa033cc3e3cb4b4495d1d5/
http://autobuild.buildroot.net/results/623/623de2013eba2bff2d0863968e76f299488f9f35/

and more.

---
 package/libbluray/libbluray.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/libbluray/libbluray.mk +1 -1
index f6a501a1083f..2e9268ef29ac 100644
@@ -12,7 +12,7 @@ LIBBLURAY_LICENSE = LGPLv2.1+
 LIBBLURAY_LICENSE_FILES = COPYING
 LIBBLURAY_DEPENDENCIES = host-pkgconf
 
-LIBBLURAY_CONF_OPTS = --enable-udf
+LIBBLURAY_CONF_OPTS = --enable-udf --disable-bdjava
 
 ifeq ($(BR2_PACKAGE_LIBICONV),y)
 LIBBLURAY_DEPENDENCIES += libiconv
Signature · 1 line
2.5.3
#2 lore raw

PATCH 2/2 libbluray: disable BD-Java

Dear Baruch Siach,

Quoted 7 lines · Baruch Siach

BD-Java requires host-ant which is not currently available in Buildroot.

Fixes:
http://autobuild.buildroot.net/results/e87/e8790359cc12d73a22a168a61f59215e50a58f0f/
http://autobuild.buildroot.net/results/bb3/bb33effb844fd6c06efa033cc3e3cb4b4495d1d5/
http://autobuild.buildroot.net/results/623/623de2013eba2bff2d0863968e76f299488f9f35/

Quoted 7 lines

and more.

---
 package/libbluray/libbluray.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#3 lore raw

PATCH 1/2 libbluray: add optional fontconfig dependency

In reply to Baruch Siach

Baruch,

package/libbluray/libbluray.mk else · line 31

Quoted 13 lines · Baruch Siach
package/libbluray/libbluray.mk +5 -0
index e10f7dbc8c73..f6a501a1083f 100644
@@ -24,6 +24,12 @@ else
 LIBBLURAY_CONF_OPTS += --without-freetype
 endif
 
+ifeq ($(BR2_PACKAGE_FONTCONFIG),y)
+LIBBLURAY_DEPENDENCIES += fontconfig
+else
+LIBBLURAY_CONF_OPTS += --without-fontconfig
+endif

I would prefer to have an explicit --with-fontconfig when BR2_PACKAGE_FONTCONFIG=y. I know it's not the case for the other dependencies already handled by libbluray.mk, so I've applied your patch as is, and my comment can be fixed for all optional dependencies of libbluray in a separate patch.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#4 lore raw

PATCH 1/2 libbluray: add optional fontconfig dependency

Hi Thomas,

Quoted 10 lines · Thomas Petazzoni
Quoted 8 lines · Baruch Siach
package/libbluray/libbluray.mk +0 -0
index e10f7dbc8c73..f6a501a1083f 100644
@@ -24,6 +24,12 @@ else
 LIBBLURAY_CONF_OPTS += --without-freetype
 endif
 
Quoted 11 lines

package/libbluray/libbluray.mk else · line 31

Quoted 5 lines
package/libbluray/libbluray.mk +5 -0
+ifeq ($(BR2_PACKAGE_FONTCONFIG),y)
+LIBBLURAY_DEPENDENCIES += fontconfig
+else
+LIBBLURAY_CONF_OPTS += --without-fontconfig
+endif

I would prefer to have an explicit --with-fontconfig when BR2_PACKAGE_FONTCONFIG=y. I know it's not the case for the other dependencies already handled by libbluray.mk, so I've applied your patch as is, and my comment can be fixed for all optional dependencies of libbluray in a separate patch.

Just posted a patch for that.

Thanks,
baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -