Skip to contentSkip to conversation

Drivers: memory: atmel-sdramc: fixed character limit for a line

PATCH In review Shivani Bhardwaj 2 participants 2 messages Sep 29, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Drivers: memory: atmel-sdramc: fixed character limit for a line

Fixed the 80 character limit issue for a line.

---
 drivers/memory/atmel-sdramc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/memory/atmel-sdramc.c +2 -2
index a3ebc8a..fb156c8 100644
@@ -44,8 +44,8 @@ static const struct at91_ramc_caps sama5d3_caps = {
 static const struct of_device_id atmel_ramc_of_match[] = {
 	{ .compatible = "atmel,at91rm9200-sdramc", .data = &at91rm9200_caps, },
 	{ .compatible = "atmel,at91sam9260-sdramc", .data = &at91rm9200_caps, },
-	{ .compatible = "atmel,at91sam9g45-ddramc", .data = &at91sam9g45_caps, },
-	{ .compatible = "atmel,sama5d3-ddramc", .data = &sama5d3_caps, },
+	{ .compatible = "atmel,at91sam9g45-ddramc", .data = &at91sam9g45_caps, }
+	, { .compatible = "atmel,sama5d3-ddramc", .data = &sama5d3_caps, },
 	{},
 };
 MODULE_DEVICE_TABLE(of, atmel_ramc_of_match);
Signature · 1 line
2.1.0
#1 lore raw
Quoted 1 line · Shivani Bhardwaj

Fixed the 80 character limit issue for a line.

You should work on staging drivers. You can basically work on anything in the subdirectory drivers/staging.

For the subject line, people don't usually put drivers, but rather more specific things. You can see what is commonly used for the file you are working on by saying git log --oneline path/to/file.c.

Quoted 2 lines

This looks fine.

Quoted 9 lines
---
 drivers/memory/atmel-sdramc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/memory/atmel-sdramc.c +0 -0
index a3ebc8a..fb156c8 100644

drivers/memory/atmel-sdramc.c static const struct at91_ramc_caps sama5d3_caps = { · line 48

Quoted 7 lines
drivers/memory/atmel-sdramc.c +2 -2
@@ -44,8 +44,8 @@ static const struct at91_ramc_caps sama5d3_caps = {
 static const struct of_device_id atmel_ramc_of_match[] = {
 	{ .compatible = "atmel,at91rm9200-sdramc", .data = &at91rm9200_caps, },
 	{ .compatible = "atmel,at91sam9260-sdramc", .data = &at91rm9200_caps, },
-	{ .compatible = "atmel,at91sam9g45-ddramc", .data = &at91sam9g45_caps, },
-	{ .compatible = "atmel,sama5d3-ddramc", .data = &sama5d3_caps, },
+	{ .compatible = "atmel,at91sam9g45-ddramc", .data = &at91sam9g45_caps, }
+	, { .compatible = "atmel,sama5d3-ddramc", .data = &sama5d3_caps, },

This is not really the best solution to the problem, because it makes the line look quite different from the others. Maybe adding a newline would have been better.

julia

Quoted 13 lines
drivers/memory/atmel-sdramc.c +0 -0
 	{},
 };
 MODULE_DEVICE_TABLE(of, atmel_ramc_of_match);
Signature · 8 lines
2.1.0

-- 
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20150929211043.GA11379%40ubuntu.
For more options, visit https://groups.google.com/d/optout.