Skip to contentSkip to conversation

Disable CONFIG_UACCESS_WITH_MEMCPY in Atmel config.

PATCH New jc at eclis.ch 5 participants 8 messages Sep 29, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Disable CONFIG_UACCESS_WITH_MEMCPY in Atmel config.

From: Jean-Christian de Rivaz <[email protected]>

According to Russell King:
In any case, unless you have a Marvell platform, you should have this disabled - it provides a performance boost for Marvell platforms, but degrades performance everywhere else. Please ensure that you disable CONFIG_UACCESS_WITH_MEMCPY.

---
 arch/arm/configs/at91_dt_defconfig |    2 +-
 arch/arm/configs/sama5_defconfig   |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/configs/at91_dt_defconfig +1 -1
index 090c5b2..1807d7f 100644
@@ -21,7 +21,7 @@ CONFIG_SOC_SAM_V4_V5=y
 CONFIG_SOC_AT91RM9200=y
 CONFIG_SOC_AT91SAM9=y
 CONFIG_AEABI=y
-CONFIG_UACCESS_WITH_MEMCPY=y
+# CONFIG_UACCESS_WITH_MEMCPY is not set
 CONFIG_ZBOOT_ROM_TEXT=0x0
 CONFIG_ZBOOT_ROM_BSS=0x0
 CONFIG_ARM_APPENDED_DTB=y
arch/arm/configs/sama5_defconfig +1 -1
index 31eb951..471e214 100644
@@ -19,7 +19,7 @@ CONFIG_SOC_SAM_V7=y
 CONFIG_SOC_SAMA5D3=y
 CONFIG_SOC_SAMA5D4=y
 CONFIG_AEABI=y
-CONFIG_UACCESS_WITH_MEMCPY=y
+# CONFIG_UACCESS_WITH_MEMCPY is not set
 CONFIG_ZBOOT_ROM_TEXT=0x0
 CONFIG_ZBOOT_ROM_BSS=0x0
 CONFIG_ARM_APPENDED_DTB=y
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 Disable CONFIG_UACCESS_WITH_MEMCPY in Atmel config.

Quoted 9 lines · jc at eclis.ch

From: Jean-Christian de Rivaz <[email protected]>

According to Russell King:
In any case, unless you have a Marvell platform, you should have this disabled - it provides a performance boost for Marvell platforms, but degrades performance everywhere else. Please ensure that you disable CONFIG_UACCESS_WITH_MEMCPY.

Quoted 35 lines
---
 arch/arm/configs/at91_dt_defconfig |    2 +-
 arch/arm/configs/sama5_defconfig   |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/configs/at91_dt_defconfig +1 -1
index 090c5b2..1807d7f 100644
@@ -21,7 +21,7 @@ CONFIG_SOC_SAM_V4_V5=y
 CONFIG_SOC_AT91RM9200=y
 CONFIG_SOC_AT91SAM9=y
 CONFIG_AEABI=y
-CONFIG_UACCESS_WITH_MEMCPY=y
+# CONFIG_UACCESS_WITH_MEMCPY is not set
 CONFIG_ZBOOT_ROM_TEXT=0x0
 CONFIG_ZBOOT_ROM_BSS=0x0
 CONFIG_ARM_APPENDED_DTB=y
arch/arm/configs/sama5_defconfig +1 -1
index 31eb951..471e214 100644
@@ -19,7 +19,7 @@ CONFIG_SOC_SAM_V7=y
 CONFIG_SOC_SAMA5D3=y
 CONFIG_SOC_SAMA5D4=y
 CONFIG_AEABI=y
-CONFIG_UACCESS_WITH_MEMCPY=y
+# CONFIG_UACCESS_WITH_MEMCPY is not set
 CONFIG_ZBOOT_ROM_TEXT=0x0
 CONFIG_ZBOOT_ROM_BSS=0x0
 CONFIG_ARM_APPENDED_DTB=y
Signature · 1 line
1.7.10.4
#2 lore raw

PATCH 1/1 Disable CONFIG_UACCESS_WITH_MEMCPY in Atmel config.

In reply to jc at eclis.ch

Hello,

Quoted 19 lines · jc at eclis.ch

From: Jean-Christian de Rivaz <[email protected]>

According to Russell King:
In any case, unless you have a Marvell platform, you should have this disabled - it provides a performance boost for Marvell platforms, but degrades performance everywhere else. Please ensure that you disable CONFIG_UACCESS_WITH_MEMCPY.

---
 arch/arm/configs/at91_dt_defconfig |    2 +-
 arch/arm/configs/sama5_defconfig   |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/configs/at91_dt_defconfig +0 -0
index 090c5b2..1807d7f 100644

arch/arm/configs/at91_dt_defconfig CONFIG_SOC_SAM_V4_V5=y · line 27

Quoted 8 lines
arch/arm/configs/at91_dt_defconfig +1 -1
@@ -21,7 +21,7 @@ CONFIG_SOC_SAM_V4_V5=y
 CONFIG_SOC_AT91RM9200=y
 CONFIG_SOC_AT91SAM9=y
 CONFIG_AEABI=y
-CONFIG_UACCESS_WITH_MEMCPY=y
+# CONFIG_UACCESS_WITH_MEMCPY is not set
 CONFIG_ZBOOT_ROM_TEXT=0x0
 CONFIG_ZBOOT_ROM_BSS=0x0
 CONFIG_ARM_APPENDED_DTB=y

What is the reason to add the "# ... is not set" line? Given the default line of UACCESS_WITH_MEMCPY I suggest to just drop the line without replacement in the defconfigs.

Best regards
Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
#3 lore raw

PATCH 1/1 Disable CONFIG_UACCESS_WITH_MEMCPY in Atmel config.

Le 29. 09. 15 22:35, Uwe Kleine-K?nig a ?crit :

Quoted 17 lines

Hello,

Quoted 14 lines · jc at eclis.ch

From: Jean-Christian de Rivaz <[email protected]>

According to Russell King:
In any case, unless you have a Marvell platform, you should have this disabled - it provides a performance boost for Marvell platforms, but degrades performance everywhere else. Please ensure that you disable CONFIG_UACCESS_WITH_MEMCPY.

---
  arch/arm/configs/at91_dt_defconfig |    2 +-
  arch/arm/configs/sama5_defconfig   |    2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)
Quoted 17 lines

arch/arm/configs/at91_dt_defconfig CONFIG_SOC_SAM_V4_V5=y · line 27

Quoted 13 lines
arch/arm/configs/at91_dt_defconfig +1 -1
index 090c5b2..1807d7f 100644
@@ -21,7 +21,7 @@ CONFIG_SOC_SAM_V4_V5=y
  CONFIG_SOC_AT91RM9200=y
  CONFIG_SOC_AT91SAM9=y
  CONFIG_AEABI=y
-CONFIG_UACCESS_WITH_MEMCPY=y
+# CONFIG_UACCESS_WITH_MEMCPY is not set
  CONFIG_ZBOOT_ROM_TEXT=0x0
  CONFIG_ZBOOT_ROM_BSS=0x0
  CONFIG_ARM_APPENDED_DTB=y

What is the reason to add the "# ... is not set" line? Given the default line of UACCESS_WITH_MEMCPY I suggest to just drop the line without replacement in the defconfigs.

Hi Uwe,

Without the explicit disabling, the user will be asked and could possibly give the wrong answer as the help look as a cool feature and the condition is very hard to understand.

Regards,
Jean-Christian

#4 lore raw

PATCH 1/1 Disable CONFIG_UACCESS_WITH_MEMCPY in Atmel config.

Hi,

Quoted 4 lines · Jean-Christian de Rivaz

Without the explicit disabling, the user will be asked and could possibly give the wrong answer as the help look as a cool feature and the condition is very hard to understand.

That is not true, if you remove it from the defconfig, it will simply be disabled in the final config.

Moreover, I would prefer a better commit message than "Russell said so"

Signature · 3 lines
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#5 lore raw

PATCH 1/1 Disable CONFIG_UACCESS_WITH_MEMCPY in Atmel config.

Quoted 8 lines · Alexandre Belloni

Hi,

Quoted 4 lines · Jean-Christian de Rivaz

Without the explicit disabling, the user will be asked and could possibly give the wrong answer as the help look as a cool feature and the condition is very hard to understand.

Quoted 4 lines

That is not true, if you remove it from the defconfig, it will simply be disabled in the final config.

Moreover, I would prefer a better commit message than "Russell said so"

Well, if people are going to take that kind of attitude, then I'm not going to bother fixing it at all. I've got better things to do than chase after bugs in almost unused code and code which people shouldn't be enabling on their platforms.

It's not "Russell said so" but "Nicolas, the author of the code, said so." I'm merely passing the information along. Search the archives if you don't believe me, it's been discussed in the last couple of months, including potentially removing this code.

I regard this code as a maintanence burden, one that I personally can do without.

Signature · 2 lines
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
#6 lore raw

PATCH 1/1 Disable CONFIG_UACCESS_WITH_MEMCPY in Atmel config.

Quoted 19 lines · Russell King - ARM Linux
Quoted 8 lines · Alexandre Belloni

Hi,

Quoted 4 lines · Jean-Christian de Rivaz

Without the explicit disabling, the user will be asked and could possibly give the wrong answer as the help look as a cool feature and the condition is very hard to understand.

Quoted 4 lines

That is not true, if you remove it from the defconfig, it will simply be disabled in the final config.

Moreover, I would prefer a better commit message than "Russell said so"

Well, if people are going to take that kind of attitude, then I'm not going to bother fixing it at all. I've got better things to do than chase after bugs in almost unused code and code which people shouldn't be enabling on their platforms.

Quoted 8 lines

It's not "Russell said so" but "Nicolas, the author of the code, said so." I'm merely passing the information along. Search the archives if you don't believe me, it's been discussed in the last couple of months, including potentially removing this code.

I regard this code as a maintanence burden, one that I personally can do without.

Come on, I never said it was not worth fixing, I'm just saying the commit message doesn't carry the proper explanation. I would prefer something a bit more technical.
A better commit message could point to the discussion you are referring to for example so that the maintainers (btw they are not in copy) don't have to look it up themselves.

Signature · 3 lines
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#7 lore raw

PATCH 1/1 Disable CONFIG_UACCESS_WITH_MEMCPY in Atmel config.

Quoted 29 lines · Alexandre Belloni
Quoted 19 lines · Russell King - ARM Linux
Quoted 8 lines · Alexandre Belloni

Hi,

Quoted 4 lines · Jean-Christian de Rivaz

Without the explicit disabling, the user will be asked and could possibly give the wrong answer as the help look as a cool feature and the condition is very hard to understand.

Quoted 4 lines

That is not true, if you remove it from the defconfig, it will simply be disabled in the final config.

Moreover, I would prefer a better commit message than "Russell said so"

Well, if people are going to take that kind of attitude, then I'm not going to bother fixing it at all. I've got better things to do than chase after bugs in almost unused code and code which people shouldn't be enabling on their platforms.

Quoted 8 lines

It's not "Russell said so" but "Nicolas, the author of the code, said so." I'm merely passing the information along. Search the archives if you don't believe me, it's been discussed in the last couple of months, including potentially removing this code.

I regard this code as a maintanence burden, one that I personally can do without.

Quoted 6 lines

Come on, I never said it was not worth fixing, I'm just saying the commit message doesn't carry the proper explanation. I would prefer something a bit more technical.
A better commit message could point to the discussion you are referring to for example so that the maintainers (btw they are not in copy) don't have to look it up themselves.

FYI: here is the thread:

http://article.gmane.org/gmane.linux.ports.arm.kernel/433489

Nicolas