Disable CONFIG_UACCESS_WITH_MEMCPY in Atmel config.
Subsystems (2)
PATCH 1/1 Disable CONFIG_UACCESS_WITH_MEMCPY in Atmel config.
From: Jean-Christian de Rivaz <[email protected]>
According to Russell King:
In any case, unless you have a Marvell platform, you should have this disabled - it provides a performance boost for Marvell platforms, but degrades performance everywhere else. Please ensure that you disable CONFIG_UACCESS_WITH_MEMCPY.
--- arch/arm/configs/at91_dt_defconfig | 1 - arch/arm/configs/sama5_defconfig | 1 - 2 files changed, 2 deletions(-)
arch/arm/configs/at91_dt_defconfig +0 -1
@@ -21,7 +21,6 @@ CONFIG_SOC_SAM_V4_V5=y CONFIG_SOC_AT91RM9200=y CONFIG_SOC_AT91SAM9=y CONFIG_AEABI=y -CONFIG_UACCESS_WITH_MEMCPY=y CONFIG_ZBOOT_ROM_TEXT=0x0 CONFIG_ZBOOT_ROM_BSS=0x0 CONFIG_ARM_APPENDED_DTB=y
arch/arm/configs/sama5_defconfig +0 -1
@@ -19,7 +19,6 @@ CONFIG_SOC_SAM_V7=y CONFIG_SOC_SAMA5D3=y CONFIG_SOC_SAMA5D4=y CONFIG_AEABI=y -CONFIG_UACCESS_WITH_MEMCPY=y CONFIG_ZBOOT_ROM_TEXT=0x0 CONFIG_ZBOOT_ROM_BSS=0x0 CONFIG_ARM_APPENDED_DTB=y
Signature · 1 line
1.7.10.4
PATCH 1/1 Disable CONFIG_UACCESS_WITH_MEMCPY in Atmel config.
Hello,
Quoted 9 lines · jc at eclis.ch
From: Jean-Christian de Rivaz <[email protected]>
According to Russell King:
In any case, unless you have a Marvell platform, you should have this disabled - it provides a performance boost for Marvell platforms, but degrades performance everywhere else. Please ensure that you disableCONFIG_UACCESS_WITH_MEMCPY.Signed-off-by Jean-Christian de Rivaz <[email protected]>
the change is fine now. Feel free to add my Ack also if you do another round to improve the changelog.
Best regards
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |
PATCH 1/1 Disable CONFIG_UACCESS_WITH_MEMCPY in Atmel config.
Le 30. 09. 15 08:10, Uwe Kleine-K?nig a ?crit :
Quoted 11 lines
Hello,
Quoted 8 lines · jc at eclis.ch
From: Jean-Christian de Rivaz <[email protected]>
According to Russell King:
In any case, unless you have a Marvell platform, you should have this disabled - it provides a performance boost for Marvell platforms, but degrades performance everywhere else. Please ensure that you disableCONFIG_UACCESS_WITH_MEMCPY.
Quoted 7 lines
Quoted 1 line
Signed-off-by Jean-Christian de Rivaz <[email protected]>the change is fine now. Feel free to add my Ack also if you do another round to improve the changelog.
Best regards
Uwe
Thanks Uwe,
Nicolas and Russell, for my own curiosity I tested the difference on this system:
# cat /proc/cpuinfo processor : 0 model name : ARMv7 Processor rev 1 (v7l) BogoMIPS : 348.97 Features : half thumb fastmult vfp edsp vfpv3 vfpv3d16 tls vfpv4 CPU implementer : 0x41 CPU architecture: 7 CPU variant : 0x0 CPU part : 0xc05 CPU revision : 1
Hardware : Atmel SAMA5
Revision : 0000
Serial : 0000000000000000
# dd if=/dev/zero of=/dev/null bs=4k count=1M
Take about 10 seconds to complete on this system and report the following speed in MB/s in 10 rounds:
CONFIG_UACCESS_WITH_MEMCPY=y
470, 419, 440, 446, 434, 437, 418, 412, 431, 437
# CONFIG_UACCESS_WITH_MEMCPY disabled is not set
387, 387, 382, 383, 385, 388, 387, 387, 384, 386
So It look like this feature still give some advantage on system other than Orion CPU core. I still propose my patch to disable it until it's rock stable as it used to be a least with the kernel 3.19.0.
Regards,
Jean-Christian