Skip to contentSkip to conversation

drm/exynos: dp: remove suspend/resume functions

PATCH In review Inki Dae 3 participants 5 messages Sep 30, 2015

Subsystems (4)
lore
Share & tools
lore

Inki Dae

author maintainer
#0 lore raw

PATCH 1/1 drm/exynos: dp: remove suspend/resume functions

This patch removes unnecessary pm suspend/resume functions.

All kms sub drivers will be controlled by top of Exynos drm driver and connector dpms so these sub drivers shouldn't have their own pm interfaces.

---
 drivers/gpu/drm/exynos/exynos_dp_core.c | 23 -----------------------
 1 file changed, 23 deletions(-)
drivers/gpu/drm/exynos/exynos_dp_core.c +0 -23
index d66ade0..124fb9a 100644
@@ -1383,28 +1383,6 @@ static int exynos_dp_remove(struct platform_device *pdev)
 	return 0;
 }
 
-#ifdef CONFIG_PM_SLEEP
-static int exynos_dp_suspend(struct device *dev)
-{
-	struct exynos_dp_device *dp = dev_get_drvdata(dev);
-
-	exynos_dp_disable(&dp->encoder);
-	return 0;
-}
-
-static int exynos_dp_resume(struct device *dev)
-{
-	struct exynos_dp_device *dp = dev_get_drvdata(dev);
-
-	exynos_dp_enable(&dp->encoder);
-	return 0;
-}
-#endif
-
-static const struct dev_pm_ops exynos_dp_pm_ops = {
-	SET_SYSTEM_SLEEP_PM_OPS(exynos_dp_suspend, exynos_dp_resume)
-};
-
 static const struct of_device_id exynos_dp_match[] = {
 	{ .compatible = "samsung,exynos5-dp" },
 	{},
@@ -1417,7 +1395,6 @@ struct platform_driver dp_driver = {
 	.driver		= {
 		.name	= "exynos-dp",
 		.owner	= THIS_MODULE,
-		.pm	= &exynos_dp_pm_ops,
 		.of_match_table = exynos_dp_match,
 	},
 };
Signature · 1 line
1.9.1
#1 lore raw

Hi Inki,

Quoted 6 lines · Inki Dae

This patch removes unnecessary pm suspend/resume functions.

All kms sub drivers will be controlled by top of Exynos drm driver and connector dpms so these sub drivers shouldn't have their own pm interfaces.

Not sure if you've noticed but this patch seems to do the opposite of what Gustavo was aiming with an earlier series [1].

Cheers,
Emil

[1] http://lists.freedesktop.org/archives/dri-devel/2015-September/089800.html
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel

author maintainer
#2 lore raw

Hi Emil,

Quoted 11 lines · Emil Velikov

Hi Inki,

Quoted 6 lines · Inki Dae

This patch removes unnecessary pm suspend/resume functions.

All kms sub drivers will be controlled by top of Exynos drm driver and connector dpms so these sub drivers shouldn't have their own pm interfaces.

Not sure if you've noticed but this patch seems to do the opposite of what Gustavo was aiming with an earlier series [1].

I removed just the interfaces related to sleep pm not runtime pm. From long ago, Linux DRM drivers - especially ARM DRM drivers - have been stepping forward to a integrated DRM driver so it'd be reasonable for sleep pm operations of all KMS drivers are controlled by top of DRM driver. It means that Exynos drm driver has already sleep pm interfaces.

However, I think a power domain of each kms device couldn't be controlled by the top in case of ARM SoC because kms devices can use a different power domain each other according to Vendor SoC so runtime pm should be controlled by each kms driver, which will be triggered by DRM top.

And Gustavo's patch set you mentioned - now being reviewed - will add only runtime pm interfaces to each kms driver.

Thanks,
Inki Dae

Quoted 10 lines

Cheers,
Emil

[1] http://lists.freedesktop.org/archives/dri-devel/2015-September/089800.html
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel

#3 lore raw
Quoted 21 lines · Inki Dae

Hi Emil,

Quoted 11 lines · Emil Velikov

Hi Inki,

Quoted 6 lines · Inki Dae

This patch removes unnecessary pm suspend/resume functions.

All kms sub drivers will be controlled by top of Exynos drm driver and connector dpms so these sub drivers shouldn't have their own pm interfaces.

Not sure if you've noticed but this patch seems to do the opposite of what Gustavo was aiming with an earlier series [1].

I removed just the interfaces related to sleep pm not runtime pm. From long ago, Linux DRM drivers - especially ARM DRM drivers - have been stepping forward to a integrated DRM driver so it'd be reasonable for sleep pm operations of all KMS drivers are controlled by top of DRM driver. It means that Exynos drm driver has already sleep pm interfaces.

Quoted 8 lines

However, I think a power domain of each kms device couldn't be controlled by the top in case of ARM SoC because kms devices can use a different power domain each other according to Vendor SoC so runtime pm should be controlled by each kms driver, which will be triggered by DRM top.

And Gustavo's patch set you mentioned - now being reviewed - will add only runtime pm interfaces to each kms driver.

Ack. Seems like I misread your patch. Thank you for the comprehensive answer and apologies for the noise.

Thanks
Emil

Reviewed-by on v1 1/1
#4 lore raw
In reply to Inki Dae

Hi Inki,

2015-09-30 Inki Dae <[email protected]>:

Quoted 10 lines

This patch removes unnecessary pm suspend/resume functions.

All kms sub drivers will be controlled by top of Exynos drm driver and connector dpms so these sub drivers shouldn't have their own pm interfaces.

---
 drivers/gpu/drm/exynos/exynos_dp_core.c | 23 -----------------------
 1 file changed, 23 deletions(-)

This sounds reasonable to me.

Gustavo