Skip to contentSkip to conversation

Staging: lustre: ptlrpc: nrs_fifo: Removed an unused structure

PATCH In review Shivani Bhardwaj 2 participants 2 messages Oct 1, 2015 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: lustre: ptlrpc: nrs_fifo: Removed an unused structure

Removed a structure "nrs_conf_fifo" because it was not called/referenced in the entire code.

---
 drivers/staging/lustre/lustre/ptlrpc/nrs_fifo.c | 7 -------
 1 file changed, 7 deletions(-)
drivers/staging/lustre/lustre/ptlrpc/nrs_fifo.c +0 -7
index 8e21f0c..6be1adb 100644
@@ -259,13 +259,6 @@ static const struct ptlrpc_nrs_pol_ops nrs_fifo_ops = {
 /**
  * FIFO policy configuration
  */
-struct ptlrpc_nrs_pol_conf nrs_conf_fifo = {
-	.nc_name		= NRS_POL_NAME_FIFO,
-	.nc_ops			= &nrs_fifo_ops,
-	.nc_compat		= nrs_policy_compat_all,
-	.nc_flags		= PTLRPC_NRS_FL_FALLBACK |
-				  PTLRPC_NRS_FL_REG_START
-};
 
 /** @} fifo */
 
Signature · 1 line
2.1.0
#1 lore raw
Quoted 2 lines · Shivani Bhardwaj

Removed a structure "nrs_conf_fifo" because it was not called/referenced in the entire code.

It is called in the file drivers/staging/lustre/lustre/ptlrpc/nrs.c.

Here: http://lxr.free-electrons.com/source/drivers/staging/lustre/lustre/ptlrpc/nrs.c#L1719

Please check with 'git grep' when you are doing such changes. I think compiler should have warned you about the same.

Quoted 32 lines
---
 drivers/staging/lustre/lustre/ptlrpc/nrs_fifo.c | 7 -------
 1 file changed, 7 deletions(-)
drivers/staging/lustre/lustre/ptlrpc/nrs_fifo.c +0 -8
index 8e21f0c..6be1adb 100644
@@ -259,13 +259,6 @@ static const struct ptlrpc_nrs_pol_ops nrs_fifo_ops = {
 /**
  * FIFO policy configuration
  */
-struct ptlrpc_nrs_pol_conf nrs_conf_fifo = {
-       .nc_name                = NRS_POL_NAME_FIFO,
-       .nc_ops                 = &nrs_fifo_ops,
-       .nc_compat              = nrs_policy_compat_all,
-       .nc_flags               = PTLRPC_NRS_FL_FALLBACK |
-                                 PTLRPC_NRS_FL_REG_START
-};
 
 /** @} fifo */
 
--

2.1.0

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20151001074538.GA39335%40ubuntu.
For more options, visit https://groups.google.com/d/optout.

Signature · 1 line
Vaishali