Skip to contentSkip to conversation

package/kodi-pvr-argustv: add jsoncpp reverse dependency

PATCH Superseded Bernd Kuhls 2 participants 5 messages Oct 1, 2015

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Bernd Kuhls

author
#0 lore raw

PATCH 1/3 package/kodi-pvr-argustv: add jsoncpp reverse dependency

Signed-off-by Bernd Kuhls <[email protected]>
---
 package/kodi-pvr-argustv/Config.in | 4 ++++
 1 file changed, 4 insertions(+)
package/kodi-pvr-argustv/Config.in +4 -0
index 698ff46..ad27c38 100644
@@ -1,7 +1,11 @@
 config BR2_PACKAGE_KODI_PVR_ARGUSTV
 	bool "kodi-pvr-argustv"
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 # jsoncpp
 	select BR2_PACKAGE_KODI_PLATFORM
 	help
 	  Kodi's ARGUS TV client addon
 
 	  https://github.com/kodi-pvr/pvr.argustv
+
+comment "kodi-pvr-argustv needs a toolchain w/ C++, gcc >= 4.7"
+	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_4_7
Signature · 1 line
2.5.3
author
#1 lore raw

PATCH 2/3 package/kodi-pvr-filmon: add jsoncpp reverse dependency

Signed-off-by Bernd Kuhls <[email protected]>
---
 package/kodi-pvr-filmon/Config.in | 4 ++++
 1 file changed, 4 insertions(+)
package/kodi-pvr-filmon/Config.in +4 -0
index 0b662df..a10b322 100644
@@ -1,8 +1,12 @@
 config BR2_PACKAGE_KODI_PVR_FILMON
 	bool "kodi-pvr-filmon"
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 # jsoncpp
 	select BR2_PACKAGE_JSONCPP
 	select BR2_PACKAGE_KODI_PLATFORM
 	help
 	  Filmon PVR client addon for Kodi
 
 	  https://github.com/kodi-pvr/pvr.filmon
+
+comment "kodi-pvr-filmon needs a toolchain w/ C++, gcc >= 4.7"
+	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_4_7
Signature · 1 line
2.5.3
author
#2 lore raw

PATCH 3/3 package/kodi-pvr-pctv: add jsoncpp reverse dependency

In reply to Bernd Kuhls
Signed-off-by Bernd Kuhls <[email protected]>
---
 package/kodi-pvr-pctv/Config.in | 4 ++++
 1 file changed, 4 insertions(+)
package/kodi-pvr-pctv/Config.in +4 -0
index 255cd4a..a6210f6 100644
@@ -1,8 +1,12 @@
 config BR2_PACKAGE_KODI_PVR_PCTV
 	bool "kodi-pvr-pctv"
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 # jsoncpp
 	select BR2_PACKAGE_JSONCPP
 	select BR2_PACKAGE_KODI_PLATFORM
 	help
 	  PCTV PVR client addon for Kodi
 
 	  https://github.com/kodi-pvr/pvr.vdr.vnsi
+
+comment "kodi-pvr-pctv needs a toolchain w/ C++, gcc >= 4.7"
+	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_4_7
Signature · 1 line
2.5.3
#3 lore raw

PATCH 1/3 package/kodi-pvr-argustv: add jsoncpp reverse dependency

In reply to Bernd Kuhls

Hi Bernd,

package/kodi-pvr-argustv/Config.in line 3

Quoted 9 lines · Bernd Kuhls
package/kodi-pvr-argustv/Config.in +1 -0
index 698ff46..ad27c38 100644
@@ -1,7 +1,11 @@
 config BR2_PACKAGE_KODI_PVR_ARGUSTV
 	bool "kodi-pvr-argustv"
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 # jsoncpp

Why is that needed? Same for other patches in this series.

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
author
#4 lore raw

PATCH 1/3 package/kodi-pvr-argustv: add jsoncpp reverse dependency

Am Thu, 01 Oct 2015 23:29:35 +0300 schrieb Baruch Siach:

Quoted 5 lines

package/kodi-pvr-argustv/Config.in line 3

Quoted 3 lines

config BR2_PACKAGE_KODI_PVR_ARGUSTV

package/kodi-pvr-argustv/Config.in +1 -0
 	bool "kodi-pvr-argustv"
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 # jsoncpp

Why is that needed? Same for other patches in this series.

Hi Baruch,

the three pvr packages depend on jsoncpp, this is reflected in the .mk files and also in Config.in with the exception of kodi-pvr-argustv, where that select-line was missing, so I sent v2:
http://patchwork.ozlabs.org/patch/525299/

All packages lacked the rev dependency to gcc-4.7.

Regards, Bernd