Skip to contentSkip to conversation

package/kodi-pvr-stalker: Needs jsoncpp

PATCH Superseded Bernd Kuhls 2 participants 4 messages Oct 1, 2015

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Bernd Kuhls

author
#0 lore raw

PATCH v2 1/1 package/kodi-pvr-stalker: Needs jsoncpp

Fixes
http://autobuild.buildroot.net/results/56f/56fb98da27495f6a461bfdc7aa8c2de4d86dfdb8/
http://autobuild.buildroot.net/results/f98/f982b437935cf1f921559f5388fd4146eb9241bd/

Signed-off-by Bernd Kuhls <[email protected]>

---
v2: add jsoncpp reverse dependency (Baruch)

 package/kodi-pvr-stalker/Config.in           | 5 +++++
 package/kodi-pvr-stalker/kodi-pvr-stalker.mk | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)
package/kodi-pvr-stalker/Config.in +5 -0
index b327fd8..0e6143a 100644
@@ -1,7 +1,12 @@
 config BR2_PACKAGE_KODI_PVR_STALKER
 	bool "kodi-pvr-stalker"
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 # jsoncpp
+	select BR2_PACKAGE_JSONCPP
 	select BR2_PACKAGE_KODI_PLATFORM
 	help
 	  A PVR Client that connects Kodi to Stalker Middleware
 
 	  https://github.com/kodi-pvr/pvr.stalker
+
+comment "kodi-pvr-stalker needs a toolchain w/ C++, gcc >= 4.7"
+	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_4_7
package/kodi-pvr-stalker/kodi-pvr-stalker.mk +1 -1
index 589cf7d..c1baa8d 100644
@@ -8,6 +8,6 @@ KODI_PVR_STALKER_VERSION = 5f6eb1992ffd45a075ebb7bc4253c4a88bf65c80
 KODI_PVR_STALKER_SITE = $(call github,kodi-pvr,pvr.stalker,$(KODI_PVR_STALKER_VERSION))
 KODI_PVR_STALKER_LICENSE = GPLv2+
 KODI_PVR_STALKER_LICENSE_FILES = src/client.h
-KODI_PVR_STALKER_DEPENDENCIES = kodi-platform
+KODI_PVR_STALKER_DEPENDENCIES = jsoncpp kodi-platform
 
 $(eval $(cmake-package))
Signature · 1 line
2.5.3
#1 lore raw

PATCH v2 1/1 package/kodi-pvr-stalker: Needs jsoncpp

Hi Benrd,

package/kodi-pvr-stalker/Config.in line 3

Quoted 9 lines · Bernd Kuhls
package/kodi-pvr-stalker/Config.in +1 -0
index b327fd8..0e6143a 100644
@@ -1,7 +1,12 @@
 config BR2_PACKAGE_KODI_PVR_STALKER
 	bool "kodi-pvr-stalker"
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 # jsoncpp

Also BR2_INSTALL_LIBSTDCPP.

package/kodi-pvr-stalker/Config.in line 12

Quoted 9 lines
package/kodi-pvr-stalker/Config.in +4 -0
+	select BR2_PACKAGE_JSONCPP
 	select BR2_PACKAGE_KODI_PLATFORM
 	help
 	  A PVR Client that connects Kodi to Stalker Middleware
 
 	  https://github.com/kodi-pvr/pvr.stalker
+
+comment "kodi-pvr-stalker needs a toolchain w/ C++, gcc >= 4.7"
+	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_4_7

Ditto.

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
author
#2 lore raw

PATCH v2 1/1 package/kodi-pvr-stalker: Needs jsoncpp

[posted and mailed]

Baruch Siach <[email protected]> wrote in
news:20151001202438.GE3337 at tarshish:

Quoted 14 lines

Hi Benrd,

package/kodi-pvr-stalker/Config.in line 3

Quoted 9 lines · Bernd Kuhls
package/kodi-pvr-stalker/Config.in +1 -0
index b327fd8..0e6143a 100644
@@ -1,7 +1,12 @@
 config BR2_PACKAGE_KODI_PVR_STALKER
      bool "kodi-pvr-stalker"
+     depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 # jsoncpp

Also BR2_INSTALL_LIBSTDCPP.

Hi Baruch,

imho this is not necessary, BR2_PACKAGE_KODI_PVR_STALKER can only be selected if BR2_PACKAGE_KODI is true and BR2_PACKAGE_KODI already depends on BR2 _INSTALL_LIBSTDCPP.

Regards, Bernd

#3 lore raw

PATCH v2 1/1 package/kodi-pvr-stalker: Needs jsoncpp

Hi Bernd,

Quoted 15 lines · Bernd Kuhls

Baruch Siach <[email protected]> wrote in
news:20151001202438.GE3337 at tarshish:

Quoted 12 lines · Bernd Kuhls

package/kodi-pvr-stalker/Config.in line 3

Quoted 9 lines
package/kodi-pvr-stalker/Config.in +1 -0
index b327fd8..0e6143a 100644
@@ -1,7 +1,12 @@
 config BR2_PACKAGE_KODI_PVR_STALKER
      bool "kodi-pvr-stalker"
+     depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 # jsoncpp

Also BR2_INSTALL_LIBSTDCPP.

Quoted 3 lines

imho this is not necessary, BR2_PACKAGE_KODI_PVR_STALKER can only be selected if BR2_PACKAGE_KODI is true and BR2_PACKAGE_KODI already depends on BR2 _INSTALL_LIBSTDCPP.

In that case the comment doesn't even show when the toolchain lacks C++ support, so I guess you can just omit C++ from the toolchain requirements comment.

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -