Staging: board: Removed unnecessary header file
PATCH v2 1/1 Staging: board: Removed unnecessary header file
Fixed the problem with previous version by removing the unnecessary header file that was added in previous version.
--- drivers/staging/board/board.c | 2 -- 1 file changed, 2 deletions(-)
drivers/staging/board/board.c +0 -2
@@ -19,8 +19,6 @@#include <linux/of_irq.h> #include <linux/platform_device.h> #include <linux/pm_domain.h> -#include <asm/prom.h> -#include "board.h" static struct device_node *irqc_node__initdata ;
Signature · 1 line
2.1.0
Quoted 2 lines · Shivani Bhardwaj
Fixed the problem with previous version by removing the unnecessary header file that was added in previous version.
Hi,
Version 2 should be on top of the actual file and not on the version 1 of the patch.
Quoted 27 lines
Signed-off-by Shivani Bhardwaj <[email protected]>--- drivers/staging/board/board.c | 2 -- 1 file changed, 2 deletions(-)drivers/staging/board/board.c +0
-3@@ -19,8 +19,6 @@#include <linux/of_irq.h> #include <linux/platform_device.h> #include <linux/pm_domain.h> -#include <asm/prom.h> -#include "board.h" static struct device_node *irqc_node__initdata ; --2.1.0
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20151002081827.GA56279%40ubuntu.
For more options, visit https://groups.google.com/d/optout.
Signature · 1 line
Vaishali
Quoted 2 lines · Shivani Bhardwaj
Fixed the problem with previous version by removing the unnecessary header file that was added in previous version.
This is not the right way to make a v2. Your v1 will not be accepted, so your v2 work should be based on the original code, not the result of your previous patch. Put the changes for v2 under the ---
However, are you sure that it is the header that is not needed, and nothe local declaration that is not needed?
julia
Quoted 28 lines
Signed-off-by Shivani Bhardwaj <[email protected]>--- drivers/staging/board/board.c | 2 -- 1 file changed, 2 deletions(-)drivers/staging/board/board.c +0
-3@@ -19,8 +19,6 @@#include <linux/of_irq.h> #include <linux/platform_device.h> #include <linux/pm_domain.h> -#include <asm/prom.h> -#include "board.h" static struct device_node *irqc_node__initdata ; --2.1.0
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20151002081827.GA56279%40ubuntu.
For more options, visit https://groups.google.com/d/optout.