platform/x86: Toshiba WMI Hotkey Driver
Subsystems (2)
Azael Avalos
maintainerPATCH v4 1/1 platform/x86: Toshiba WMI Hotkey Driver
Toshiba laptops that feature WMI events for hotkeys were left unsupported by the toshiba_acpi driver, however, commit a88bc06e5aec ("toshiba_acpi:
Avoid registering input device on WMI event laptops") added hardware support for such laptops, but the hotkeys are not handled there.
This driver adds support for hotkey monitoring on certain Toshiba laptops that manage the hotkeys via WMI events instead of the Toshiba Configuration Interface (TCI).
The toshiba_acpi driver and this one can co-exist, as this only takes care of hotkeys, while the proper takes care of hardware related stuff.
Currently the driver is under the EXPERIMENTAL flag, as the keymap and the notify function are incomplete (due to lack of hardware to test).
---
Changes since v3:
- Fixed Makefile entry, CONFIG_TOSHIBA_HAPS was doubled instead of one of them being CONFIG_TOSHIBA_WMI (this should fix the kbuild errors reported)
Changes since v2:
- Fixed typo in patch and Kconfig description as well as in a comment
Changes since v1:
- Changed the printed log level of the ACPI event type value from info to debug
- Make the input_dev struct declaration static
MAINTAINERS | 6 ++ drivers/platform/x86/Kconfig | 18 +++++ drivers/platform/x86/Makefile | 1 + drivers/platform/x86/toshiba-wmi.c | 138 +++++++++++++++++++++++++++++++++++++ 4 files changed, 163 insertions(+) create mode 100644 drivers/platform/x86/toshiba-wmi.c
MAINTAINERS +6 -0
@@ -10318,6 +10318,12 @@ L: [email protected] S: Maintained F: drivers/platform/x86/toshiba_haps.c +TOSHIBA WMI HOTKEYS DRIVER +M: Azael Avalos <[email protected]> +L: [email protected] +S: Maintained +F: drivers/platform/x86/toshiba-wmi.c + TOSHIBA SMM DRIVER M: Jonathan Buzzard <[email protected]> W: http://www.buzzard.org.uk/toshiba/
drivers/platform/x86/Kconfig +18 -0
@@ -700,6 +700,24 @@ config TOSHIBA_HAPS If you have a recent Toshiba laptop with a built-in accelerometer device, say Y. +config TOSHIBA_WMI + tristate "Toshiba WMI Hotkeys Driver (EXPERIMENTAL)" + default n + depends on ACPI_WMI + depends on INPUT + select INPUT_SPARSEKMAP + ---help--- + This driver adds hotkey monitoring support to some Toshiba models + that manage the hotkeys via WMI events. + + WARNING: This driver is incomplete as it lacks a proper keymap and the + *notify function only prints the ACPI event type value. Be warned that + you will need to provide some information if you have a Toshiba model + with WMI event hotkeys and want to help with the develpment of this + driver. + + If you have a WMI-based hotkeys Toshiba laptop, say Y or M here. + config ACPI_CMPC tristate "CMPC Laptop Extras" depends on X86 && ACPI
drivers/platform/x86/Makefile +1 -0
@@ -40,6 +40,7 @@ obj-$(CONFIG_ACPI_TOSHIBA) += toshiba_acpi.o obj-$(CONFIG_TOSHIBA_BT_RFKILL) += toshiba_bluetooth.o obj-$(CONFIG_TOSHIBA_HAPS) += toshiba_haps.o +obj-$(CONFIG_TOSHIBA_WMI) += toshiba-wmi.o obj-$(CONFIG_INTEL_SCU_IPC) += intel_scu_ipc.o obj-$(CONFIG_INTEL_SCU_IPC_UTIL) += intel_scu_ipcutil.o obj-$(CONFIG_INTEL_MFLD_THERMAL) += intel_mid_thermal.o
drivers/platform/x86/toshiba-wmi.c new file +138 -0
138 lines not on this page · raw message
Signature · 1 line
2.5.1
Quoted 9 lines · Azael Avalos
Toshiba laptops that feature WMI events for hotkeys were left unsupported by the
toshiba_acpidriver, however, commita88bc06e5aec("toshiba_acpi:
Avoid registering input device on WMI event laptops") added hardware support for such laptops, but the hotkeys are not handled there.This driver adds support for hotkey monitoring on certain Toshiba laptops that manage the hotkeys via WMI events instead of the Toshiba Configuration Interface (TCI).
Quoted 7 lines
The
toshiba_acpidriver and this one can co-exist, as this only takes care of hotkeys, while the proper takes care of hardware related stuff.Currently the driver is under the EXPERIMENTAL flag, as the keymap and the notify function are incomplete (due to lack of hardware to test).
Signed-off-by Azael Avalos <[email protected]>
Queued to testing, thanks Azael.
Signature · 2 lines
Darren Hart Intel Open Source Technology Center