toolchain: Remove useless printf
PATCH 1/1 toolchain: Remove useless printf
Introduced by previous patch 0f75b2635ee564fbbdb9ea631cf39fa8731d6d6c, this printf doesn't serve any purposes.
Signed-off-by Maxime Hadjinlian <[email protected]>
--- toolchain/helpers.mk | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
toolchain/helpers.mk +1 -3
@@ -79,9 +79,7 @@ copy_toolchain_lib_root = \ fi ; \ LIBPATH="`readlink -f $${LIBPATH}`"; \ done; \ - done; \ -\ - printf + done # # Copy the full external toolchain sysroot directory to the staging
Signature · 1 line
2.5.3
PATCH 1/1 toolchain: Remove useless printf
Maxime, All,
On 2015-10-04 13:17 +0200, Maxime Hadjinlian spake thusly:
Quoted 2 lines
Introduced by previous patch
0f75b2635ee564fbbdb9ea631cf39fa8731d6d6c, this printf doesn't serve any purposes.
This is even worth than that. It actually breaks the build because there is not format to printf:
printf: usage: printf [-v var] format [arguments]
So the glibc build fails.
With that fixed in the commit log;
Acked-by: "Yann E. MORIN" <[email protected]>
Quoted 1 line
Signed-off-by Maxime Hadjinlian <[email protected]>
And I think this would also be valid;
;-)
Regards,
Yann E. MORIN.
Quoted 22 lines
--- toolchain/helpers.mk | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)toolchain/helpers.mk +1
-3@@ -79,9 +79,7 @@ copy_toolchain_lib_root = \ fi ; \ LIBPATH="`readlink -f $${LIBPATH}`"; \ done; \ - done; \ -\ - printf + done # # Copy the full external toolchain sysroot directory to the stagingSignature · 1 line
2.5.3
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/1 toolchain: Remove useless printf
Quoted 14 lines · Yann E. MORIN
Maxime, All,
On 2015-10-04 13:17 +0200, Maxime Hadjinlian spake thusly:
Quoted 2 lines
Introduced by previous patch
0f75b2635ee564fbbdb9ea631cf39fa8731d6d6c, this printf doesn't serve any purposes.This is even worth than that. It actually breaks the build because there is not format to printf:
printf: usage: printf [-v var] format [arguments]So the glibc build fails.
With that fixed in the commit log;
Quoted 9 lines
Acked-by: "Yann E. MORIN" <[email protected]>Quoted 1 line
Signed-off-by Maxime Hadjinlian <[email protected]>
And I think this would also be valid;
Reported-by "Yann E. MORIN" <[email protected]>
Yes, I noticed I forgot that when I hit 'y' on git send-email, sorry :/. Should I send a v2 with a better commit log or should it be done when the commit is done ?
Quoted 41 lines
;-)
Regards,
Yann E. MORIN.Quoted 20 lines
--- toolchain/helpers.mk | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)toolchain/helpers.mk +1
-4@@ -79,9 +79,7 @@ copy_toolchain_lib_root = \ fi ; \ LIBPATH="`readlink -f $${LIBPATH}`"; \ done; \ - done; \ -\ - printf + done # # Copy the full external toolchain sysroot directory to the staging --Quoted 2 lines
2.5.3
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
Quoted 2 lines
'------------------------------^-------^------------------^--------------------'
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20151004/3ece82e3/attachment.html>