Skip to contentSkip to conversation

libnfs: Without native RPC use libtirpc

PATCH New Maxime Hadjinlian 2 participants 4 messages Oct 3, 2015 – Oct 4, 2015

lore
Share & tools
lore

Maxime Hadjinlian

author
#0 lore raw

PATCH 1/1 libnfs: Without native RPC use libtirpc

Signed-off-by Maxime Hadjinlian <[email protected]>
---
RFC: A few packages uses libtirpc if there's no native RPC support *BUT* they don't propagate the BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2.

It was probably added later on in libtirpc, so the questions here, is what do we do with that ? Should we add the dependencies to the other packages ?
Do we need some kind of mechanisms to handle that ?

---
 package/libnfs/.Config.in.swp | Bin 0 -> 12288 bytes
 package/libnfs/Config.in      |   8 +++++---
 package/libnfs/libnfs.mk      |   4 ++++
 3 files changed, 9 insertions(+), 3 deletions(-)
 create mode 100644 package/libnfs/.Config.in.swp
package/libnfs/.Config.in.swp new file binary +0 -0
new file mode 100644
index 0000000000000000000000000000000000000000..c737cd335751e1a7082f17205d29e1b6f8eb3318
GIT binary patch

zcmeI&y>8P6bJBAHX}-_GP2yHQbm!7(|o(f}AuZR)bsROC69b+qsFa at R#fx!BD|V z at DjWO6O23n6DxwJfa4~WAke at F=zpcZY|F>?xxX#S@#b|vAAEmN4z$P>K{oed7(i zzfBZ-&s8kT8>?3!b5;C7-HZ7P&4V<U#WK-_naR9J&Cm;;n*K~h<2+5ZnenAJm1d;; zWKx)|G?}PrO(m<Fz+DJH;BtYPp4@qPInu7^|ENYSjz4hL_jl4g??o0SG_<0uX=z z1R(I=3FvH%Uh=N4EOvHnaa>zEE-rC^00bZa0SG_<0uX=z1Rwwb2teQ;6!6AGU)PC_ zu5<JJ|Nq7B|4$o4A2_c$4rh~dmGgzK6Bo2-f~X%4Z*PZgRFbSP*~!1Rwwb2tWV= z5P$##An;cUi1{K~oEXMfW-=KUB27f)R<qY|2gk?VR>!g(w29)LFb2(-<S8=)<IvK zor#~{<yZrI)OLF(tz8PzxEv1)%gUtNTlQ at JfYJx3PMjM;+ZLQmiV5REZ2BLanoX z)0?D&ioobZx&t{7)m_rpV8$c$!?y3LZJ<33Dk_oJF$yj;B?c)W^Bl#x-$NCx6 z!xO7 at WIbxTUAsB3xig_AqOz)WGK^m&G)^tv;1XbkOcOR@ZHIBR6?I&5qXL#y1 p>U)h|V|QCHfmV4I(D%BldMJ6Hkm0k{1z?p$%NhFRO*w~sUVbg$W#CT

literal 0
HcmV?d00001

package/libnfs/Config.in +5 -3
index 6642fe4..0081548 100644
@@ -1,10 +1,12 @@
 config BR2_PACKAGE_LIBNFS
 	bool "libnfs"
-	depends on BR2_TOOLCHAIN_HAS_NATIVE_RPC
+	depends on BR2_TOOLCHAIN_HAS_NATIVE_RPC || \
+		(BR2_TOOLCHAIN_HAS_THREADS && !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2)# libtirpc
+	select BR2_PACKAGE_LIBTIRPC if !BR2_TOOLCHAIN_HAS_NATIVE_RPC
 	help
 	  nfs userspace implementation.
 
 	  http://github.com/sahlberg/libnfs
 
-comment "libnfs needs a toolchain w/ RPC"
-	depends on !BR2_TOOLCHAIN_HAS_NATIVE_RPC
+comment "libnfs needs a toolchain w/ threads"
+	depends on !(BR2_TOOLCHAIN_HAS_THREADS || BR2_TOOLCHAIN_HAS_NATIVE_RPC)
package/libnfs/libnfs.mk +4 -0
index 0c8c4f5..fb95e21 100644
@@ -13,4 +13,8 @@ LIBNFS_LICENSE = LGPLv2.1+
 LIBNFS_LICENSE_FILES = LICENCE-LGPL-2.1.txt
 LIBNFS_DEPENDENCIES = host-pkgconf
 
+ifeq ($(BR2_PACKAGE_LIBTIRPC),y)
+LIBNFS_DEPENDENCIES += libtirpc
+endif
+
 $(eval $(autotools-package))
Signature · 1 line
2.5.3
author
#1 lore raw

PATCH 1/1 libnfs: Without native RPC use libtirpc

There's a crappy file. Don't do git add with glob at home...

Quoted 73 lines · Maxime Hadjinlian

Signed-off-by Maxime Hadjinlian <[email protected]>
---
RFC: A few packages uses libtirpc if there's no native RPC support *BUT* they don't propagate the BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2.

It was probably added later on in libtirpc, so the questions here, is what do we do with that ? Should we add the dependencies to the other packages ?
Do we need some kind of mechanisms to handle that ?

---
 package/libnfs/.Config.in.swp | Bin 0 -> 12288 bytes
 package/libnfs/Config.in      |   8 +++++---
 package/libnfs/libnfs.mk      |   4 ++++
 3 files changed, 9 insertions(+), 3 deletions(-)
 create mode 100644 package/libnfs/.Config.in.swp
package/libnfs/.Config.in.swp new file +0 -0
new file mode 100644

index 0000000000000000000000000000000000000000..c737cd335751e1a7082f17205d29e1b6f8eb3318 GIT binary patch
literal 12288 zcmeI&y>8P6bJBAHX}-_GP2yHQbm!7(|o(f}AuZR)bsROC69b+qsFa at R#fx!BD|V z at DjWO6O23n6DxwJfa4~WAke at F=zpcZY|F>?xxX#S@#b|vAAEmN4z$P>K{oed7(i zzfBZ-&s8kT8>?3!b5;C7-HZ7P&4V<U#WK-_naR9J&Cm;;n*K~h<2+5ZnenAJm1d;; zWKx)|G?}PrO(m<Fz+DJH;BtYPp4@qPInu7^|ENYSjz4hL_jl4g??o0SG_<0uX=z z1R(I=3FvH%Uh=N4EOvHnaa>zEE-rC^00bZa0SG_<0uX=z1Rwwb2teQ;6!6AGU)PC_ zu5<JJ|Nq7B|4$o4A2_c$4rh~dmGgzK6Bo2-f~X%4Z*PZgRFbSP*~!1Rwwb2tWV= z5P$##An;cUi1{K~oEXMfW-=KUB27f)R<qY|2gk?VR>!g(w29)LFb2(-<S8=)<IvK zor#~{<yZrI)OLF(tz8PzxEv1)%gUtNTlQ@JfYJx3PMjM;+ZLQmiV5REZ2BLanoX z)0?D&ioobZx&t{7)m_rpV8$c$!?y3LZJ<33Dk_oJF$yj;B?c)W^Bl#x-$NCx6 z!xO7 at WIbxTUAsB3xig_AqOz)WGK^m&G)^tv;1XbkOcOR at ZHIBR6?I&5qXL#y1 p>U)h|V|QCHfmV4I(D%BldMJ6Hkm0k{1z?p$%NhFRO*w~sUVbg$W#CT

literal 0
HcmV?d00001

package/libnfs/Config.in +2 -1
index 6642fe4..0081548 100644
@@ -1,10 +1,12 @@
 config BR2_PACKAGE_LIBNFS
        bool "libnfs"
-       depends on BR2_TOOLCHAIN_HAS_NATIVE_RPC
+       depends on BR2_TOOLCHAIN_HAS_NATIVE_RPC || \
+               (BR2_TOOLCHAIN_HAS_THREADS &&

!BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2)# libtirpc

package/libnfs/Config.in +3 -2
+       select BR2_PACKAGE_LIBTIRPC if !BR2_TOOLCHAIN_HAS_NATIVE_RPC
        help
          nfs userspace implementation.
 
          http://github.com/sahlberg/libnfs
 
-comment "libnfs needs a toolchain w/ RPC"
-       depends on !BR2_TOOLCHAIN_HAS_NATIVE_RPC
+comment "libnfs needs a toolchain w/ threads"
+       depends on !(BR2_TOOLCHAIN_HAS_THREADS ||

BR2_TOOLCHAIN_HAS_NATIVE_RPC)

package/libnfs/libnfs.mk +4 -1
index 0c8c4f5..fb95e21 100644
@@ -13,4 +13,8 @@ LIBNFS_LICENSE = LGPLv2.1+
 LIBNFS_LICENSE_FILES = LICENCE-LGPL-2.1.txt
 LIBNFS_DEPENDENCIES = host-pkgconf
 
+ifeq ($(BR2_PACKAGE_LIBTIRPC),y)
+LIBNFS_DEPENDENCIES += libtirpc
+endif
+
 $(eval $(autotools-package))
--
Quoted 3 lines

2.5.3

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20151003/3a5dcb3c/attachment.html>

#2 lore raw

PATCH 1/1 libnfs: Without native RPC use libtirpc

Hi Maxime,

Quoted 1 line · Maxime Hadjinlian

There's a crappy file. Don't do git add with glob at home...

Or just do

echo '*.swp' >> .git/info/exclude

baruch

Quoted 17 lines
Quoted 15 lines · Maxime Hadjinlian

Signed-off-by Maxime Hadjinlian <[email protected]>
---
RFC: A few packages uses libtirpc if there's no native RPC support *BUT* they don't propagate the BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2.

It was probably added later on in libtirpc, so the questions here, is what do we do with that ? Should we add the dependencies to the other packages ?
Do we need some kind of mechanisms to handle that ?

---
 package/libnfs/.Config.in.swp | Bin 0 -> 12288 bytes
 package/libnfs/Config.in      |   8 +++++---
 package/libnfs/libnfs.mk      |   4 ++++
 3 files changed, 9 insertions(+), 3 deletions(-)
 create mode 100644 package/libnfs/.Config.in.swp
Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
author
#3 lore raw

PATCH 1/1 libnfs: Without native RPC use libtirpc

Quoted 9 lines · Baruch Siach

Hi Maxime,

Quoted 1 line · Maxime Hadjinlian

There's a crappy file. Don't do git add with glob at home...

Or just do

   echo '*.swp' >> .git/info/exclude

Good point Baruch.
I'll even add it to my global gitconfig, no real reason I would ever need to commit a swp file.

Quoted 23 lines

baruch

Quoted 5 lines
Quoted 3 lines · Maxime Hadjinlian

Signed-off-by Maxime Hadjinlian <[email protected]>
---
RFC: A few packages uses libtirpc if there's no native RPC support

*BUT*

Quoted 1 line
Quoted 1 line

they don't propagate the

BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2.

Quoted 11 lines
Quoted 11 lines

It was probably added later on in libtirpc, so the questions here, is what do we do with that ? Should we add the dependencies to the other packages ?
Do we need some kind of mechanisms to handle that ?

---
 package/libnfs/.Config.in.swp | Bin 0 -> 12288 bytes
 package/libnfs/Config.in      |   8 +++++---
 package/libnfs/libnfs.mk      |   4 ++++
 3 files changed, 9 insertions(+), 3 deletions(-)
 create mode 100644 package/libnfs/.Config.in.swp
Quoted 6 lines

--
http://baruch.siach.name/blog/ ~. .~ Tk Open
Systems =}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20151004/2fe38b0e/attachment.html>