Skip to contentSkip to conversation

toolchain: Fix glibc breakage

PATCH New Maxime Hadjinlian 3 participants 3 messages Oct 4, 2015

lore
Share & tools
lore

Maxime Hadjinlian

author
#0 lore raw

PATCH v2 1/1 toolchain: Fix glibc breakage

Introduced by previous patch 0f75b2635ee564fbbdb9ea631cf39fa8731d6d6c, this printf would break the build of glibc, because there is no format to printf:

printf: usage: printf [-v var] format [arguments]

Signed-off-by Maxime Hadjinlian <[email protected]>

Reported-by "Yann E. MORIN" <[email protected]>
Acked-by "Yann E. MORIN" <[email protected]>
---
 toolchain/helpers.mk | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
toolchain/helpers.mk +1 -3
index a4fa815..1452ec6 100644
@@ -79,9 +79,7 @@ copy_toolchain_lib_root = \
 			fi ; \
 			LIBPATH="`readlink -f $${LIBPATH}`"; \
 		done; \
-	done; \
-\
-	printf
+	done
 
 #
 # Copy the full external toolchain sysroot directory to the staging
Signature · 1 line
2.5.3
#1 lore raw

PATCH v2 1/1 toolchain: Fix glibc breakage

Maxime, All,

On 2015-10-04 13:35 +0200, Maxime Hadjinlian spake thusly:

Quoted 3 lines

Introduced by previous patch 0f75b2635ee564fbbdb9ea631cf39fa8731d6d6c, this printf would break the build of glibc, because there is no format to printf:

Better, thanks! :-)

Quoted 5 lines

printf: usage: printf [-v var] format [arguments]

Signed-off-by Maxime Hadjinlian <[email protected]>

Reported-by "Yann E. MORIN" <[email protected]>
Acked-by "Yann E. MORIN" <[email protected]>

Still valid.

Regards,
Yann E. MORIN.

Quoted 22 lines
---
 toolchain/helpers.mk | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
toolchain/helpers.mk +1 -3
index a4fa815..1452ec6 100644
@@ -79,9 +79,7 @@ copy_toolchain_lib_root = \
 			fi ; \
 			LIBPATH="`readlink -f $${LIBPATH}`"; \
 		done; \
-	done; \
-\
-	printf
+	done
 
 #
 # Copy the full external toolchain sysroot directory to the staging
Signature · 1 line
2.5.3
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH v2 1/1 toolchain: Fix glibc breakage

In reply to Maxime Hadjinlian
Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Maxime" == Maxime Hadjinlian <[email protected]> writes:

Introduced by previous patch 0f75b2635ee564fbbdb9ea631cf39fa8731d6d6c, this printf would break the build of glibc, because there is no format to printf:

printf: usage: printf [-v var] format [arguments]

Signed-off-by Maxime Hadjinlian <[email protected]>

Reported-by "Yann E. MORIN" <[email protected]>
Acked-by "Yann E. MORIN" <[email protected]>

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard