Skip to contentSkip to conversation

Staging: wilc1000: Do not use multiple blank lines

PATCH In review Aybuke Ozdemir 3 participants 6 messages Oct 4, 2015 – Oct 5, 2015 Staging

lore
Share & tools
lore

Aybuke Ozdemir

author
#0 lore raw

PATCH 1/2 Staging: wilc1000: Do not use multiple blank lines

This patch removes unnecessary blank lines between functions. Found by checkpatch.pl:
"CHECK: Please don't use multiple blank lines".

Signed-off-by Aybuke Ozdemir <[email protected]>
---
 drivers/staging/wilc1000/coreconfigurator.c | 11 -----------
 1 file changed, 11 deletions(-)
drivers/staging/wilc1000/coreconfigurator.c +0 -11
index 14e8efc..439c828 100644
@@ -8,7 +8,6 @@
  *  @version	1.0
  */
 
-
 /*****************************************************************************/
 /* File Includes                                                             */
 /*****************************************************************************/

@@ -24,7 +23,6 @@
 /* Function Macros                                                           */
 /*****************************************************************************/
 
-
 /*****************************************************************************/
 /* Type Definitions                                                          */
 /*****************************************************************************/

@@ -122,7 +120,6 @@ typedef enum {
 	INFOELEM_ID_FORCE_32BIT  = 0xFFFFFFFF
 } tenuInfoElemID;
 
-
 typedef struct {
 	char *pcRespBuffer;
 	s32 s32MaxRespBuffLen;

@@ -130,8 +127,6 @@ typedef struct {
 	bool bRespRequired;
 } tstrConfigPktInfo;
 
-
-
 /*****************************************************************************/
 /* Extern Variable Declarations                                              */
 /*****************************************************************************/

@@ -143,8 +138,6 @@ typedef struct {
 /* Static Function Declarations                                              */
 /*****************************************************************************/
 
-
-
 /*****************************************************************************/
 /* Functions                                                                 */
 /*****************************************************************************/

@@ -613,7 +606,6 @@ s32 ParseAssocRespInfo(u8 *pu8Buffer, u32 u32BufferLen,
 
 	*ppstrConnectRespInfo = pstrConnectRespInfo;
 
-
 	return s32Error;
 }
 

@@ -667,7 +659,6 @@ s32 ParseSurveyResults(u8 ppu8RcvdSiteSurveyResults[][MAX_SURVEY_RESULT_FRAG_SIZ
 	for (i = 0; i < u32RcvdSurveyResultsNum; i++) {
 		u32SurveyBytesLength = ppu8RcvdSiteSurveyResults[i][0];
 
-
 		for (j = 0; j < u32SurveyBytesLength; j += SURVEY_RESULT_LENGTH) {
 			u32SurveyResultsCount++;
 		}

@@ -706,7 +697,6 @@ ERRORHANDLER:
 	return s32Error;
 }
 
-
 s32 DeallocateSurveyResults(wid_site_survey_reslts_s *pstrSurveyResults)
 {
 	s32 s32Error = 0;

@@ -735,7 +725,6 @@ s32 CoreConfiguratorDeInit(void)
 
 	PRINT_D(CORECONFIG_DBG, "CoreConfiguratorDeInit()\n");
 
-
 	return s32Error;
 }
Signature · 1 line
2.1.4
author
#1 lore raw

PATCH 2/2 Staging: wilc1000: Added 'function' word.

This patch organizing missing written word missing. Found by checkpatch.pl:
CHECK: 'funcion' may be misspelled - perhaps 'function'?

Signed-off-by Aybuke Ozdemir <[email protected]>
---
 drivers/staging/wilc1000/coreconfigurator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/wilc1000/coreconfigurator.c +1 -1
index 439c828..08f5675 100644
@@ -296,7 +296,7 @@ static inline u16 get_assoc_resp_cap_info(u8 *data)
 	return cap_info;
 }
 
-/* This funcion extracts the association status code from the incoming       */
+/* This function extracts the association status code from the incoming       */
 /* association response frame and returns association status code            */
 static inline u16 get_asoc_status(u8 *data)
 {
Signature · 1 line
2.1.4
#2 lore raw

Re: [Outreachy kernel] [PATCH 2/2] Staging: wilc1000: Added 'function' word.

Something like "fix spelling mistake" would be better. Because the workd is not really added.

julia

Quoted 32 lines · Aybuke Ozdemir

This patch organizing missing written word missing. Found by checkpatch.pl:
CHECK: 'funcion' may be misspelled - perhaps 'function'?

Signed-off-by Aybuke Ozdemir <[email protected]>
---
 drivers/staging/wilc1000/coreconfigurator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/wilc1000/coreconfigurator.c +1 -2
index 439c828..08f5675 100644
@@ -296,7 +296,7 @@ static inline u16 get_assoc_resp_cap_info(u8 *data)
 	return cap_info;
 }
 
-/* This funcion extracts the association status code from the incoming       */
+/* This function extracts the association status code from the incoming       */
 /* association response frame and returns association status code            */
 static inline u16 get_asoc_status(u8 *data)
 {
--

2.1.4

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1443967460-14302-2-git-send-email-aybuke.147%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

author
#3 lore raw

Re: [Outreachy kernel] [PATCH 2/2] Staging: wilc1000: Added 'function' word.

Hi,

I had to build my operating system from scratch. When cloning repository, the first part of the set already looks smooth. So I can not edit this patch. Can I send a separate patch?

Thanks.

2015-10-04 21:46 GMT+03:00 Julia Lawall <[email protected]>:

Quoted 48 lines

Something like "fix spelling mistake" would be better. Because the workd is not really added.

julia

Review

Quoted 10 lines · Aybuke Ozdemir

This patch organizing missing written word missing. Found by checkpatch.pl:
CHECK: 'funcion' may be misspelled - perhaps 'function'?

Signed-off-by Aybuke Ozdemir <[email protected]>
---
 drivers/staging/wilc1000/coreconfigurator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/drivers/staging/wilc1000/coreconfigurator.c

drivers/staging/wilc1000/coreconfigurator.c static inline u16 get_assoc_resp_cap_info(u8 *data) · line 299

Quoted 8 lines

index 439c828..08f5675 100644

drivers/staging/wilc1000/coreconfigurator.c +0 -1
@@ -296,7 +296,7 @@ static inline u16 get_assoc_resp_cap_info(u8 *data)
      return cap_info;
 }
 
-/* This funcion extracts the association status code from the incoming

     */

drivers/staging/wilc1000/coreconfigurator.c static inline u16 get_assoc_resp_cap_info(u8 *data) · line 299

Quoted 1 line
drivers/staging/wilc1000/coreconfigurator.c +1 -0
+/* This function extracts the association status code from the

incoming */

drivers/staging/wilc1000/coreconfigurator.c static inline u16 get_assoc_resp_cap_info(u8 *data) · line 300

Quoted 1 line
drivers/staging/wilc1000/coreconfigurator.c +0 -0
 /* association response frame and returns association status code

      */
Quoted 7 lines
drivers/staging/wilc1000/coreconfigurator.c +0 -1
 static inline u16 get_asoc_status(u8 *data)
 {
--

2.1.4

--
You received this message because you are subscribed to the Google

Groups "outreachy-kernel" group.

Quoted 1 line

To unsubscribe from this group and stop receiving emails from it, send

an email to [email protected].

Quoted 2 lines

To post to this group, send email to [email protected]. To view this discussion on the web visit

https://groups.google.com/d/msgid/outreachy-kernel/1443967460-14302-2-git-send-email-aybuke.147%40gmail.com
.

Quoted 2 lines

For more options, visit https://groups.google.com/d/optout.

Signature · 2 lines
Aybüke Özdemir
https://about.me/aybukeozdemir
maintainer
#4 lore raw

Re: [Outreachy kernel] [PATCH 2/2] Staging: wilc1000: Added 'function' word.

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

Quoted 5 lines · Aybuke Ozdemir

Hi,

I had to build my operating system from scratch. When cloning repository, the first part of the set already looks smooth. So I can not edit this patch. Can I send a separate patch?

Please fix up and resend the whole series.

thanks,

greg k-h

#5 lore raw

Re: [Outreachy kernel] [PATCH 2/2] Staging: wilc1000: Added 'function' word.

In reply to Aybuke Ozdemir
Quoted 5 lines · Aybuke Ozdemir

Hi,

I had to build my operating system from scratch. When cloning repository, the first part of the set already looks smooth. So I can not edit this patch. Can I send a separate patch?

If patch [1/2] is already applied, then just send part 2.

julia

Quoted 72 lines

Thanks.

2015-10-04 21:46 GMT+03:00 Julia Lawall <[email protected]>:
Something like "fix spelling mistake" would be better.  Because the workd
is not really added.

julia

On Sun, 4 Oct 2015, Aybuke Ozdemir wrote:

> This patch organizing missing written word missing. > Found by checkpatch.pl:
> CHECK: 'funcion' may be misspelled - perhaps 'function'? >
> Signed-off-by: Aybuke Ozdemir <[email protected]> > ---
>  drivers/staging/wilc1000/coreconfigurator.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c
> index 439c828..08f5675 100644
> --- a/drivers/staging/wilc1000/coreconfigurator.c
> +++ b/drivers/staging/wilc1000/coreconfigurator.c
> @@ -296,7 +296,7 @@ static inline u16 get_assoc_resp_cap_info(u8 *data)
>       return cap_info;
>  }
>
> -/* This funcion extracts the association status code from the incoming       */
> +/* This function extracts the association status code from the incoming       */
>  /* association response frame and returns association status code            */
>  static inline u16 get_asoc_status(u8 *data)
>  {
> --
> 2.1.4
>

Quoted 2 lines

--
You received this message because you are subscribed to the Google

Groups "outreachy-kernel" group.

Quoted 1 line

To unsubscribe from this group and stop receiving emails from it,

send an email to [email protected].

Quoted 1 line

To post to this group, send email to

[email protected].

Quoted 1 line

To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/1443967460-14302-2-git-s

end-email-aybuke.147%40gmail.com.

Quoted 2 lines

For more options, visit https://groups.google.com/d/optout.

--
Aybüke Özdemir
https://about.me/aybukeozdemir

--
You received this message because you are subscribed to the Google Groups
"outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CAEAX3JqmA3eW1w%2Bbh0DpW fYDkCQkVXE9_w8jaJ9W%3DZxTYhjGsQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.