Skip to contentSkip to conversation

ASoC: rt5645: Prevent the weird sound of the headphone while rebooting

PATCH In review Oder Chiou 3 participants 4 messages Oct 5, 2015

Subsystems (3)
Sound ASoC Realtek audio codecs
lore
Share & tools
lore

Oder Chiou

author maintainer
#0 lore raw

PATCH 1/2 ASoC: rt5645: Prevent the weird sound of the headphone while rebooting

The patch adds the codec reset setting in the shutdown function to prevent the weird sound of the headphone happened by rebooting.

Signed-off-by Oder Chiou <[email protected]>
---
 sound/soc/codecs/rt5645.c | 2 ++
 1 file changed, 2 insertions(+)
sound/soc/codecs/rt5645.c +2 -0
index f436f50..4c4fe6b 100644
@@ -3517,6 +3517,8 @@ static void rt5645_i2c_shutdown(struct i2c_client *i2c)
 		RT5645_CBJ_MN_JD);
 	regmap_update_bits(rt5645->regmap, RT5645_IN1_CTRL1, RT5645_CBJ_BST1_EN,
 		0);
+	msleep(20);
+	regmap_write(rt5645->regmap, RT5645_RESET, 0);
 }
 
 static struct i2c_driver rt5645_i2c_driver = {
Signature · 1 line
1.8.1.1.439.g50a6b54
author maintainer
#1 lore raw

PATCH 2/2 ASoC: rt5645: Add the HW EQ for the customized speaker output of Google Celes

Signed-off-by Oder Chiou <[email protected]>
---
 include/sound/rt5645.h    |  1 +
 sound/soc/codecs/rt5645.c | 69 ++++++++++++++++++++++++++++++++++++++++++++++-
 sound/soc/codecs/rt5645.h |  5 ++++
 3 files changed, 74 insertions(+), 1 deletion(-)
include/sound/rt5645.h +1 -0
index a5cf615..cf944e4 100644
@@ -23,6 +23,7 @@ struct rt5645_platform_data {
 	unsigned int jd_mode;
 	/* Invert JD when jack insert */
 	bool jd_invert;
+	unsigned int eq_mode;
 };
 
 #endif
sound/soc/codecs/rt5645.c +68 -1

108 lines not on this page · raw message

sound/soc/codecs/rt5645.h +5 -0
index 13ac732..89f25b8 100644
@@ -2187,6 +2187,11 @@ enum {
 	RT5645_AD_MONO_R_FILTER = (0x1 << 5),
 };
 
+enum {
+	EQ_NONE,
+	EQ_GOOGLE_CELES,
+};
+
 int rt5645_sel_asrc_clk_src(struct snd_soc_codec *codec,
 		unsigned int filter_mask, unsigned int clk_src);
Signature · 1 line
1.8.1.1.439.g50a6b54
build bot
#2 lore raw

Re: [PATCH 2/2] ASoC: rt5645: Add the HW EQ for the customized speaker output of Google Celes

reproduce:

Hi Oder,

[auto build test WARNING on next-20151002 -- if it's inappropriate base, please ignore]

reproduce:

        # apt-get install sparse
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__

sparse warnings: (new ones prefixed by >>)

>> sound/soc/codecs/rt5645.c:664:5: sparse: symbol 'rt5645_update_eqmode' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

maintainer
#3 lore raw

Applied "ASoC: rt5645: Prevent the weird sound of the headphone while rebooting" to the asoc tree

In reply to Oder Chiou

The patch

ASoC: rt5645: Prevent the weird sound of the headphone while rebooting

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From a2c026cfec3fb84375785dd2d6ec80bd60c5120e Mon Sep 17 00:00:00 2001

From: Oder Chiou <[email protected]>
Date: Mon, 5 Oct 2015 19:34:16 +0800
Subject: [PATCH] ASoC: rt5645: Prevent the weird sound of the headphone while
rebooting

The patch adds the codec reset setting in the shutdown function to prevent the weird sound of the headphone happened by rebooting.

Signed-off-by Oder Chiou <[email protected]>
Signed-off-by Mark Brown <[email protected]>
---
 sound/soc/codecs/rt5645.c | 2 ++
 1 file changed, 2 insertions(+)
sound/soc/codecs/rt5645.c +2 -0
index 66b7332e..cd1a4ec 100644
@@ -3514,6 +3514,8 @@ static void rt5645_i2c_shutdown(struct i2c_client *i2c)
 		RT5645_CBJ_MN_JD);
 	regmap_update_bits(rt5645->regmap, RT5645_IN1_CTRL1, RT5645_CBJ_BST1_EN,
 		0);
+	msleep(20);
+	regmap_write(rt5645->regmap, RT5645_RESET, 0);
 }
 
 static struct i2c_driver rt5645_i2c_driver = {
Signature · 1 line
2.5.0