Skip to contentSkip to conversation

arm: make psci_smp_available() depend on SMP + PSCI as the makefile does

PATCH New Sebastian Andrzej Siewior 2 participants 2 messages Oct 2, 2015 – Oct 6, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: make psci_smp_available() depend on SMP + PSCI as the makefile does

From: Sebastian Andrzej Siewior <[email protected]>

with CONFIG_ARM_PSCI=y, CONFIG_SMP=n and CONFIG_ARCH_TEGRA_124_SOC=y I end up with:

|arch/arm/mach-tegra/built-in.o: In function `tegra114_cpuidle_init':
|arch/arm/mach-tegra/cpuidle-tegra114.c:93: undefined reference to `psci_smp_available'
|Makefile:927: recipe for target 'vmlinux' failed

during build testing.

---
 arch/arm/include/asm/psci.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/include/asm/psci.h +1 -1
index 68ee3ce17b82..ff956f4d4307 100644
@@ -16,7 +16,7 @@
 
 extern struct smp_operations psci_smp_ops;
 
-#ifdef CONFIG_ARM_PSCI
+#if defined(CONFIG_ARM_PSCI) && defined(CONFIG_SMP)
 bool psci_smp_available(void);
 #else
 static inline bool psci_smp_available(void) { return false; }
Signature · 1 line
2.6.0
#1 lore raw

PATCH 1/1 arm: make psci_smp_available() depend on SMP + PSCI as the makefile does

Quoted 9 lines · Sebastian Andrzej Siewior

From: Sebastian Andrzej Siewior <[email protected]>

with CONFIG_ARM_PSCI=y, CONFIG_SMP=n and CONFIG_ARCH_TEGRA_124_SOC=y I end up with:

|arch/arm/mach-tegra/built-in.o: In function `tegra114_cpuidle_init':
|arch/arm/mach-tegra/cpuidle-tegra114.c:93: undefined reference to `psci_smp_available'
|Makefile:927: recipe for target 'vmlinux' failed
Quoted 6 lines

during build testing.

---
 arch/arm/include/asm/psci.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Jan Kiszka sent out an equivalent patch back in May, but it seems like discussion stalled on that. He resent a few days ago:

	http://patchwork.ozlabs.org/patch/521597/

Let me see if I can get the original discussion resumed. I'll add you in the loop.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20151006/fef61e7b/attachment.sig>