syscalls/setregid02: Fix retrieving a group of user "nobody"
PATCH v2 1/1 syscalls/setregid02: Fix retrieving a group of user "nobody"
In setup this test sets UID and GID of the user "nobody". Then it expects that user "nobody" is in group "nobody" and tries to retrive a structure for group "nobody" using getgrnam(). However some Linux distributions use group "nogroup" for user "nobody". Thus it's necessary to retrieve a group of user "nobody" not by hardcoded name but by its GID. It's necessary because group "nobody" may not exist.
I've replaced a variable "nobody" by more generic "ltpgroup". Then I've created 2 functions get_group_by_name and get_group_by_gid which are used instead of GET_GID macros.
On my test system I have user "nobody" in group "nogroup". So I've got this error messages for this test:
----------->8----------
setregid02.c:160: getgrnam("nobody") failed: errno=SUCCESS(0): Success
setregid02.c:160: Remaining cases broken
----------->8------------- testcases/kernel/syscalls/setregid/setregid02.c | 53 +++++++++++++++---------- 1 file changed, 32 insertions(+), 21 deletions(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-syscalls-setregid02-Fix-retrieving-a-group-of-user-n.patch
Type: text/x-patch
Size: 2999 bytes
Desc: not available
URL: <http://lists.linux.it/pipermail/ltp/attachments/20151006/b4f9820d/attachment.bin>
PATCH v2 1/1 syscalls/setregid02: Fix retrieving a group of user "nobody"
Hi!
Review
Quoted 2 lines
(quoted diff) +1
-1-static struct group nobody, root, bin; +static struct group ltpgroup, root, bin, *junk;
I've changed the newly introduced function so that they use local variable instead of global one and pushed, thanks.
Signature · 2 lines
Cyril Hrubis [email protected]