Skip to contentSkip to conversation

drivers/nfc/s3fwrn5/Makefile: remove superfluous cflags

PATCH Applied Valentin Rothberg 3 participants 4 messages Aug 25, 2015 – Oct 6, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/nfc/s3fwrn5/Makefile: remove superfluous cflags

NFC_DEBUG is not defined in Kconfig and since DEBUG is not used anywhere in this directory, we can safely remove this line.

---
I detected the issue with scripts/checkkconfigsymbols.py

 drivers/nfc/s3fwrn5/Makefile | 2 --
 1 file changed, 2 deletions(-)
drivers/nfc/s3fwrn5/Makefile +0 -2
index 3381c34faf62..ddfa7be7dd05 100644
@@ -7,5 +7,3 @@ s3fwrn5_i2c-objs = i2c.o
 
 obj-$(CONFIG_NFC_S3FWRN5) += s3fwrn5.o
 obj-$(CONFIG_NFC_S3FWRN5_I2C) += s3fwrn5_i2c.o
-
-ccflags-$(CONFIG_NFC_DEBUG) := -DDEBUG
Signature · 1 line
1.9.1
Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Valentin Rothberg

NFC_DEBUG is not defined in Kconfig and since DEBUG is not used anywhere in this directory, we can safely remove this line.

Thanks,
Robert Baldyga

Quoted 17 lines

---
I detected the issue with scripts/checkkconfigsymbols.py

 drivers/nfc/s3fwrn5/Makefile | 2 --
 1 file changed, 2 deletions(-)
drivers/nfc/s3fwrn5/Makefile +0 -2
index 3381c34faf62..ddfa7be7dd05 100644
@@ -7,5 +7,3 @@ s3fwrn5_i2c-objs = i2c.o
 
 obj-$(CONFIG_NFC_S3FWRN5) += s3fwrn5.o
 obj-$(CONFIG_NFC_S3FWRN5_I2C) += s3fwrn5_i2c.o
-
-ccflags-$(CONFIG_NFC_DEBUG) := -DDEBUG
#2 lore raw

[ +cc Samuel Ortiz and <[email protected]> ]

Hi Samuel,

Could you please apply this patch?

Thanks,
Robert

Quoted 29 lines · Robert Baldyga
Quoted 4 lines · Valentin Rothberg

NFC_DEBUG is not defined in Kconfig and since DEBUG is not used anywhere in this directory, we can safely remove this line.

Thanks,
Robert Baldyga

Quoted 17 lines

---
I detected the issue with scripts/checkkconfigsymbols.py

 drivers/nfc/s3fwrn5/Makefile | 2 --
 1 file changed, 2 deletions(-)
drivers/nfc/s3fwrn5/Makefile +0 -2
index 3381c34faf62..ddfa7be7dd05 100644
@@ -7,5 +7,3 @@ s3fwrn5_i2c-objs = i2c.o
 
 obj-$(CONFIG_NFC_S3FWRN5) += s3fwrn5.o
 obj-$(CONFIG_NFC_S3FWRN5_I2C) += s3fwrn5_i2c.o
-
-ccflags-$(CONFIG_NFC_DEBUG) := -DDEBUG
Applied
#3 lore raw

Hi Robert,

Quoted 5 lines · Robert Baldyga

[ +cc Samuel Ortiz and <[email protected]> ]

Hi Samuel,

Could you please apply this patch?

Applied, thanks.

Cheers,
Samuel.