gpio: Add GPIO support for the ACCES 104-IDIO-16

PATCH Superseded William Breathitt Gray 3 participants 6 messages Oct 7, 2015 – Oct 16, 2015

Subsystems (2)

GPIO Acces 104-idio-16 GPIO driver

lore

Share & tools

lore

William Breathitt Gray

author

2015-10-07 02:41 UTC #0 lore raw

PATCH v4 1/1 gpio: Add GPIO support for the ACCES 104-IDIO-16

The ACCES 104-IDIO-16 family of PC/104 utility boards feature 16 optically isolated inputs and 16 optically isolated FET solid state outputs. This driver provides GPIO support for these 32 channels of digital I/O. Change-of-State detection interrupts are not supported.

GPIO 0-15 correspond to digital outputs 0-15, while GPIO 16-31 correspond to digital inputs 0-15. The base port address for the device may be set via the a_104_idio_16_base module parameter.

Signed-off-by William Breathitt Gray <[email protected]>

---
Changes in v4:
- Replace compile-time constant CONFIG_104_IDIO_16_BASE with module

    paramater a_104_idio_16_base
  - Return -ENODEV when gpio_get is called on outputs
  - Replace global constant A_104_IDIO_16_EXTENT with struct
    a_104_idio_16_gpio member extent

- Utilize platform API to reduce dependence on global data

 drivers/gpio/Kconfig            |  10 ++
 drivers/gpio/Makefile           |   1 +
 drivers/gpio/gpio-104-idio-16.c | 196 ++++++++++++++++++++++++++++++++++++++++
 3 files changed, 207 insertions(+)
 create mode 100644 drivers/gpio/gpio-104-idio-16.c

drivers/gpio/Kconfig +10 -0

index 8949b3f..dc843e0 100644
@@ -684,6 +684,16 @@ config GPIO_SX150X
 
 endmenu
 
+menu "ISA GPIO drivers"
+
+config GPIO_104_IDIO_16
+	tristate "ACCES 104-IDIO-16 GPIO support"
+	depends on X86
+	help
+	  Enables GPIO support for the ACCES 104-IDIO-16 family.
+
+endmenu
+
 menu "MFD GPIO expanders"
 
 config GPIO_ADP5520

drivers/gpio/Makefile +1 -0

index f79a7c4..6f2fea5 100644
@@ -12,6 +12,7 @@ obj-$(CONFIG_GPIO_ACPI)		+= gpiolib-acpi.o
 # Device drivers. Generally keep list sorted alphabetically
 obj-$(CONFIG_GPIO_GENERIC)	+= gpio-generic.o
 
+obj-$(CONFIG_GPIO_104_IDIO_16)	+= gpio-104-idio-16.o
 obj-$(CONFIG_GPIO_74X164)	+= gpio-74x164.o
 obj-$(CONFIG_GPIO_74XX_MMIO)	+= gpio-74xx-mmio.o
 obj-$(CONFIG_GPIO_ADNP)		+= gpio-adnp.o

drivers/gpio/gpio-104-idio-16.c new file +196 -0

196 lines not on this page · raw message

Signature · 1 line

2.4.9

kbuild test robot

build bot

2015-10-07 03:14 UTC #1 lore raw

[PATCH] gpio: fix platform_no_drv_owner.cocci warnings

drivers/gpio/gpio-104-idio-16.c:151:3-8: No need to set .owner here. The core will do it.

Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

CC William Breathitt Gray <[email protected]>

Signed-off-by Fengguang Wu <[email protected]>

---

 gpio-104-idio-16.c |    1 -
 1 file changed, 1 deletion(-)

drivers/gpio/gpio-104-idio-16.c +0 -1

@@ -148,7 +148,6 @@ static struct platform_device *a_104_idi
 static struct platform_driver a_104_idio_16_driver = {
 	.driver = {
 		.name = "104-idio-16",
-		.owner = THIS_MODULE
 	},
 	.remove = a_104_idio_16_remove
 };

Linus Walleij

2015-10-16 14:47 UTC #2 lore raw

Re: [PATCH] gpio: fix platform_no_drv_owner.cocci warnings

Quoted 8 lines · kbuild test robot

drivers/gpio/gpio-104-idio-16.c:151:3-8: No need to set .owner here. The core will do it.
Remove .owner field if calls are used which set it automatically
Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
CC William Breathitt Gray <[email protected]>
Signed-off-by Fengguang Wu <[email protected]>

This is confusing, I mix up the mails coming from my pushed git branches with this new stuff that is obviously checking patches I haven't even applied. It's better if these kbuild fixes are sent as Re: to the mail ID of the patch so it appears in the same thread as the offending patch on the mailing list.

Yours,
Linus Walleij

Fengguang Wu

build bot

2015-10-16 15:47 UTC #3 lore raw

Re: [kbuild-all] [PATCH] gpio: fix platform_no_drv_owner.cocci warnings

the patch email does not start with "Re:", however it does contain

On Fri, Oct 16, 2015 at 04:47:23PM +0200, Linus Walleij wrote:

> On Wed, Oct 7, 2015 at 5:14 AM, kbuild test robot <[email protected]> wrote:
> 
> > drivers/gpio/gpio-104-idio-16.c:151:3-8: No need to set .owner here. The core will do it.
> >
> >  Remove .owner field if calls are used which set it automatically
> >
> > Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> >
> > CC: William Breathitt Gray <[email protected]>
> > Signed-off-by: Fengguang Wu <[email protected]>
> 
> This is confusing, I mix up the mails coming from my pushed git branches
> with this new stuff that is obviously checking patches I haven't even applied.
> It's better if these kbuild fixes are sent as Re: to the mail ID of the
> patch so it appears in the same thread as the offending patch on the
> mailing list.

Hi Linus, the patch email does not start with "Re:", however it does contain

        In-Reply-To: <[email protected]>

So it should show up in the same thread as this email?

[RFC 2/2] drm/bridge: Add I2C based driver for ps8640 bridge

Thanks,
Fengguang

Fengguang Wu

build bot

2015-10-16 15:53 UTC #4 lore raw

Re: [kbuild-all] [PATCH] gpio: fix platform_no_drv_owner.cocci warnings

Sorry it's not that email, but here is the mutt thread view in my mbox:

On Fri, Oct 16, 2015 at 11:47:23PM +0800, Fengguang Wu wrote:

> On Fri, Oct 16, 2015 at 04:47:23PM +0200, Linus Walleij wrote:
> > On Wed, Oct 7, 2015 at 5:14 AM, kbuild test robot <[email protected]> wrote:
> > 
> > > drivers/gpio/gpio-104-idio-16.c:151:3-8: No need to set .owner here. The core will do it.
> > >
> > >  Remove .owner field if calls are used which set it automatically
> > >
> > > Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> > >
> > > CC: William Breathitt Gray <[email protected]>
> > > Signed-off-by: Fengguang Wu <[email protected]>
> > 
> > This is confusing, I mix up the mails coming from my pushed git branches
> > with this new stuff that is obviously checking patches I haven't even applied.
> > It's better if these kbuild fixes are sent as Re: to the mail ID of the
> > patch so it appears in the same thread as the offending patch on the
> > mailing list.
> 
> Hi Linus, the patch email does not start with "Re:", however it does contain
> 
>         In-Reply-To: <[email protected]>
> 
> So it should show up in the same thread as this email?
> 
>         [RFC 2/2] drm/bridge: Add I2C based driver for ps8640 bridge

Sorry it's not that email, but here is the mutt thread view in my mbox:

Oct 06 William Breathi (7.8K:0) [PATCH v4] gpio: Add GPIO support for the ACCES 104-IDIO-16 Oct 07 kbuild test rob (0.9K:0) |->[PATCH] gpio: fix platform_no_drv_owner.cocci warnings
Oct 16 Fengguang Wu (1.3K:0) | `->Re: [kbuild-all] [PATCH] gpio: fix platform_no_drv_owner.cocci warnings
Oct 07 kbuild test rob (0.7K:0) `->Re: [PATCH v4] gpio: Add GPIO support for the ACCES 104-IDIO-16

Thanks,
Fengguang

kbuild test robot

build bot

2015-10-07 03:15 UTC #5 lore raw

In reply to William Breathitt Gray

coccinelle warnings: (new ones prefixed by >>)

Hi William,

[auto build test WARNING on v4.3-rc4 -- if it's inappropriate base, please ignore]

coccinelle warnings: (new ones prefixed by >>)

>> drivers/gpio/gpio-104-idio-16.c:151:3-8: No need to set .owner here. The core will do it.

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation