drm/i915/snb: remove pre-production hardware workaround
Subsystems (2)
PATCH 1/3 drm/i915/snb: remove pre-production hardware workaround
--- drivers/gpu/drm/i915/i915_gem.c | 18 +----------------- 1 file changed, 1 insertion(+), 17 deletions(-)
drivers/gpu/drm/i915/i915_gem.c +1 -17
@@ -4558,22 +4558,6 @@ void i915_gem_init_swizzling(struct drm_device *dev)BUG (); } -static bool -intel_enable_blt (struct drm_device *dev) -{ -if (!HAS_BLT (dev)) -return false; - -/* The blitter was dysfunctional on early prototypes */ -if (IS_GEN6 (dev) && dev->pdev->revision <8 ) { -DRM_INFO ("BLT not supported on this pre-production hardware;" -" graphics performance will be degraded.\n" ); -return false; - } - -return true; -} -static void init_unused_ring (struct drm_device *dev,u32 base) {struct drm_i915_private *dev_priv = dev->dev_private;
@@ -4616,7 +4600,7 @@ int i915_gem_init_rings(struct drm_device *dev) goto cleanup_render_ring; } -if (intel_enable_blt (dev)) { +if (HAS_BLT (dev)) { ret =intel_init_blt_ring_buffer (dev);if (ret) goto cleanup_bsd_ring;
Signature · 6 lines
2.1.4 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/3 drm/i915/vlv: remove pre-production hardware workaround
--- drivers/gpu/drm/i915/i915_gem_gtt.c | 7 ------- 1 file changed, 7 deletions(-)
drivers/gpu/drm/i915/i915_gem_gtt.c +0 -7
@@ -133,13 +133,6 @@ static int sanitize_enable_ppgtt(struct drm_device *dev, int enable_ppgtt) }#endif -/* Early VLV doesn't have this */ -if (IS_VALLEYVIEW (dev) && !IS_CHERRYVIEW (dev) && - dev->pdev->revision <0xb ) { -DRM_DEBUG_DRIVER ("disabling PPGTT on pre-B3 step VLV\n" ); -return 0 ; - } -if (INTEL_INFO (dev)->gen >=8 && i915.enable_execlists)return 2 ;else
Signature · 6 lines
2.1.4 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 2/3] drm/i915/vlv: remove pre-production hardware workaround
Quoted 10 lines · Jani Nikula
Signed-off-by Jani Nikula <[email protected]>--- drivers/gpu/drm/i915/i915_gem_gtt.c | 7 ------- 1 file changed, 7 deletions(-)drivers/gpu/drm/i915/i915_gem_gtt.c +0
-0
drivers/gpu/drm/i915/i915_gem_gtt.c static int sanitize_enable_ppgtt(struct drm_device *dev, int enable_ppgtt) · line 141
Quoted 9 lines
drivers/gpu/drm/i915/i915_gem_gtt.c +0
-6@@ -133,13 +133,6 @@ static int sanitize_enable_ppgtt(struct drm_device *dev, int enable_ppgtt) }#endif -/* Early VLV doesn't have this */ -if (IS_VALLEYVIEW (dev) && !IS_CHERRYVIEW (dev) && - dev->pdev->revision <0xb ) { -DRM_DEBUG_DRIVER ("disabling PPGTT on pre-B3 step VLV\n" ); -return 0 ; - }
IIRC B2 may have gotten out into the wild, so we can't kill this check unfortunately. Well, unless it magically got fixed in the meantime. I don't think anyone ever figured out what the problems was with PPGTT on B2 and earlier.
So NAK, unless someone knows better.
Quoted 6 lines
drivers/gpu/drm/i915/i915_gem_gtt.c +0
-1-if (INTEL_INFO (dev)->gen >=8 && i915.enable_execlists)return 2 ;else Signature · 1 line
2.1.4
Signature · 6 lines
Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 2/3] drm/i915/vlv: remove pre-production hardware workaround
Quoted 14 lines · Ville Syrjälä
Quoted 13 lines · Jani Nikula
Signed-off-by Jani Nikula <[email protected]>--- drivers/gpu/drm/i915/i915_gem_gtt.c | 7 ------- 1 file changed, 7 deletions(-)drivers/gpu/drm/i915/i915_gem_gtt.c +0
-0@@ -133,13 +133,6 @@ static int sanitize_enable_ppgtt(struct drm_device *dev, int enable_ppgtt) }#endif
Quoted 11 lines
drivers/gpu/drm/i915/i915_gem_gtt.c static int sanitize_enable_ppgtt(struct drm_device *dev, int enable_ppgtt) · line 141
Quoted 6 lines
drivers/gpu/drm/i915/i915_gem_gtt.c +0
-6-/* Early VLV doesn't have this */ -if (IS_VALLEYVIEW (dev) && !IS_CHERRYVIEW (dev) && - dev->pdev->revision <0xb ) { -DRM_DEBUG_DRIVER ("disabling PPGTT on pre-B3 step VLV\n" ); -return 0 ; - }IIRC B2 may have gotten out into the wild, so we can't kill this check unfortunately. Well, unless it magically got fixed in the meantime. I don't think anyone ever figured out what the problems was with PPGTT on B2 and earlier.
Note "into the wild" isn't valid imo - we've had snb workarounds that we killed which made a few sdvs used by distros and oems broken. I applied it anyway.
It's only for stuff that's sold in general that I'm counting as "shipped hw".
-Daniel
Quoted 17 lines
So NAK, unless someone knows better.
Quoted 6 lines
drivers/gpu/drm/i915/i915_gem_gtt.c +0
-1-if (INTEL_INFO (dev)->gen >=8 && i915.enable_execlists)return 2 ;else Signature · 1 line
2.1.4Signature · 6 lines
Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 2/3] drm/i915/vlv: remove pre-production hardware workaround
Quoted 27 lines · Daniel Vetter
Quoted 14 lines · Ville Syrjälä
Quoted 13 lines · Jani Nikula
Signed-off-by Jani Nikula <[email protected]>--- drivers/gpu/drm/i915/i915_gem_gtt.c | 7 ------- 1 file changed, 7 deletions(-)drivers/gpu/drm/i915/i915_gem_gtt.c +0
-0@@ -133,13 +133,6 @@ static int sanitize_enable_ppgtt(struct drm_device *dev, int enable_ppgtt) }#endif Quoted 11 lines
drivers/gpu/drm/i915/i915_gem_gtt.c static int sanitize_enable_ppgtt(struct drm_device *dev, int enable_ppgtt) · line 141
Quoted 6 lines
drivers/gpu/drm/i915/i915_gem_gtt.c +0
-6-/* Early VLV doesn't have this */ -if (IS_VALLEYVIEW (dev) && !IS_CHERRYVIEW (dev) && - dev->pdev->revision <0xb ) { -DRM_DEBUG_DRIVER ("disabling PPGTT on pre-B3 step VLV\n" ); -return 0 ; - }IIRC B2 may have gotten out into the wild, so we can't kill this check unfortunately. Well, unless it magically got fixed in the meantime. I don't think anyone ever figured out what the problems was with PPGTT on B2 and earlier.
Quoted 6 lines
Note "into the wild" isn't valid imo - we've had snb workarounds that we killed which made a few sdvs used by distros and oems broken. I applied it anyway.
It's only for stuff that's sold in general that I'm counting as "shipped hw".
My statement was meant as "shipped". Poor choice of words.
Signature · 6 lines
Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 3/3 drm/i915/chv: remove pre-production hardware workarounds
In reply to Jani Nikula--- drivers/gpu/drm/i915/intel_pm.c | 55 +++++++++++++++++------------------------ 1 file changed, 22 insertions(+), 33 deletions(-)
drivers/gpu/drm/i915/intel_pm.c +22 -33
@@ -5061,32 +5061,27 @@ static int cherryview_rps_max_freq(struct drm_i915_private *dev_priv)struct drm_device *dev = dev_priv->dev;u32 val, rp0; -if (dev->pdev->revision >=0x20 ) { - val =vlv_punit_read (dev_priv,FB_GFX_FMAX_AT_VMAX_FUSE ); + val =vlv_punit_read (dev_priv,FB_GFX_FMAX_AT_VMAX_FUSE ); -switch (INTEL_INFO (dev)->eu_total) { -case 8 : -/* (2 * 4) config */ - rp0 = (val >>FB_GFX_FMAX_AT_VMAX_2SS4EU_FUSE_SHIFT ); -break ; -case 12 : -/* (2 * 6) config */ - rp0 = (val >>FB_GFX_FMAX_AT_VMAX_2SS6EU_FUSE_SHIFT ); -break ; -case 16 : -/* (2 * 8) config */ -default : -/* Setting (2 * 8) Min RP0 for any other combination */ - rp0 = (val >>FB_GFX_FMAX_AT_VMAX_2SS8EU_FUSE_SHIFT ); -break ; - } - rp0 = (rp0 &FB_GFX_FREQ_FUSE_MASK ); - }else { -/* For pre-production hardware */ - val =vlv_punit_read (dev_priv,PUNIT_GPU_STATUS_REG ); - rp0 = (val >>PUNIT_GPU_STATUS_MAX_FREQ_SHIFT ) & -PUNIT_GPU_STATUS_MAX_FREQ_MASK ; +switch (INTEL_INFO (dev)->eu_total) { +case 8 : +/* (2 * 4) config */ + rp0 = (val >>FB_GFX_FMAX_AT_VMAX_2SS4EU_FUSE_SHIFT ); +break ; +case 12 : +/* (2 * 6) config */ + rp0 = (val >>FB_GFX_FMAX_AT_VMAX_2SS6EU_FUSE_SHIFT ); +break ; +case 16 : +/* (2 * 8) config */ +default : +/* Setting (2 * 8) Min RP0 for any other combination */ + rp0 = (val >>FB_GFX_FMAX_AT_VMAX_2SS8EU_FUSE_SHIFT ); +break ; } + + rp0 = (rp0 &FB_GFX_FREQ_FUSE_MASK ); +return rp0; }
@@ -5105,15 +5100,9 @@ static int cherryview_rps_guar_freq(struct drm_i915_private *dev_priv)struct drm_device *dev = dev_priv->dev;u32 val, rp1; -if (dev->pdev->revision >=0x20 ) { - val =vlv_punit_read (dev_priv,FB_GFX_FMAX_AT_VMAX_FUSE ); - rp1 = (val &FB_GFX_FREQ_FUSE_MASK ); - }else { -/* For pre-production hardware */ - val =vlv_punit_read (dev_priv,PUNIT_REG_GPU_FREQ_STS ); - rp1 = ((val >>PUNIT_GPU_STATUS_MAX_FREQ_SHIFT ) & -PUNIT_GPU_STATUS_MAX_FREQ_MASK ); - } + val =vlv_punit_read (dev_priv,FB_GFX_FMAX_AT_VMAX_FUSE ); + rp1 = (val &FB_GFX_FREQ_FUSE_MASK ); +return rp1; }
Signature · 6 lines
2.1.4 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
kbuild test robot
build botRe: [PATCH 3/3] drm/i915/chv: remove pre-production hardware workarounds
config: x86_64-randconfig-x006-201540 (attached as .config) reproduce:
Hi Jani,
[auto build test WARNING on v4.3-rc4 -- if it's inappropriate base, please ignore]
config: x86_64-randconfig-x006-201540 (attached as .config) reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64 All warnings (new ones prefixed by >>):
drivers/gpu/drm/i915/intel_pm.c: In function 'cherryview_rps_guar_freq':
>> drivers/gpu/drm/i915/intel_pm.c:5187:21: warning: unused variable 'dev' [-Wunused-variable]
struct drm_device *dev = dev_priv->dev;
^vim +/dev +5187 drivers/gpu/drm/i915/intel_pm.c
965cb130 Jani Nikula 2015-10-07 5171
2b6b3a09 Deepak S 2014-05-27 5172 return rp0;
2b6b3a09 Deepak S 2014-05-27 5173 }
2b6b3a09 Deepak S 2014-05-27 5174
2b6b3a09 Deepak S 2014-05-27 5175 static int cherryview_rps_rpe_freq(struct drm_i915_private *dev_priv)
2b6b3a09 Deepak S 2014-05-27 5176 {
2b6b3a09 Deepak S 2014-05-27 5177 u32 val, rpe;
2b6b3a09 Deepak S 2014-05-27 5178
2b6b3a09 Deepak S 2014-05-27 5179 val = vlv_punit_read(dev_priv, PUNIT_GPU_DUTYCYCLE_REG);
2b6b3a09 Deepak S 2014-05-27 5180 rpe = (val >> PUNIT_GPU_DUTYCYCLE_RPE_FREQ_SHIFT) & PUNIT_GPU_DUTYCYCLE_RPE_FREQ_MASK;
2b6b3a09 Deepak S 2014-05-27 5181
2b6b3a09 Deepak S 2014-05-27 5182 return rpe;
2b6b3a09 Deepak S 2014-05-27 5183 }
2b6b3a09 Deepak S 2014-05-27 5184
7707df4a Deepak S 2014-07-12 5185 static int cherryview_rps_guar_freq(struct drm_i915_private *dev_priv)
7707df4a Deepak S 2014-07-12 5186 {
095acd5f Deepak S 2015-01-17 @5187 struct drm_device *dev = dev_priv->dev;
7707df4a Deepak S 2014-07-12 5188 u32 val, rp1;
7707df4a Deepak S 2014-07-12 5189
095acd5f Deepak S 2015-01-17 5190 val = vlv_punit_read(dev_priv, FB_GFX_FMAX_AT_VMAX_FUSE);
095acd5f Deepak S 2015-01-17 5191 rp1 = (val & FB_GFX_FREQ_FUSE_MASK);
965cb130 Jani Nikula 2015-10-07 5192
7707df4a Deepak S 2014-07-12 5193 return rp1;
7707df4a Deepak S 2014-07-12 5194 }
7707df4a Deepak S 2014-07-12 5195 :::::: The code at line 5187 was first introduced by commit
:::::: 095acd5f8739aa8322820d460e617898baf092df drm/i915: New offset for reading frequencies on CHV.
:::::: TO: Deepak S <[email protected]>
:::::: CC: Daniel Vetter <[email protected]>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 3/3] drm/i915/chv: remove pre-production hardware workarounds
In reply to Jani NikulaQuoted 10 lines · Jani Nikula
Signed-off-by Jani Nikula <[email protected]>--- drivers/gpu/drm/i915/intel_pm.c | 55 +++++++++++++++++------------------------ 1 file changed, 22 insertions(+), 33 deletions(-)drivers/gpu/drm/i915/intel_pm.c +0
-0
drivers/gpu/drm/i915/intel_pm.c static int cherryview_rps_max_freq(struct drm_i915_private *dev_priv) · line 5064
Quoted 4 lines
drivers/gpu/drm/i915/intel_pm.c +0
-1@@ -5061,32 +5061,27 @@ static int cherryview_rps_max_freq(struct drm_i915_private *dev_priv)struct drm_device *dev = dev_priv->dev;u32 val, rp0; -if (dev->pdev->revision >=0x20 ) {
Yep. C0 is the first production stepping.
Quoted 68 lines
drivers/gpu/drm/i915/intel_pm.c +22
-32- val =vlv_punit_read (dev_priv,FB_GFX_FMAX_AT_VMAX_FUSE ); + val =vlv_punit_read (dev_priv,FB_GFX_FMAX_AT_VMAX_FUSE ); -switch (INTEL_INFO (dev)->eu_total) { -case 8 : -/* (2 * 4) config */ - rp0 = (val >>FB_GFX_FMAX_AT_VMAX_2SS4EU_FUSE_SHIFT ); -break ; -case 12 : -/* (2 * 6) config */ - rp0 = (val >>FB_GFX_FMAX_AT_VMAX_2SS6EU_FUSE_SHIFT ); -break ; -case 16 : -/* (2 * 8) config */ -default : -/* Setting (2 * 8) Min RP0 for any other combination */ - rp0 = (val >>FB_GFX_FMAX_AT_VMAX_2SS8EU_FUSE_SHIFT ); -break ; - } - rp0 = (rp0 &FB_GFX_FREQ_FUSE_MASK ); - }else { -/* For pre-production hardware */ - val =vlv_punit_read (dev_priv,PUNIT_GPU_STATUS_REG ); - rp0 = (val >>PUNIT_GPU_STATUS_MAX_FREQ_SHIFT ) & -PUNIT_GPU_STATUS_MAX_FREQ_MASK ; +switch (INTEL_INFO (dev)->eu_total) { +case 8 : +/* (2 * 4) config */ + rp0 = (val >>FB_GFX_FMAX_AT_VMAX_2SS4EU_FUSE_SHIFT ); +break ; +case 12 : +/* (2 * 6) config */ + rp0 = (val >>FB_GFX_FMAX_AT_VMAX_2SS6EU_FUSE_SHIFT ); +break ; +case 16 : +/* (2 * 8) config */ +default : +/* Setting (2 * 8) Min RP0 for any other combination */ + rp0 = (val >>FB_GFX_FMAX_AT_VMAX_2SS8EU_FUSE_SHIFT ); +break ; } + + rp0 = (rp0 &FB_GFX_FREQ_FUSE_MASK ); +return rp0; }@@ -5105,15 +5100,9 @@ static int cherryview_rps_guar_freq(struct drm_i915_private *dev_priv)struct drm_device *dev = dev_priv->dev;u32 val, rp1; -if (dev->pdev->revision >=0x20 ) { - val =vlv_punit_read (dev_priv,FB_GFX_FMAX_AT_VMAX_FUSE ); - rp1 = (val &FB_GFX_FREQ_FUSE_MASK ); - }else { -/* For pre-production hardware */ - val =vlv_punit_read (dev_priv,PUNIT_REG_GPU_FREQ_STS ); - rp1 = ((val >>PUNIT_GPU_STATUS_MAX_FREQ_SHIFT ) & -PUNIT_GPU_STATUS_MAX_FREQ_MASK ); - } + val =vlv_punit_read (dev_priv,FB_GFX_FMAX_AT_VMAX_FUSE ); + rp1 = (val &FB_GFX_FREQ_FUSE_MASK ); +return rp1; }Signature · 1 line
2.1.4
Signature · 6 lines
Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 3/3] drm/i915/chv: remove pre-production hardware workarounds
Quoted 14 lines · Ville Syrjälä
Quoted 13 lines · Jani Nikula
Signed-off-by Jani Nikula <[email protected]>--- drivers/gpu/drm/i915/intel_pm.c | 55 +++++++++++++++++------------------------ 1 file changed, 22 insertions(+), 33 deletions(-)drivers/gpu/drm/i915/intel_pm.c +0
-0@@ -5061,32 +5061,27 @@ static int cherryview_rps_max_freq(struct drm_i915_private *dev_priv)struct drm_device *dev = dev_priv->dev;u32 val, rp0;
Quoted 5 lines
drivers/gpu/drm/i915/intel_pm.c static int cherryview_rps_max_freq(struct drm_i915_private *dev_priv) · line 5064
Quoted 1 line
drivers/gpu/drm/i915/intel_pm.c +0
-1-if (dev->pdev->revision >=0x20 ) {Yep. C0 is the first production stepping.
Reviewed-by Ville Syrjälä <[email protected]>
Applied both patch 1&3 from this series, with gcc appeased on this patch here.
Thanks, Daniel
Quoted 77 lines
Quoted 69 lines
drivers/gpu/drm/i915/intel_pm.c +22
-32- val =vlv_punit_read (dev_priv,FB_GFX_FMAX_AT_VMAX_FUSE ); + val =vlv_punit_read (dev_priv,FB_GFX_FMAX_AT_VMAX_FUSE ); -switch (INTEL_INFO (dev)->eu_total) { -case 8 : -/* (2 * 4) config */ - rp0 = (val >>FB_GFX_FMAX_AT_VMAX_2SS4EU_FUSE_SHIFT ); -break ; -case 12 : -/* (2 * 6) config */ - rp0 = (val >>FB_GFX_FMAX_AT_VMAX_2SS6EU_FUSE_SHIFT ); -break ; -case 16 : -/* (2 * 8) config */ -default : -/* Setting (2 * 8) Min RP0 for any other combination */ - rp0 = (val >>FB_GFX_FMAX_AT_VMAX_2SS8EU_FUSE_SHIFT ); -break ; - } - rp0 = (rp0 &FB_GFX_FREQ_FUSE_MASK ); - }else { -/* For pre-production hardware */ - val =vlv_punit_read (dev_priv,PUNIT_GPU_STATUS_REG ); - rp0 = (val >>PUNIT_GPU_STATUS_MAX_FREQ_SHIFT ) & -PUNIT_GPU_STATUS_MAX_FREQ_MASK ; +switch (INTEL_INFO (dev)->eu_total) { +case 8 : +/* (2 * 4) config */ + rp0 = (val >>FB_GFX_FMAX_AT_VMAX_2SS4EU_FUSE_SHIFT ); +break ; +case 12 : +/* (2 * 6) config */ + rp0 = (val >>FB_GFX_FMAX_AT_VMAX_2SS6EU_FUSE_SHIFT ); +break ; +case 16 : +/* (2 * 8) config */ +default : +/* Setting (2 * 8) Min RP0 for any other combination */ + rp0 = (val >>FB_GFX_FMAX_AT_VMAX_2SS8EU_FUSE_SHIFT ); +break ; } + + rp0 = (rp0 &FB_GFX_FREQ_FUSE_MASK ); +return rp0; }@@ -5105,15 +5100,9 @@ static int cherryview_rps_guar_freq(struct drm_i915_private *dev_priv)struct drm_device *dev = dev_priv->dev;u32 val, rp1; -if (dev->pdev->revision >=0x20 ) { - val =vlv_punit_read (dev_priv,FB_GFX_FMAX_AT_VMAX_FUSE ); - rp1 = (val &FB_GFX_FREQ_FUSE_MASK ); - }else { -/* For pre-production hardware */ - val =vlv_punit_read (dev_priv,PUNIT_REG_GPU_FREQ_STS ); - rp1 = ((val >>PUNIT_GPU_STATUS_MAX_FREQ_SHIFT ) & -PUNIT_GPU_STATUS_MAX_FREQ_MASK ); - } + val =vlv_punit_read (dev_priv,FB_GFX_FMAX_AT_VMAX_FUSE ); + rp1 = (val &FB_GFX_FREQ_FUSE_MASK ); +return rp1; }Signature · 1 line
2.1.4Signature · 6 lines
Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 11 lines · Jani Nikula
Signed-off-by Jani Nikula <[email protected]>--- drivers/gpu/drm/i915/i915_gem.c | 18 +----------------- 1 file changed, 1 insertion(+), 17 deletions(-)drivers/gpu/drm/i915/i915_gem.c +0
-0@@ -4558,22 +4558,6 @@ void i915_gem_init_swizzling(struct drm_device *dev)BUG ();
drivers/gpu/drm/i915/i915_gem.c void i915_gem_init_swizzling(struct drm_device *dev) · line 4568
Quoted 10 lines
drivers/gpu/drm/i915/i915_gem.c +0
-8} -static bool -intel_enable_blt (struct drm_device *dev) -{ -if (!HAS_BLT (dev)) -return false; - -/* The blitter was dysfunctional on early prototypes */ -if (IS_GEN6 (dev) && dev->pdev->revision <8 ) {
I'm not actually sure what the revi<->stepping mapping on SNB is. My SNB is a D2 I believe, and it has rev=0x9, so 0x8 is probably D1. I think D2 was the first production stepping, and D1 may have gotten out as samples. So this would perhaps affect D0 and older steppings, which seems fine to me.
Quoted 22 lines
drivers/gpu/drm/i915/i915_gem.c +1
-9-DRM_INFO ("BLT not supported on this pre-production hardware;" -" graphics performance will be degraded.\n" ); -return false; - } - -return true; -} -static void init_unused_ring (struct drm_device *dev,u32 base) {struct drm_i915_private *dev_priv = dev->dev_private;@@ -4616,7 +4600,7 @@ int i915_gem_init_rings(struct drm_device *dev) goto cleanup_render_ring; } -if (intel_enable_blt (dev)) { +if (HAS_BLT (dev)) { ret =intel_init_blt_ring_buffer (dev);if (ret) goto cleanup_bsd_ring;Signature · 1 line
2.1.4
Signature · 6 lines
Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx