Add DA9021 support to the existing DA9052/53 driver

PATCH Applied Steve Twiss 3 participants 9 messages Oct 8, 2015 – Oct 13, 2015

Subsystems (3)

Multifunction devices (MFD) Voltage and current regulator framework Dialog semiconductor drivers

lore

Share & tools

lore

Steve Twiss

author

2015-10-08 15:23 UTC #0 lore raw

cover Add DA9021 support to the existing DA9052/53 driver

From: Steve Twiss <[email protected]>

Two patches to add missing registers and add support for DA9053-BB silicon in the regulators component. These patches modify existing files for the Dialog Power Management IC driver for the DA9052/53 devices.

In this patch set the following is provided:
- [PATCH V1 1/3]: Addition of extra registers for GPIOs 8-13
- [PATCH V1 2/3]: Add regulator support for DA9053 BB silicon

This patch applies against linux-next and v4.3-rc4

Thank you,
Steve Twiss, Dialog Semiconductor Ltd.

Steve Twiss (2):
mfd: da9053: Addition of extra registers for GPIOs 8-13
regulator: da9053: Add regulator support for DA9053 BB silicon

 drivers/mfd/da9052-core.c            | 6 ++++++
 drivers/regulator/da9052-regulator.c | 1 +
 include/linux/mfd/da9052/reg.h       | 3 +++
 3 files changed, 10 insertions(+)

Signature · 1 line

end-of-patch for PATCH V1

Steve Twiss

author

2015-10-08 15:23 UTC #1 lore raw

PATCH 1/2 mfd: da9053: Addition of extra registers for GPIOs 8-13

From: Steve Twiss <[email protected]>

Definitions for GPIO registers 8, 9, 10, 11, 12 and 13 are added into the register header file.

- DA9052_GPIO_8_9_REG    25
- DA9052_GPIO_10_11_REG  26
- DA9052_GPIO_12_13_REG  27

A modification is also made to the MFD core code to define these registers as readable and writable. The functions for da9052_reg_readable() and da9052_reg_writeable() have had their case statements altered to include these new registers.

Signed-off-by Steve Twiss <[email protected]>

---
This patch applies against linux-next and v4.3-rc4

 drivers/mfd/da9052-core.c      | 6 ++++++
 include/linux/mfd/da9052/reg.h | 3 +++
 2 files changed, 9 insertions(+)

drivers/mfd/da9052-core.c +6 -0

index 46e3840..c0bf68a 100644
@@ -51,6 +51,9 @@ static bool da9052_reg_readable(struct device *dev, unsigned int reg)
 	case DA9052_GPIO_2_3_REG:
 	case DA9052_GPIO_4_5_REG:
 	case DA9052_GPIO_6_7_REG:
+	case DA9052_GPIO_8_9_REG:
+	case DA9052_GPIO_10_11_REG:
+	case DA9052_GPIO_12_13_REG:
 	case DA9052_GPIO_14_15_REG:
 	case DA9052_ID_0_1_REG:
 	case DA9052_ID_2_3_REG:

@@ -178,6 +181,9 @@ static bool da9052_reg_writeable(struct device *dev, unsigned int reg)
 	case DA9052_GPIO_2_3_REG:
 	case DA9052_GPIO_4_5_REG:
 	case DA9052_GPIO_6_7_REG:
+	case DA9052_GPIO_8_9_REG:
+	case DA9052_GPIO_10_11_REG:
+	case DA9052_GPIO_12_13_REG:
 	case DA9052_GPIO_14_15_REG:
 	case DA9052_ID_0_1_REG:
 	case DA9052_ID_2_3_REG:

include/linux/mfd/da9052/reg.h +3 -0

index c4dd3a8..5010f97 100644
@@ -65,6 +65,9 @@
 #define DA9052_GPIO_2_3_REG		22
 #define DA9052_GPIO_4_5_REG		23
 #define DA9052_GPIO_6_7_REG		24
+#define DA9052_GPIO_8_9_REG		25
+#define DA9052_GPIO_10_11_REG		26
+#define DA9052_GPIO_12_13_REG		27
 #define DA9052_GPIO_14_15_REG		28
 
 /* POWER SEQUENCER CONTROL REGISTERS */

Signature · 1 line

end-of-patch for PATCH V1

Lee Jones

Applied

2015-10-13 07:32 UTC #2 lore raw

Re: [PATCH V1 1/2] mfd: da9053: Addition of extra registers for GPIOs 8-13

Quoted 16 lines · Steve Twiss

From: Steve Twiss <[email protected]>
Definitions for GPIO registers 8, 9, 10, 11, 12 and 13 are added into the register header file.
- DA9052_GPIO_8_9_REG    25
- DA9052_GPIO_10_11_REG  26
- DA9052_GPIO_12_13_REG  27
A modification is also made to the MFD core code to define these registers as readable and writable. The functions for da9052_reg_readable() and da9052_reg_writeable() have had their case statements altered to include these new registers.
Signed-off-by Steve Twiss <[email protected]>

Quoted 7 lines

---
This patch applies against linux-next and v4.3-rc4
 drivers/mfd/da9052-core.c      | 6 ++++++
 include/linux/mfd/da9052/reg.h | 3 +++
 2 files changed, 9 insertions(+)

Applied, thanks.

Quoted 38 lines

drivers/mfd/da9052-core.c +6 -0

index 46e3840..c0bf68a 100644
@@ -51,6 +51,9 @@ static bool da9052_reg_readable(struct device *dev, unsigned int reg)
 	case DA9052_GPIO_2_3_REG:
 	case DA9052_GPIO_4_5_REG:
 	case DA9052_GPIO_6_7_REG:
+	case DA9052_GPIO_8_9_REG:
+	case DA9052_GPIO_10_11_REG:
+	case DA9052_GPIO_12_13_REG:
 	case DA9052_GPIO_14_15_REG:
 	case DA9052_ID_0_1_REG:
 	case DA9052_ID_2_3_REG:

@@ -178,6 +181,9 @@ static bool da9052_reg_writeable(struct device *dev, unsigned int reg)
 	case DA9052_GPIO_2_3_REG:
 	case DA9052_GPIO_4_5_REG:
 	case DA9052_GPIO_6_7_REG:
+	case DA9052_GPIO_8_9_REG:
+	case DA9052_GPIO_10_11_REG:
+	case DA9052_GPIO_12_13_REG:
 	case DA9052_GPIO_14_15_REG:
 	case DA9052_ID_0_1_REG:
 	case DA9052_ID_2_3_REG:

include/linux/mfd/da9052/reg.h +3 -0

index c4dd3a8..5010f97 100644
@@ -65,6 +65,9 @@
 #define DA9052_GPIO_2_3_REG		22
 #define DA9052_GPIO_4_5_REG		23
 #define DA9052_GPIO_6_7_REG		24
+#define DA9052_GPIO_8_9_REG		25
+#define DA9052_GPIO_10_11_REG		26
+#define DA9052_GPIO_12_13_REG		27
 #define DA9052_GPIO_14_15_REG		28
 
 /* POWER SEQUENCER CONTROL REGISTERS */

Signature · 4 lines

Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Opensource [Steve Twiss]

author

2015-10-13 08:21 UTC #3 lore raw

RE: [PATCH V1 1/2] mfd: da9053: Addition of extra registers for GPIOs 8-13

Quoted 27 lines · On 13 October 2015 08:32 Lee Jones wrote:

To: Opensource [Steve Twiss]
Cc: LINUXKERNEL; Samuel Ortiz; David Dajun Chen; Support Opensource
Subject: Re: [PATCH V1 1/2] mfd: da9053: Addition of extra registers for GPIOs 8-13
Quoted 20 lines · Steve Twiss
From: Steve Twiss <[email protected]>
Definitions for GPIO registers 8, 9, 10, 11, 12 and 13 are added into the register header file.
- DA9052_GPIO_8_9_REG    25
- DA9052_GPIO_10_11_REG  26
- DA9052_GPIO_12_13_REG  27
A modification is also made to the MFD core code to define these registers as readable and writable. The functions for da9052_reg_readable() and da9052_reg_writeable() have had their case statements altered to include these new registers.
Signed-off-by Steve Twiss <[email protected]>
---
This patch applies against linux-next and v4.3-rc4

Quoted 5 lines

Quoted 3 lines

 drivers/mfd/da9052-core.c      | 6 ++++++
 include/linux/mfd/da9052/reg.h | 3 +++
 2 files changed, 9 insertions(+)

Applied, thanks.

Thanks Lee.
Regards,
Steve ��{.n�+��+%��ݶ��w��{.n�+��{��G��{ay�ʇڙ�,j��f��h��z_�(�階�ݢj"��m��G��?��&��~��iO��z��v�^�m��?�I�

Steve Twiss

author

2015-10-08 15:23 UTC #4 lore raw

PATCH 2/2 regulator: da9053: Add regulator support for DA9053 BB silicon

In reply to Steve Twiss

From: Steve Twiss <[email protected]>

Provide an additional case entry for DA9053_BC in the find_regulator_info() function in order to support BB type silicon for the DA9053 device.

Signed-off-by Steve Twiss <[email protected]>

---
This patch applies against linux-next and v4.3-rc4

 drivers/regulator/da9052-regulator.c | 1 +
 1 file changed, 1 insertion(+)

drivers/regulator/da9052-regulator.c +1 -0

index e628d4c..12a25b4 100644
@@ -381,6 +381,7 @@ static inline struct da9052_regulator_info *find_regulator_info(u8 chip_id,
 	case DA9053_AA:
 	case DA9053_BA:
 	case DA9053_BB:
+	case DA9053_BC:
 		for (i = 0; i < ARRAY_SIZE(da9053_regulator_info); i++) {
 			info = &da9053_regulator_info[i];
 			if (info->reg_desc.id == id)

Signature · 1 line

end-of-patch for PATCH V1

Mark Brown

maintainer

2015-10-09 11:39 UTC #5 lore raw

In reply to Steve Twiss

Quoted 7 lines · Steve Twiss

From: Steve Twiss <[email protected]>
Two patches to add missing registers and add support for DA9053-BB silicon in the regulators component. These patches modify existing files for the Dialog Power Management IC driver for the DA9052/53 devices.

Quoted 5 lines

In this patch set the following is provided:
- [PATCH V1 1/3]: Addition of extra registers for GPIOs 8-13
- [PATCH V1 2/3]: Add regulator support for DA9053 BB silicon
This patch applies against linux-next and v4.3-rc4

Are there any dependencies between the two patches?

Opensource [Steve Twiss]

author

2015-10-09 12:52 UTC #6 lore raw

Quoted 13 lines · On 09 October 2015 12:36 Mark Brown wrote:

To: Opensource [Steve Twiss]
Cc: LINUXKERNEL; Lee Jones; Liam Girdwood; Samuel Ortiz; David Dajun Chen; Support Opensource
Subject: Re: [PATCH V1 0/2] Add DA9021 support to the existing DA9052/53 driver
Quoted 7 lines · Steve Twiss
From: Steve Twiss <[email protected]>
Two patches to add missing registers and add support for DA9053-BB silicon in the regulators component. These patches modify existing files for the Dialog Power Management IC driver for the DA9052/53 devices.

Quoted 7 lines

Quoted 5 lines
In this patch set the following is provided:
- [PATCH V1 1/3]: Addition of extra registers for GPIOs 8-13
- [PATCH V1 2/3]: Add regulator support for DA9053 BB silicon
This patch applies against linux-next and v4.3-rc4
Are there any dependencies between the two patches?

Nope.
I just thought because they were for MFD and regulators I would separate them. Do you want me to merge them into a single patch and re-send?

Regards,
Steve

Opensource [Steve Twiss]

author

2015-10-12 07:57 UTC #7 lore raw

Quoted 11 lines · On 09 October 2015 13:52 Steve Twiss wrote:

To: Mark Brown; Lee Jones
Cc: LINUXKERNEL; Liam Girdwood; Samuel Ortiz; David Dajun Chen; Support Opensource
Subject: RE: [PATCH V1 0/2] Add DA9021 support to the existing DA9052/53 driver
Quoted 5 lines · On 09 October 2015 12:36 Mark Brown wrote:
To: Opensource [Steve Twiss]
Cc: LINUXKERNEL; Lee Jones; Liam Girdwood; Samuel Ortiz; David Dajun Chen; Support Opensource
Subject: Re: [PATCH V1 0/2] Add DA9021 support to the existing DA9052/53 driver

The title of my previous cover note is just wrong and just doesn't make sense! They were supposed to be fixes for the DA9053 driver.

Quoted 8 lines

Quoted 8 lines · Steve Twiss
Quoted 7 lines
From: Steve Twiss <[email protected]>
Two patches to add missing registers and add support for DA9053-BB silicon in the regulators component. These patches modify existing files for the Dialog Power Management IC driver for the DA9052/53 devices.

Quoted 5 lines

Quoted 5 lines
Quoted 5 lines
In this patch set the following is provided:
- [PATCH V1 1/3]: Addition of extra registers for GPIOs 8-13
- [PATCH V1 2/3]: Add regulator support for DA9053 BB silicon
This patch applies against linux-next and v4.3-rc4

Mark & Lee, these two patches for DA9052/3 are correct, but at your discretion, you are welcome to ignore them and I will resend with a cover note that makes sense later.

I shouldn't submit when I have the flu.

Steve

Mark Brown

maintainer

2015-10-12 16:42 UTC #8 lore raw

In reply to Opensource [Steve Twiss]

Quoted 7 lines · Opensource [Steve Twiss]

Quoted 1 line · On 09 October 2015 12:36 Mark Brown wrote:
Are there any dependencies between the two patches?
Nope.
I just thought because they were for MFD and regulators I would separate them. Do you want me to merge them into a single patch and re-send?

No, the point is that if you send a series the assumption will normally be that later patches depend on earlier patches so a cross tree merge or carrying things in a non-default tree is required to get everything integrated.

If there are no dependencies it's clearer to just send each patch individually.