Skip to contentSkip to conversation

webkitgtk24: use the correct Config.in option for NEON

PATCH New Thomas Petazzoni 2 participants 3 messages Oct 9, 2015

lore
Share & tools
lore

Thomas Petazzoni

author
#0 lore raw

PATCH 1/1 webkitgtk24: use the correct Config.in option for NEON

In order to enable JIT support on ARM, webkitgtk24 currently looks at BR2_ARM_ENABLE_NEON, which is not correct: BR2_ARM_CPU_HAS_NEON should be used instead.

The BR2_ARM_ENABLE_NEON is only visible for cores that select BR2_ARM_CPU_MAYBE_HAS_NEON, in order to allow to specify if his particular SoC has chosen to integrate NEON or not. And if so, BR2_ARM_CPU_HAS_NEON gets selected.

BR2_ARM_CPU_HAS_NEON is in fact selected in two different ways:

- Either directly by the CPU core selection, if NEON is mandatory in this CPU core.

- Or by BR2_ARM_ENABLE_NEON, for CPU cores where NEON support is optional.

So really, BR2_ARM_CPU_HAS_NEON is what should be used by packages.

Cc Gustavo Zacarias <[email protected]>
Signed-off-by Thomas Petazzoni <[email protected]>
---
 package/webkitgtk24/webkitgtk24.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/webkitgtk24/webkitgtk24.mk +1 -1
index a58fed3..3be1cc7 100644
@@ -88,7 +88,7 @@ endif
 
 # ARM needs NEON for JIT
 # i386 & x86_64 don't seem to have any special requirements
-ifeq ($(BR2_ARM_ENABLE_NEON)$(BR2_i386)$(BR2_x86_64),y)
+ifeq ($(BR2_ARM_CPU_HAS_NEON)$(BR2_i386)$(BR2_x86_64),y)
 WEBKITGTK24_CONF_OPTS += --enable-jit
 else
 WEBKITGTK24_CONF_OPTS += --disable-jit
Signature · 1 line
2.6.1
#1 lore raw

PATCH 1/1 webkitgtk24: use the correct Config.in option for NEON

Quoted 14 lines · Thomas Petazzoni

In order to enable JIT support on ARM, webkitgtk24 currently looks at BR2_ARM_ENABLE_NEON, which is not correct: BR2_ARM_CPU_HAS_NEON should be used instead.

The BR2_ARM_ENABLE_NEON is only visible for cores that select BR2_ARM_CPU_MAYBE_HAS_NEON, in order to allow to specify if his particular SoC has chosen to integrate NEON or not. And if so, BR2_ARM_CPU_HAS_NEON gets selected.

BR2_ARM_CPU_HAS_NEON is in fact selected in two different ways:

- Either directly by the CPU core selection, if NEON is mandatory in this CPU core.

Quoted 7 lines

- Or by BR2_ARM_ENABLE_NEON, for CPU cores where NEON support is optional.

So really, BR2_ARM_CPU_HAS_NEON is what should be used by packages.

Cc Gustavo Zacarias <[email protected]>
Signed-off-by Thomas Petazzoni <[email protected]>
Acked-by Gustavo Zacarias <[email protected]>
author Applied
#2 lore raw

PATCH 1/1 webkitgtk24: use the correct Config.in option for NEON

In reply to Thomas Petazzoni

Hello,

Quoted 17 lines · Thomas Petazzoni

In order to enable JIT support on ARM, webkitgtk24 currently looks at BR2_ARM_ENABLE_NEON, which is not correct: BR2_ARM_CPU_HAS_NEON should be used instead.

The BR2_ARM_ENABLE_NEON is only visible for cores that select BR2_ARM_CPU_MAYBE_HAS_NEON, in order to allow to specify if his particular SoC has chosen to integrate NEON or not. And if so, BR2_ARM_CPU_HAS_NEON gets selected.

BR2_ARM_CPU_HAS_NEON is in fact selected in two different ways:

- Either directly by the CPU core selection, if NEON is mandatory in this CPU core.

- Or by BR2_ARM_ENABLE_NEON, for CPU cores where NEON support is optional.

Quoted 7 lines

So really, BR2_ARM_CPU_HAS_NEON is what should be used by packages.

Cc Gustavo Zacarias <[email protected]>
Signed-off-by Thomas Petazzoni <[email protected]>
---
 package/webkitgtk24/webkitgtk24.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com