Skip to contentSkip to conversation

ntp: add ntptime option

PATCH Superseded James Knight 3 participants 3 messages Oct 5, 2015 – Oct 9, 2015

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

James Knight

author
#0 lore raw

PATCH 1/1 ntp: add ntptime option

Allow the ntptime utility to be included on a target.

Signed-off-by James Knight <[email protected]>
---
 package/ntp/Config.in | 6 ++++++
 package/ntp/ntp.mk    | 1 +
 2 files changed, 7 insertions(+)
package/ntp/Config.in +6 -0
index d4caddf..1763225 100644
@@ -67,6 +67,12 @@ config BR2_PACKAGE_NTP_NTPSNMPD
 	help
 	  Install ntpsnmpd NTP SNMP MIB agent.
 
+config BR2_PACKAGE_NTP_NTPTIME
+	bool "ntptime"
+	help
+	  The ntptime utility program is used to read and set kernel time
+	  variables.
+
 config BR2_PACKAGE_NTP_NTPTRACE
 	bool "ntptrace"
 	depends on BR2_PACKAGE_PERL
package/ntp/ntp.mk +1 -0
index 5997247..a3818ea 100644
@@ -46,6 +46,7 @@ NTP_INSTALL_FILES_$(BR2_PACKAGE_NTP_NTPDATE) += ntpdate/ntpdate
 NTP_INSTALL_FILES_$(BR2_PACKAGE_NTP_NTPDC) += ntpdc/ntpdc
 NTP_INSTALL_FILES_$(BR2_PACKAGE_NTP_NTPQ) += ntpq/ntpq
 NTP_INSTALL_FILES_$(BR2_PACKAGE_NTP_NTPSNMPD) += ntpsnmpd/ntpsnmpd
+NTP_INSTALL_FILES_$(BR2_PACKAGE_NTP_NTPTIME) += util/ntptime
 NTP_INSTALL_FILES_$(BR2_PACKAGE_NTP_NTPTRACE) += scripts/ntptrace/ntptrace
 NTP_INSTALL_FILES_$(BR2_PACKAGE_NTP_SNTP) += sntp/sntp
 NTP_INSTALL_FILES_$(BR2_PACKAGE_NTP_TICKADJ) += util/tickadj
Signature · 1 line
1.9.5.msysgit.1
#1 lore raw

PATCH 1/1 ntp: add ntptime option

Dear James Knight,

Quoted 3 lines · James Knight

Allow the ntptime utility to be included on a target.

Signed-off-by James Knight <[email protected]>
Reviewed-by Vicente Olivert Riera <[email protected]>
Tested-by Vicente Olivert Riera <[email protected]>

Build test for MIPS architecture:

$ file output/target/usr/bin/ntptime
output/target/usr/bin/ntptime: ELF 32-bit MSB executable, MIPS, MIPS32
rel2 version 1, dynamically linked (uses shared libs), for GNU/Linux
2.6.32, with unknown capability 0x41000000 = 0xf676e75, with unknown
capability 0x10000 = 0x70403, not stripped

Regards,

Vincent.

Quoted 35 lines
---
 package/ntp/Config.in | 6 ++++++
 package/ntp/ntp.mk    | 1 +
 2 files changed, 7 insertions(+)
package/ntp/Config.in +6 -0
index d4caddf..1763225 100644
@@ -67,6 +67,12 @@ config BR2_PACKAGE_NTP_NTPSNMPD
 	help
 	  Install ntpsnmpd NTP SNMP MIB agent.
 
+config BR2_PACKAGE_NTP_NTPTIME
+	bool "ntptime"
+	help
+	  The ntptime utility program is used to read and set kernel time
+	  variables.
+
 config BR2_PACKAGE_NTP_NTPTRACE
 	bool "ntptrace"
 	depends on BR2_PACKAGE_PERL
package/ntp/ntp.mk +1 -0
index 5997247..a3818ea 100644
@@ -46,6 +46,7 @@ NTP_INSTALL_FILES_$(BR2_PACKAGE_NTP_NTPDATE) += ntpdate/ntpdate
 NTP_INSTALL_FILES_$(BR2_PACKAGE_NTP_NTPDC) += ntpdc/ntpdc
 NTP_INSTALL_FILES_$(BR2_PACKAGE_NTP_NTPQ) += ntpq/ntpq
 NTP_INSTALL_FILES_$(BR2_PACKAGE_NTP_NTPSNMPD) += ntpsnmpd/ntpsnmpd
+NTP_INSTALL_FILES_$(BR2_PACKAGE_NTP_NTPTIME) += util/ntptime
 NTP_INSTALL_FILES_$(BR2_PACKAGE_NTP_NTPTRACE) += scripts/ntptrace/ntptrace
 NTP_INSTALL_FILES_$(BR2_PACKAGE_NTP_SNTP) += sntp/sntp
 NTP_INSTALL_FILES_$(BR2_PACKAGE_NTP_TICKADJ) += util/tickadj
#2 lore raw

PATCH 1/1 ntp: add ntptime option

In reply to James Knight

Dear James Knight,

package/ntp/Config.in config BR2_PACKAGE_NTP_NTPSNMPD · line 73

Quoted 4 lines · James Knight
package/ntp/Config.in +4 -0
+config BR2_PACKAGE_NTP_NTPTIME
+	bool "ntptime"
+	help
+	  The ntptime utility program is used to read and set kernel time

Line slightly too long.

package/ntp/ntp.mk NTP_INSTALL_FILES_$(BR2_PACKAGE_NTP_NTPDATE) += ntpdate/ntpdate · line 49

Quoted 9 lines
package/ntp/ntp.mk +1 -0
index 5997247..a3818ea 100644
@@ -46,6 +46,7 @@ NTP_INSTALL_FILES_$(BR2_PACKAGE_NTP_NTPDATE) += ntpdate/ntpdate
 NTP_INSTALL_FILES_$(BR2_PACKAGE_NTP_NTPDC) += ntpdc/ntpdc
 NTP_INSTALL_FILES_$(BR2_PACKAGE_NTP_NTPQ) += ntpq/ntpq
 NTP_INSTALL_FILES_$(BR2_PACKAGE_NTP_NTPSNMPD) += ntpsnmpd/ntpsnmpd
+NTP_INSTALL_FILES_$(BR2_PACKAGE_NTP_NTPTIME) += util/ntptime

This does not build here:

Quoted 1 line
Quoted 1 line
Quoted 1 line

ntp 4.2.8p3 Installing to target

install -m 755 /home/thomas/projets/buildroot/output/build/ntp-4.2.8p3/ntpd/ntpd /home/thomas/projets/buildroot/output/target/usr/sbin/ntpd test -z "util/ntptime" || install -m 755 /home/thomas/projets/buildroot/output/build/ntp-4.2.8p3/util/ntptime /home/thomas/projets/buildroot/output/target/usr/bin/
install: cannot stat ?/home/thomas/projets/buildroot/output/build/ntp-4.2.8p3/util/ntptime?: No such file or directory package/pkg-generic.mk:237: recipe for target '/home/thomas/projets/buildroot/output/build/ntp-4.2.8p3/.stamp_target_installed' failed

With the following defconfig:

BR2_arm=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_TOOLCHAIN_EXTERNAL_CUSTOM=y
BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD=y BR2_TOOLCHAIN_EXTERNAL_URL="http://autobuild.buildroot.org/toolchains/tarballs/br-arm-full-2015.08-rc1-38-gad0f85e.tar.bz2" BR2_TOOLCHAIN_EXTERNAL_GCC_4_7=y
BR2_TOOLCHAIN_EXTERNAL_HEADERS_3_10=y
BR2_TOOLCHAIN_EXTERNAL_LOCALE=y
# BR2_TOOLCHAIN_EXTERNAL_HAS_THREADS_DEBUG is not set
BR2_TOOLCHAIN_EXTERNAL_INET_RPC=y
BR2_TOOLCHAIN_EXTERNAL_CXX=y
BR2_INIT_NONE=y
BR2_SYSTEM_BIN_SH_NONE=y
# BR2_PACKAGE_BUSYBOX is not set
BR2_PACKAGE_NTP=y
# BR2_TARGET_ROOTFS_TAR is not set

Can you look into this?

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com