Skip to contentSkip to conversation

nodejs: fix typo for arm predefined macro used for atomicops

PATCH New Peter Seiderer 2 participants 3 messages Oct 11, 2015

lore
Share & tools
lore

Peter Seiderer

author
#0 lore raw

PATCH 1/1 nodejs: fix typo for arm predefined macro used for atomicops

Add patch to fix typo for arm predefined macrco in (__ARM_ARCH_6KZ__ vs. __ARM_ARCH_6ZK__) in atomicops_internals_arm_gcc.h

Fixes #8391: Node.js 0.12.7 fails to build on raspberry_pi defconfig

Signed-off-by Peter Seiderer <[email protected]>
---
 ...r-arm-predefined-macrco-in-atomicops_inte.patch | 30 ++++++++++++++++++++++
 1 file changed, 30 insertions(+)
 create mode 100644 package/nodejs/0.12.7/0005-Fix-typo-for-arm-predefined-macrco-in-atomicops_inte.patch
package/nodejs/0.12.7/0005-Fix-typo-for-arm-predefined-macrco-in-atomicops_inte.patch new file +30 -0
new file mode 100644
index 0000000..f21599c
@@ -0,0 +1,30 @@
+From b7b69cdcdb4e2d80a85e303cc3230666d565bc39 Mon Sep 17 00:00:00 2001
+From: Peter Seiderer <[email protected]>
+Date: Sun, 11 Oct 2015 09:14:52 +0200
+Subject: [PATCH] Fix typo for arm predefined macrco in
+ atomicops_internals_arm_gcc.h
+
+Fix typo  __ARM_ARCH_6KZ__ vs.  __ARM_ARCH_6ZK__, fixes
+compile for raspberry pi.
+
+Signed-off-by: Peter Seiderer <[email protected]>
+---
+ deps/v8/src/base/atomicops_internals_arm_gcc.h | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/deps/v8/src/base/atomicops_internals_arm_gcc.h b/deps/v8/src/base/atomicops_internals_arm_gcc.h
+index 069b1ff..b924981 100644
+--- a/deps/v8/src/base/atomicops_internals_arm_gcc.h
++++ b/deps/v8/src/base/atomicops_internals_arm_gcc.h
+@@ -63,7 +63,7 @@ inline void MemoryBarrier() {
+     defined(__ARM_ARCH_7R__) || defined(__ARM_ARCH_7M__) || \
+     defined(__ARM_ARCH_6__) || defined(__ARM_ARCH_6J__) || \
+     defined(__ARM_ARCH_6K__) || defined(__ARM_ARCH_6Z__) || \
+-    defined(__ARM_ARCH_6KZ__) || defined(__ARM_ARCH_6T2__)
++    defined(__ARM_ARCH_6ZK__) || defined(__ARM_ARCH_6T2__)
+ 
+ inline Atomic32 NoBarrier_CompareAndSwap(volatile Atomic32* ptr,
+                                          Atomic32 old_value,
+-- 
+2.1.4
+
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/1 nodejs: fix typo for arm predefined macro used for atomicops

Dear Peter Seiderer,

package/nodejs/0.12.7/0005-Fix-typo-for-arm-predefined-macrco-in-atomicops_inte.patch

Quoted 1 line · Peter Seiderer
package/nodejs/0.12.7/0005-Fix-typo-for-arm-predefined-macrco-in-atomicops_inte.patch +0 -0

Typo in the file name macrco -> macro.

Quoted 1 line

+Subject: [PATCH] Fix typo for arm predefined macrco in

And here as well.

Committed with these typos fixed. Please submit the patch upstream.

Thanks a lot!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#2 lore raw

PATCH 1/1 nodejs: fix typo for arm predefined macro used for atomicops

Hello Thomas,

Quoted 8 lines · Thomas Petazzoni

Dear Peter Seiderer,

package/nodejs/0.12.7/0005-Fix-typo-for-arm-predefined-macrco-in-atomicops_inte.patch

Quoted 1 line · Peter Seiderer
package/nodejs/0.12.7/0005-Fix-typo-for-arm-predefined-macrco-in-atomicops_inte.patch +0 -0

Typo in the file name macrco -> macro.

Many thanks for fixing my silly typo...

Quoted 5 lines
Quoted 1 line

+Subject: [PATCH] Fix typo for arm predefined macrco in

And here as well.

Committed with these typos fixed. Please submit the patch upstream.

O.k. will try to do...

Regards,
Peter

Quoted 4 lines

Thanks a lot!

Thomas