Skip to contentSkip to conversation

package/shairport-sync: bump to version 2.4.1

PATCH Superseded Jörg Krause 3 participants 3 messages Oct 11, 2015

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/shairport-sync: bump to version 2.4.1

Remove applied upstream patch.

---
 package/shairport-sync/shairport-sync.mk | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
package/shairport-sync/shairport-sync.mk +1 -2
index 36d5b82..bf1409b 100644
@@ -4,13 +4,12 @@
 #
 ################################################################################
 
-SHAIRPORT_SYNC_VERSION = 2.4
+SHAIRPORT_SYNC_VERSION = 2.4.1
 SHAIRPORT_SYNC_SITE = $(call github,mikebrady,shairport-sync,$(SHAIRPORT_SYNC_VERSION))
 
 SHAIRPORT_SYNC_LICENSE = MIT, BSD-3c
 SHAIRPORT_SYNC_LICENSE_FILES = LICENSES
 SHAIRPORT_SYNC_DEPENDENCIES = alsa-lib libconfig libdaemon popt host-pkgconf
-SHAIRPORT_SYNC_PATCH = https://github.com/mikebrady/shairport-sync/commit/6ae067af1f695e615415cde69a506ad330dbc45b.patch
 
 # Touching configure.ac with the patches
 SHAIRPORT_SYNC_AUTORECONF = YES
Signature · 1 line
2.6.1
#1 lore raw

PATCH 1/1 package/shairport-sync: bump to version 2.4.1

Hi J?rg,

Quoted 16 lines · J?rg Krause

Remove applied upstream patch.

---
 package/shairport-sync/shairport-sync.mk | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
package/shairport-sync/shairport-sync.mk +0 -1
index 36d5b82..bf1409b 100644
@@ -4,13 +4,12 @@
 #
 ################################################################################
 
-SHAIRPORT_SYNC_VERSION = 2.4

package/shairport-sync/shairport-sync.mk line 15

Quoted 10 lines
package/shairport-sync/shairport-sync.mk +1 -1
+SHAIRPORT_SYNC_VERSION = 2.4.1
 SHAIRPORT_SYNC_SITE = $(call github,mikebrady,shairport-sync,$(SHAIRPORT_SYNC_VERSION))
 
 SHAIRPORT_SYNC_LICENSE = MIT, BSD-3c
 SHAIRPORT_SYNC_LICENSE_FILES = LICENSES
 SHAIRPORT_SYNC_DEPENDENCIES = alsa-lib libconfig libdaemon popt host-pkgconf
-SHAIRPORT_SYNC_PATCH = https://github.com/mikebrady/shairport-sync/commit/6ae067af1f695e615415cde69a506ad330dbc45b.patch
 
 # Touching configure.ac with the patches
 SHAIRPORT_SYNC_AUTORECONF = YES

Is this still needed, then? Maybe the comment just needs an update (git clone, no configure)?

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
#2 lore raw

PATCH 1/1 package/shairport-sync: bump to version 2.4.1

Baruch, J?rg, All,

On 2015-10-11 21:58 +0300, Baruch Siach spake thusly:

Quoted 25 lines · J?rg Krause
Quoted 24 lines

Remove applied upstream patch.

---
 package/shairport-sync/shairport-sync.mk | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
package/shairport-sync/shairport-sync.mk +1 -2
index 36d5b82..bf1409b 100644
@@ -4,13 +4,12 @@
 #
 ################################################################################
 
-SHAIRPORT_SYNC_VERSION = 2.4
+SHAIRPORT_SYNC_VERSION = 2.4.1
 SHAIRPORT_SYNC_SITE = $(call github,mikebrady,shairport-sync,$(SHAIRPORT_SYNC_VERSION))
 
 SHAIRPORT_SYNC_LICENSE = MIT, BSD-3c
 SHAIRPORT_SYNC_LICENSE_FILES = LICENSES
 SHAIRPORT_SYNC_DEPENDENCIES = alsa-lib libconfig libdaemon popt host-pkgconf
-SHAIRPORT_SYNC_PATCH = https://github.com/mikebrady/shairport-sync/commit/6ae067af1f695e615415cde69a506ad330dbc45b.patch
 
Quoted 5 lines

package/shairport-sync/shairport-sync.mk line 15

Quoted 2 lines
package/shairport-sync/shairport-sync.mk +0 -0
 # Touching configure.ac with the patches
 SHAIRPORT_SYNC_AUTORECONF = YES

Is this still needed, then? Maybe the comment just needs an update (git clone, no configure)?

We do not have any bundled patch either, and that backported-from-upstream patch was not touching configure.ac:

     mdns_dns_sd.c      | 2 +-
     mdns_tinysvcmdns.c | 2 +-
     2 files changed, 2 insertions(+), 2 deletions(-)

So it is not J?rg forgetting to update the comment; it was already wrong.

But it should be fixed nonetheless, I agree.

J?rg, care to resend your patch which also updates the comment as suggested by Baruch, please? I'm marking this patch as "Changes Requested" on patchowrk.

Thanks!

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'