package/shairport-sync: bump to version 2.4.1
PATCH v2 1/1 package/shairport-sync: bump to version 2.4.1
Remove backported from upstream patch.
---
Changes v1 -> v2:
- Fix autoreconf comment (Baruch Siach)
--- package/shairport-sync/shairport-sync.mk | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
package/shairport-sync/shairport-sync.mk +2 -3
@@ -4,15 +4,14 @@ # ################################################################################ -SHAIRPORT_SYNC_VERSION = 2.4 +SHAIRPORT_SYNC_VERSION = 2.4.1 SHAIRPORT_SYNC_SITE = $(call github,mikebrady,shairport-sync,$(SHAIRPORT_SYNC_VERSION)) SHAIRPORT_SYNC_LICENSE = MIT, BSD-3c SHAIRPORT_SYNC_LICENSE_FILES = LICENSES SHAIRPORT_SYNC_DEPENDENCIES = alsa-lib libconfig libdaemon popt host-pkgconf -SHAIRPORT_SYNC_PATCH = https://github.com/mikebrady/shairport-sync/commit/6ae067af1f695e615415cde69a506ad330dbc45b.patch -# Touching configure.ac with the patches +# git clone, no configure SHAIRPORT_SYNC_AUTORECONF = YES SHAIRPORT_SYNC_CONF_OPTS = --with-alsa \
Signature · 1 line
2.6.1
PATCH v2 1/1 package/shairport-sync: bump to version 2.4.1
J?rg, All,
On 2015-10-11 23:02 +0200, J?rg Krause spake thusly:
Quoted 1 line
Remove backported from upstream patch.
You could have added something like:
Fix autoreconf comment that was wrong.
(No need to resend, it can be fixed at commit time by a maintainer).
Quoted 1 line
Signed-off-by J?rg Krause <[email protected]>
Regards,
Yann E. MORIN.
Quoted 36 lines
---
Changes v1 -> v2:
- Fix autoreconf comment (Baruch Siach)--- package/shairport-sync/shairport-sync.mk | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)package/shairport-sync/shairport-sync.mk +2
-3@@ -4,15 +4,14 @@ # ################################################################################ -SHAIRPORT_SYNC_VERSION = 2.4 +SHAIRPORT_SYNC_VERSION = 2.4.1 SHAIRPORT_SYNC_SITE = $(call github,mikebrady,shairport-sync,$(SHAIRPORT_SYNC_VERSION)) SHAIRPORT_SYNC_LICENSE = MIT, BSD-3c SHAIRPORT_SYNC_LICENSE_FILES = LICENSES SHAIRPORT_SYNC_DEPENDENCIES = alsa-lib libconfig libdaemon popt host-pkgconf -SHAIRPORT_SYNC_PATCH = https://github.com/mikebrady/shairport-sync/commit/6ae067af1f695e615415cde69a506ad330dbc45b.patch -# Touching configure.ac with the patches +# git clone, no configure SHAIRPORT_SYNC_AUTORECONF = YES SHAIRPORT_SYNC_CONF_OPTS = --with-alsa \Signature · 6 lines
2.6.1 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH v2 1/1 package/shairport-sync: bump to version 2.4.1
Dear Yann,
Quoted 9 lines · Yann E. MORIN
J?rg, All,
On 2015-10-11 23:02 +0200, J?rg Krause spake thusly:
Quoted 1 line
Remove backported from upstream patch.
You could have added something like:
????Fix autoreconf comment that was wrong.
Quoted 12 lines
(No need to resend, it can be fixed at commit time by a maintainer).
Quoted 1 line
Signed-off-by J?rg Krause <[email protected]>Reviewed-by "Yann E. MORIN" <[email protected]>Regards,
Yann E. MORIN.Quoted 3 lines
---
Changes v1 -> v2:
? - Fix autoreconf comment (Baruch Siach)
I did it in the changelog...
Best regards
J?rg Krause
PATCH v2 1/1 package/shairport-sync: bump to version 2.4.1
J?rg, All,
On 2015-10-11 23:11 +0200, J?rg Krause spake thusly:
Quoted 16 lines · Yann E. MORIN
Quoted 15 lines
J?rg, All,
On 2015-10-11 23:02 +0200, J?rg Krause spake thusly:
Quoted 1 line
Remove backported from upstream patch.
You could have added something like:
????Fix autoreconf comment that was wrong.
(No need to resend, it can be fixed at commit time by a maintainer).
Quoted 1 line
Signed-off-by J?rg Krause <[email protected]>Reviewed-by "Yann E. MORIN" <[email protected]>
Quoted 8 lines
Quoted 6 lines
Regards,
Yann E. MORIN.Quoted 3 lines
---
Changes v1 -> v2:
? - Fix autoreconf comment (Baruch Siach)I did it in the changelog...
Yeah, I saw that. However, the commit-changelog in good for noting changes between versions of the patch, so that reviewers quickly notice what has changed between those two revisions of the patch.
The commitlog proper is good for historical records, like "why on Earth did we change that comment 6 months ago?".
The commit-changelog does not end-up in the history of the project (i.e. it is dropped when a maintainer applies the patch), while the commitlog is preserved.
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH v2 1/1 package/shairport-sync: bump to version 2.4.1
In reply to Jörg KrauseDear J?rg Krause,
Quoted 9 lines · J?rg Krause
Remove backported from upstream patch.
Signed-off-by J?rg Krause <[email protected]>---
Changes v1 -> v2:
- Fix autoreconf comment (Baruch Siach)--- package/shairport-sync/shairport-sync.mk | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
Applied after tweaking the commit log as suggested by Yann, thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com