ARM: sunxi: Sinlinx SinA31s support / AXP22x dtsi conversion

The VDD-CPU and VDD-GPU regulators were incorrectly swapped.

Fixes bab03561224ba ("ARM: dts: sun6i: hummingbird: Add AXP221 regulator

       nodes")

Signed-off-by Chen-Yu Tsai <[email protected]>

---
 arch/arm/boot/dts/sun6i-a31-hummingbird.dts | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

arch/arm/boot/dts/sun6i-a31-hummingbird.dts +0 -0

index f9d9fc07bc63..e25d4924dbe7 100644
@@ -191,18 +191,18 @@
 				regulator-name = "vcc-3v0";

Hi,

Quoted 18 lines · Chen-Yu Tsai

The VDD-CPU and VDD-GPU regulators were incorrectly swapped.

Fixes bab03561224ba ("ARM: dts: sun6i: hummingbird: Add AXP221 regulator

       nodes")

Signed-off-by Chen-Yu Tsai <[email protected]>

---
 arch/arm/boot/dts/sun6i-a31-hummingbird.dts | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

arch/arm/boot/dts/sun6i-a31-hummingbird.dts +0 -0

index f9d9fc07bc63..e25d4924dbe7 100644
@@ -191,18 +191,18 @@
                              regulator-name = "vcc-3v0";
                      };
 

arch/arm/boot/dts/sun6i-a31-hummingbird.dts line 199

Quoted 8 lines

arch/arm/boot/dts/sun6i-a31-hummingbird.dts +2 -2

-                     vdd_cpu: dcdc2 {
+                     vdd_gpu: dcdc2 {
                              regulator-always-on;
                              regulator-min-microvolt = <700000>;
                              regulator-max-microvolt = <1320000>;
-                             regulator-name = "vdd-cpu";
+                             regulator-name = "vdd-gpu";
                      };

Do we need to leave the GPU regulator on ?

The VDD-CPU and VDD-GPU regulators were incorrectly swapped.

Fixes bab03561224ba ("ARM: dts: sun6i: hummingbird: Add AXP221 regulator

       nodes")

Signed-off-by Chen-Yu Tsai <[email protected]>

The AXP22x family of PMIC is used with some Allwinner SoCs. This includes the AXP221, AXP221s and AXP223. They differ in the host interface, maximum supply current for DCDC1 regulator, and default voltage and state for various LDO regulators. Also, the AXP221s does not support fine calibration of the battery fuel gauge.

This patch adds a dtsi file for all the common bindings for these PMICs. Currently this is just listing all the regulator nodes. The regulators are initialized based on their device node names.

Signed-off-by Chen-Yu Tsai <[email protected]>

Now that we have axp22x.dtsi describing common axp22x hardware, use it and reference the nodes instead of declaring the whole tree.

Also drop the "always-on" from the vdd-gpu regulator, since we don't support the GPU anyway.

And add a regulator reference for cpu0.

Signed-off-by Chen-Yu Tsai <[email protected]>

The DC5LDO regulator supplies VDD-CPUS, which is for the embedded controller in the A31 SoC.

Signed-off-by Chen-Yu Tsai <[email protected]>

Hi,

arch/arm/boot/dts/sun6i-a31s-sina31s.dts line 102

Quoted 13 lines · Chen-Yu Tsai

+&i2c0 {

arch/arm/boot/dts/sun6i-a31s-sina31s.dts new file +12 -0

+     /* Available on camera header */
+     pinctrl-names = "default";
+     pinctrl-0 = <&i2c0_pins_a>;
+     status = "okay";
+};
+
+&i2c1 {
+     /* Available on LCD header */
+     pinctrl-names = "default";
+     pinctrl-0 = <&i2c1_pins_a>;
+     status = "okay";
+};

Are those two actually used anywhere on the board itself, or just exposed on the pin headers?

Quoted 19 lines · Maxime Ripard

Hi,

arch/arm/boot/dts/sun6i-a31s-sina31s.dts line 102

Quoted 13 lines · Chen-Yu Tsai

+&i2c0 {

arch/arm/boot/dts/sun6i-a31s-sina31s.dts new file +12 -0

+     /* Available on camera header */
+     pinctrl-names = "default";
+     pinctrl-0 = <&i2c0_pins_a>;
+     status = "okay";
+};
+
+&i2c1 {
+     /* Available on LCD header */
+     pinctrl-names = "default";
+     pinctrl-0 = <&i2c1_pins_a>;
+     status = "okay";
+};

Are those two actually used anywhere on the board itself, or just exposed on the pin headers?

They are exposed as grouped headers. 1 header has all the camera related stuff, like the CSI pins, and various voltage sources from the PMIC. The other has the LCD pins, resistive touchpanel, I2C for capacitive touchpanel, and of course voltage sources.

The LCD header is an FPC connector, while the camera header is the common (common for sunxi devboards) 2.0mm pins. I'm not sure if there is some common pinout amongst vendors, but at least Sinlinx sells their own 7" LCD display w/ CTP, VGA converter, and camera modules. I have both the LCD and VGA converter.

Note that these I2C pins have valid external pull-ups. I doubt they can be easily re-purposed.

Hi,

Quoted 33 lines · Chen-Yu Tsai

Quoted 19 lines · Maxime Ripard

Hi,

arch/arm/boot/dts/sun6i-a31s-sina31s.dts line 102

Quoted 13 lines · Chen-Yu Tsai

+&i2c0 {

arch/arm/boot/dts/sun6i-a31s-sina31s.dts new file +12 -0

+     /* Available on camera header */
+     pinctrl-names = "default";
+     pinctrl-0 = <&i2c0_pins_a>;
+     status = "okay";
+};
+
+&i2c1 {
+     /* Available on LCD header */
+     pinctrl-names = "default";
+     pinctrl-0 = <&i2c1_pins_a>;
+     status = "okay";
+};

Are those two actually used anywhere on the board itself, or just exposed on the pin headers?

They are exposed as grouped headers. 1 header has all the camera related stuff, like the CSI pins, and various voltage sources from the PMIC. The other has the LCD pins, resistive touchpanel, I2C for capacitive touchpanel, and of course voltage sources.

The LCD header is an FPC connector, while the camera header is the common (common for sunxi devboards) 2.0mm pins. I'm not sure if there is some common pinout amongst vendors, but at least Sinlinx sells their own 7" LCD display w/ CTP, VGA converter, and camera modules. I have both the LCD and VGA converter.

Quoted 2 lines

Note that these I2C pins have valid external pull-ups. I doubt they can be easily re-purposed.

Still, the policy we've had so far is that if the user can use it for something else (like a GPIO, which is the case here), we don't do enforce any default, and the user will make the right choice.

Quoted 36 lines · Maxime Ripard

Hi,

Quoted 33 lines · Chen-Yu Tsai

Quoted 19 lines · Maxime Ripard

Hi,

arch/arm/boot/dts/sun6i-a31s-sina31s.dts line 102

Quoted 13 lines · Chen-Yu Tsai

+&i2c0 {

arch/arm/boot/dts/sun6i-a31s-sina31s.dts new file +12 -0

+     /* Available on camera header */
+     pinctrl-names = "default";
+     pinctrl-0 = <&i2c0_pins_a>;
+     status = "okay";
+};
+
+&i2c1 {
+     /* Available on LCD header */
+     pinctrl-names = "default";
+     pinctrl-0 = <&i2c1_pins_a>;
+     status = "okay";
+};

Are those two actually used anywhere on the board itself, or just exposed on the pin headers?

They are exposed as grouped headers. 1 header has all the camera related stuff, like the CSI pins, and various voltage sources from the PMIC. The other has the LCD pins, resistive touchpanel, I2C for capacitive touchpanel, and of course voltage sources.

The LCD header is an FPC connector, while the camera header is the common (common for sunxi devboards) 2.0mm pins. I'm not sure if there is some common pinout amongst vendors, but at least Sinlinx sells their own 7" LCD display w/ CTP, VGA converter, and camera modules. I have both the LCD and VGA converter.

Quoted 6 lines

Quoted 2 lines

Note that these I2C pins have valid external pull-ups. I doubt they can be easily re-purposed.

Still, the policy we've had so far is that if the user can use it for something else (like a GPIO, which is the case here), we don't do enforce any default, and the user will make the right choice.

To clarify, unless an actual device is connected, forcing a choice, we won't make that choice for the user, even if the connector is specifically designed for one type of application.

Did I get that right?

Quoted 45 lines · Chen-Yu Tsai

Quoted 42 lines · Maxime Ripard

Hi,

Quoted 27 lines · Chen-Yu Tsai

Quoted 19 lines · Maxime Ripard

Hi,

arch/arm/boot/dts/sun6i-a31s-sina31s.dts line 102

Quoted 13 lines · Chen-Yu Tsai

+&i2c0 {

arch/arm/boot/dts/sun6i-a31s-sina31s.dts new file +12 -0

+     /* Available on camera header */
+     pinctrl-names = "default";
+     pinctrl-0 = <&i2c0_pins_a>;
+     status = "okay";
+};
+
+&i2c1 {
+     /* Available on LCD header */
+     pinctrl-names = "default";
+     pinctrl-0 = <&i2c1_pins_a>;
+     status = "okay";
+};

Are those two actually used anywhere on the board itself, or just exposed on the pin headers?

They are exposed as grouped headers. 1 header has all the camera related stuff, like the CSI pins, and various voltage sources from the PMIC. The other has the LCD pins, resistive touchpanel, I2C for capacitive touchpanel, and of course voltage sources.

Quoted 8 lines

The LCD header is an FPC connector, while the camera header is the common (common for sunxi devboards) 2.0mm pins. I'm not sure if there is some common pinout amongst vendors, but at least Sinlinx sells their own 7" LCD display w/ CTP, VGA converter, and camera modules. I have both the LCD and VGA converter.

Note that these I2C pins have valid external pull-ups. I doubt they can be easily re-purposed.

Still, the policy we've had so far is that if the user can use it for something else (like a GPIO, which is the case here), we don't do enforce any default, and the user will make the right choice.

Quoted 5 lines

To clarify, unless an actual device is connected, forcing a choice, we won't make that choice for the user, even if the connector is specifically designed for one type of application.

Did I get that right?

Yep.