Resolved compilation issue for arm64 uboot
PATCH 1/1 Resolved compilation issue for arm64 uboot
From: Ronak Desai <[email protected]>
This patch has been added to resolve the compilation issue of arm64 uboot.
For aarch64 architecture, kernel uses arm64 terminology and thus from top-level Makefile KERNEL_ARCH is modified to arm64 for aarch64 which then passed to uboot compilation. But, it causes compilation issue while including architecture specific Makefile under arch/$(ARCH)/Makefile as uboot uses top-level system architecture as arm only.
--- boot/uboot/uboot.mk | 9 +++++++++ 1 file changed, 9 insertions(+)
boot/uboot/uboot.mk +9 -0
@@ -71,7 +71,16 @@ UBOOT_BIN = u-boot.bin UBOOT_BIN_IFT = $(UBOOT_BIN).ift endif +# For aarch64 architecture, kernel uses arm64 terminology and thus from +# # top-level Makefile KERNEL_ARCH is modified to arm64 for aarch64 which +# # then passed to uboot compilation. But, it causes compilation issue +# # while including architecture specific Makefile under arch/$(ARCH)/Makefile +# # as uboot uses top-level system architecture as arm only. +ifeq ($(KERNEL_ARCH),arm64) +UBOOT_ARCH = arm +else UBOOT_ARCH = $(KERNEL_ARCH) +endif UBOOT_MAKE_OPTS += \ CROSS_COMPILE="$(TARGET_CROSS)" \
Signature · 1 line
1.9.1
PATCH 1/1 Resolved compilation issue for arm64 uboot
Dear Matt Weber,
Quoted 9 lines · Matt Weber
This patch has been added to resolve the compilation issue of arm64 uboot.
For aarch64 architecture, kernel uses arm64 terminology and thus from top-level
MakefileKERNEL_ARCHis modified to arm64 for aarch64 which then passed to uboot compilation. But, it causes compilation issue while including architecture specificMakefileunder arch/$(ARCH)/Makefile as uboot uses top-level system architecture as arm only.
I'm not a native english speaker, but the wording of this sentence doesn't seem quite right.
The title of the commit should be:
uboot: <something>
boot/uboot/uboot.mk UBOOT_BIN = u-boot.bin · line 78
Quoted 5 lines
boot/uboot/uboot.mk +5
-0+# For aarch64 architecture, kernel uses arm64 terminology and thus from +# # top-level Makefile KERNEL_ARCH is modified to arm64 for aarch64 which +# # then passed to uboot compilation. But, it causes compilation issue +# # while including architecture specific Makefile under arch/$(ARCH)/Makefile +# # as uboot uses top-level system architecture as arm only.
Double hashes a the beginning of each line -> not good.
Care to fix that up (especially rewording the commit log and comment) ?
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/1 Resolved compilation issue for arm64 uboot
Thomas,
Quoted 29 lines · Thomas Petazzoni
Dear Matt Weber,
Quoted 9 lines · Matt Weber
This patch has been added to resolve the compilation issue of arm64 uboot.
For aarch64 architecture, kernel uses arm64 terminology and thus from top-level
MakefileKERNEL_ARCHis modified to arm64 for aarch64 which then passed to uboot compilation. But, it causes compilation issue while including architecture specificMakefileunder arch/$(ARCH)/Makefile as uboot uses top-level system architecture as arm only.I'm not a native english speaker, but the wording of this sentence doesn't seem quite right.
The title of the commit should be:
uboot: <something>
boot/uboot/uboot.mk UBOOT_BIN = u-boot.bin · line 78
Quoted 5 lines
boot/uboot/uboot.mk +5
-0+# For aarch64 architecture, kernel uses arm64 terminology and thus from +# # top-level Makefile KERNEL_ARCH is modified to arm64 for aarch64 which +# # then passed to uboot compilation. But, it causes compilation issue +# # while including architecture specific Makefile under arch/$(ARCH)/Makefile +# # as uboot uses top-level system architecture as arm only.Double hashes a the beginning of each line -> not good.
Quoted 2 lines
Care to fix that up (especially rewording the commit log and comment) ?
Yeah, not a problem. I should have a new revision out soon.
Quoted 7 lines
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
Signature · 8 lines
Matthew L Weber / Pr Software Engineer Airborne Information Systems / Security Systems and Software / Secure Platforms MS 131-100, C Ave NE, Cedar Rapids, IA, 52498, USA www.rockwellcollins.com Note: Any Export License Required Information and License Restricted Third Party Intellectual Property (TPIP) content must be encrypted and sent to matthew.weber at corp.rockwellcollins.com.
PATCH 1/1 Resolved compilation issue for arm64 uboot
Thomas,
Quoted 33 lines · Matthew Weber
Thomas,
Quoted 29 lines · Thomas Petazzoni
Dear Matt Weber,
Quoted 9 lines · Matt Weber
This patch has been added to resolve the compilation issue of arm64 uboot.
For aarch64 architecture, kernel uses arm64 terminology and thus from top-level
MakefileKERNEL_ARCHis modified to arm64 for aarch64 which then passed to uboot compilation. But, it causes compilation issue while including architecture specificMakefileunder arch/$(ARCH)/Makefile as uboot uses top-level system architecture as arm only.I'm not a native english speaker, but the wording of this sentence doesn't seem quite right.
The title of the commit should be:
uboot: <something>
boot/uboot/uboot.mk UBOOT_BIN = u-boot.bin · line 78
Quoted 5 lines
boot/uboot/uboot.mk +5
-0+# For aarch64 architecture, kernel uses arm64 terminology and thus from +# # top-level Makefile KERNEL_ARCH is modified to arm64 for aarch64 which +# # then passed to uboot compilation. But, it causes compilation issue +# # while including architecture specific Makefile under arch/$(ARCH)/Makefile +# # as uboot uses top-level system architecture as arm only.Double hashes a the beginning of each line -> not good.
Quoted 4 lines
Quoted 2 lines
Care to fix that up (especially rewording the commit log and comment) ?
Yeah, not a problem. I should have a new revision out soon.
I went ahead and marked this one as superseded.
Quoted 20 lines
Quoted 8 lines
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com--
Matthew L Weber / Pr Software Engineer
Airborne Information Systems / Security Systems and Software / Secure Platforms MS 131-100, C Ave NE, Cedar Rapids, IA, 52498, USA www.rockwellcollins.comNote: Any Export License Required Information and License Restricted Third Party Intellectual Property (TPIP) content must be encrypted and sent to matthew.weber at corp.rockwellcollins.com.
Signature · 8 lines
Matthew L Weber / Pr Software Engineer Airborne Information Systems / Security Systems and Software / Secure Platforms MS 131-100, C Ave NE, Cedar Rapids, IA, 52498, USA www.rockwellcollins.com Note: Any Export License Required Information and License Restricted Third Party Intellectual Property (TPIP) content must be encrypted and sent to matthew.weber at corp.rockwellcollins.com.